From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9FDBA2EEB for ; Fri, 13 Sep 2019 16:40:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00BF11F0A5; Fri, 13 Sep 2019 16:40:33 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id DEA711F08E for ; Fri, 13 Sep 2019 16:40:25 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id a1so4877519ioc.6 for ; Fri, 13 Sep 2019 07:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4KgSwQKastM0Ij0z/Iphu6NACwgllNz4y10PmfzkLAQ=; b=sOhzi6p4ZvolwjXDod36oe2GkOLyCm7e19PL+tO1IiTJPzjXMESp+wgDKemFCIT5rA XtL/dS+43X6dqdpL+o1Ipxsx3dVkUSz3Wa4YiBmsQEG+CLkyKinN9zHwmkmpl0tS0CuN gsNe4/DILuTNpJurwfERzN3Uaef7tbuq2Gf/yIhPnbFuQEcGGgKg4rxLAgx8HGt12Blt dJvjo8bXAwDAnbc/dHy66Ux3oAsNB90o6iDSptbUQDlWfnC8D3qlif2KZkt7tnQ76aLl kR3GoDtbf1O/aefdgHq8vrkIrIMSzckja7NPQudTqFw2aMg2+RZS3DFvrc1Xr2izZfsL L3dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4KgSwQKastM0Ij0z/Iphu6NACwgllNz4y10PmfzkLAQ=; b=HH7MXV2tIVBFT9Z4IdjIStUgyTMIwZLHH3auBo5lkuDTQOFqq8vKSOHU+hHwFJIFz+ fM9fbl1tgZWmxvjhTtAqvzcF3CMk081zAAM/dkcDil51JZrLC4mJq75JCzu8f0paq3ve LGK076f5l+QAwVC4La8CWDIzWr58f8oC4HBlNxj5BsND/Zr6XASH5jmwYr0S++VkTuc/ GzT0s7iYlO6oDHPsmX1l81BnveTv31dIFTpJEaI16tstFau0gbvRsv/OnLOPQmnFqHxk 4/AkvoJyJ2HH9y/V6j2+EThbyVZ12q8VkJ6MIKfb6xsZ55tGsgjDEb5UBiGCWOLnmTiT TKXA== X-Gm-Message-State: APjAAAXIQVe+1SOwcAKAnQK0GOcJuWSBxg1w5YRB86+1rx3qCPjTR2eF FM2yk5cxxpgB2Y+7KpKrK01lr+PuL0gkb8O4sVHDbtYs9DZ50w== X-Google-Smtp-Source: APXvYqxFtMc0VGLuI+FWHxjaShfWmXR6/MxP2YQKhc44dWyW0qUz3+AOHANDcB7BSCn0U192CmQ10shjbzuWEUFDDmA= X-Received: by 2002:a6b:c895:: with SMTP id y143mr190033iof.271.1568385624998; Fri, 13 Sep 2019 07:40:24 -0700 (PDT) MIME-Version: 1.0 References: <20190816041955.69877-1-ndabilpuram@marvell.com> In-Reply-To: <20190816041955.69877-1-ndabilpuram@marvell.com> From: Jerin Jacob Date: Fri, 13 Sep 2019 20:10:13 +0530 Message-ID: To: Nithin Dabilpuram Cc: Jerin Jacob , Kiran Kumar K , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 16, 2019 at 9:50 AM Nithin Dabilpuram wrote: > > This patch fixes configuration for port Tx vlan insertion feature. > As per latest Tx KEX profile, pf_func should be at > KW[0](47:32) and not KW[1](63:48). > > Fixes: 168c59cfe42b ("net/octeontx2: add flow MCAM utility functions") > Cc: kirankumark@marvell.com Cc: stable@dpdk.org > > Signed-off-by: Nithin Dabilpuram Acked-by: Jerin Jacob > --- > drivers/net/octeontx2/otx2_vlan.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_vlan.c b/drivers/net/octeontx2/otx2_vlan.c > index c01089b..2be7671 100644 > --- a/drivers/net/octeontx2/otx2_vlan.c > +++ b/drivers/net/octeontx2/otx2_vlan.c > @@ -468,9 +468,9 @@ nix_vlan_handle_default_tx_entry(struct rte_eth_dev *eth_dev, > pf_func = (dev->pf_func & 0xff) << 8; > pf_func |= (dev->pf_func >> 8) & 0xff; > > - /* PF Func extracted to KW1[63:48] */ > - entry.kw[1] = (uint64_t)pf_func << 48; > - entry.kw_mask[1] = (BIT_ULL(16) - 1) << 48; > + /* PF Func extracted to KW1[47:32] */ > + entry.kw[0] = (uint64_t)pf_func << 32; > + entry.kw_mask[0] = (BIT_ULL(16) - 1) << 32; > > nix_set_tx_vlan_action(&entry, type, vtag_index); > vlan->def_tx_mcam_ent = entry; > -- > 2.8.4 >