From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 478414308C; Thu, 17 Aug 2023 10:57:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D802A40EE2; Thu, 17 Aug 2023 10:57:47 +0200 (CEST) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by mails.dpdk.org (Postfix) with ESMTP id EE94640685 for ; Thu, 17 Aug 2023 10:57:46 +0200 (CEST) Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-44bf85e9b39so327261137.0 for ; Thu, 17 Aug 2023 01:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692262666; x=1692867466; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oowqCPDjQjevO+qoftdQU0H8JKAKIA0ru6lMJwFiSw8=; b=HQKQjYrA/CtUT2a4L8k2fuR92SFDRUet3s+9h9IbAWQTkD8e5vNwLA2vhcdsNFbn05 +XKXvXqMwj+MdVld7+1sEG600+m1EM5mXLSBegtlq+AYsvKVOlf4c6nve9VdA6FZnWl1 k9JIDO2MxpJM2INTthZ6ZwRu/34oGI4UrKN3xyAJhXupvR8dW40TCVeRv1bjuLwb7irg faB66L8O1h31c7RaoT1iJxZW2HGRFKf68HJfVrc5ji9J8IIGkSc3UKAUw/rjkDIyZq0l /Op1ae+O+nZRai73DX96AMELlXkjS2Wg84klw/jcO+tXLzgyFU2GG1NOW9AjEvE5FWsT 9VpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692262666; x=1692867466; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oowqCPDjQjevO+qoftdQU0H8JKAKIA0ru6lMJwFiSw8=; b=i9f7cGQIWGul5MvveSYPVEYPBQJfzSiZ/CR9lrUDxHuqEPQZK8bTPfGqOEL0Q701Bc uwrBSseg77hx7vvzY1j+rbPcX00jIxzbokRfVUa3rXPvEev2Ez8GnTcZyPh++5VxrAQK Bv07kEN0CRFz9loT5J8eXwqMGA/vVgDpd1XP/PycRMsNnK8jdMp1GmEI051H7DGoCh3N FAqr4/nU5rzhRaqXaRbSJ/Tg9xGAVOvRmAmsSApqmr4lnNvfZOm4brZe/JAuP/pp3z3B dQbA1L7Q7NQrR7X/UC3QvXmJikWU2nbY8YMediwmWoazwAeLexT22GxtdtxzqYOl83H7 I+Sw== X-Gm-Message-State: AOJu0YwSMcIXKvrAa7lpnE2CgbN1JOwQFZMyoKk7nYk3+hnw62s5eHL+ s4L6wJhc6WTbe1SZa+rLqK3o/UTXlaljE8dO84U= X-Google-Smtp-Source: AGHT+IGzerFj71bhCgTdI6w7Y/oMcfU0vLfiMuBi35zTIeXCoOTVAtwGh+8aBBjIyAmO6z+SuCNz1B4NkiSrw57PBUE= X-Received: by 2002:a67:bc01:0:b0:447:8e20:6e2e with SMTP id t1-20020a67bc01000000b004478e206e2emr3709818vsn.34.1692262666228; Thu, 17 Aug 2023 01:57:46 -0700 (PDT) MIME-Version: 1.0 References: <20230817053710.3985750-1-s.v.naga.harish.k@intel.com> <20230817060318.4101024-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20230817060318.4101024-1-s.v.naga.harish.k@intel.com> From: Jerin Jacob Date: Thu, 17 Aug 2023 14:27:20 +0530 Message-ID: Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API To: Naga Harish K S V Cc: dev@dpdk.org, jay.jayatheerthan@intel.com, Erik Gabriel Carrillo , "Gujjar, Abhinandan S" , "McDaniel, Timothy" , Pavan Nikhilesh , Shijith Thotton , Hemant Agrawal , Sachin Saxena , "Van Haaren, Harry" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Liang Ma , Peter Mccarthy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 17, 2023 at 11:33=E2=80=AFAM Naga Harish K S V wrote: > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > creating Rx adapter instance. This API is similar to > rte_event_eth_rx_adapter_create_ext() with an additional input > argument for adapter configuration parameters of type > "struct rte_event_eth_rx_adapter_params". > > Signed-off-by: Naga Harish K S V > + */ > +__rte_experimental > +int __rte_cold Is there any specific reason to keep __rte_cold here? None of the other libraries has this. Rest looks good to me. For library changes, please keep all evendev maintainers in Cc. I have added those now for this email. > +rte_event_eth_rx_adapter_create_ext_with_params(uint8_t id, uint8_t dev_= id, > + rte_event_eth_rx_adapter_conf_cb conf_cb, > + void *conf_arg, > + struct rte_event_eth_rx_adapter_params *rxa_param= s);