From: Jerin Jacob <jerinjacobk@gmail.com>
To: Kiran Kumar K <kirankumark@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] test/graph: fix memory leak
Date: Thu, 14 May 2020 13:29:00 +0530 [thread overview]
Message-ID: <CALBAE1PjafnhiHEGFvLZ8iOaep3e-qKzgEC-R0ZLe0M5sg6dwg@mail.gmail.com> (raw)
In-Reply-To: <20200514033140.11340-1-kirankumark@marvell.com>
On Thu, May 14, 2020 at 9:02 AM <kirankumark@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> Fix memory leaks reported by coverity.
Please add Coverity issue: and Fixes: tag
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> ---
> app/test/test_graph.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_graph.c b/app/test/test_graph.c
> index cf6df0744..ed69eda99 100644
> --- a/app/test/test_graph.c
> +++ b/app/test/test_graph.c
> @@ -12,6 +12,7 @@
> #include <rte_graph.h>
> #include <rte_graph_worker.h>
> #include <rte_mbuf.h>
> +#include <rte_random.h>
>
> #include "test.h"
>
> @@ -145,7 +146,7 @@ uint16_t
> test_node_worker_source(struct rte_graph *graph, struct rte_node *node,
> void **objs, uint16_t nb_objs)
> {
> - uint32_t obj_node0 = rand() % 100, obj_node1;
> + uint32_t obj_node0 = rte_rand() % 100, obj_node1;
> test_main_t *tm = &test_main;
> struct rte_mbuf *data;
> void **next_stream;
> @@ -193,7 +194,7 @@ test_node0_worker(struct rte_graph *graph, struct rte_node *node, void **objs,
> test_main_t *tm = &test_main;
>
> if (*(uint32_t *)node->ctx == test_node0.id) {
> - uint32_t obj_node0 = rand() % 100, obj_node1;
> + uint32_t obj_node0 = rte_rand() % 100, obj_node1;
> struct rte_mbuf *data;
> uint8_t second_pass = 0;
> uint32_t count = 0;
> @@ -496,6 +497,7 @@ test_lookup_functions(void)
> printf("Test number of edges for node = %s failed Expected = %d, got %d\n",
> tm->test_node[i].node.name,
> tm->test_node[i].node.nb_edges, count);
> + free(next_edges);
> return -1;
> }
>
> @@ -505,6 +507,7 @@ test_lookup_functions(void)
> printf("Edge name miss match, expected = %s got = %s\n",
> tm->test_node[i].node.next_nodes[j],
> next_edges[j]);
> + free(next_edges);
> return -1;
> }
> }
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-05-14 7:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 3:31 kirankumark
2020-05-14 7:59 ` Jerin Jacob [this message]
2020-05-14 9:07 ` [dpdk-dev] [PATCH v2] " kirankumark
2020-05-14 11:24 ` [dpdk-dev] [PATCH v3] test/graph: fix coverity issues kirankumark
2020-05-15 7:05 ` Jerin Jacob
2020-05-15 7:28 ` [dpdk-dev] [PATCH v4] " kirankumark
2020-05-15 8:14 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PjafnhiHEGFvLZ8iOaep3e-qKzgEC-R0ZLe0M5sg6dwg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).