From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22E2442653; Wed, 27 Sep 2023 17:44:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC62140271; Wed, 27 Sep 2023 17:44:51 +0200 (CEST) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by mails.dpdk.org (Postfix) with ESMTP id 81F0B4026B for ; Wed, 27 Sep 2023 17:44:50 +0200 (CEST) Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-4526d872941so5352258137.1 for ; Wed, 27 Sep 2023 08:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695829490; x=1696434290; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ls0nBFhH2Da61mDqE4BJQBUAlWr35op20XE9VvsJeG8=; b=Uoul0Ft7Vq/dQIHOMCIzRw5WIaP+791jK++oxNL2q9w1W3HkgT8ChLmhC6lSvofz7k rSlGtv3V49FiQLYEv4JhJ+T67/R/DrRKcThEOsbPN4ZgBMoYoYYib2v0d5ba5xhtdzwp 0amTikLU0obeRliRd4QqDAVic0Ghd5ck4/EIMxCO8VAxdAackGupSN72MJ2sARfGRBJA 16fTrMZX17r3wZPeW5xP4UK04imiP1dKxMqJ3sJiA6XqhcqN3fZk4PAHckZvaqE2ZA6V SiTzm2IXmNKe0sdkOj+zEy8M2Y2Esd+13A4pGw6Yci2oI0+A9S25xrW1KNd3VM94yrOs uSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695829490; x=1696434290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ls0nBFhH2Da61mDqE4BJQBUAlWr35op20XE9VvsJeG8=; b=aQeffqPlOIp8TB2PqtfBk3LB+Sk95mc4XDJtYI+971uFt0cPmZImIYqY1crDyOq0lJ JsMQgwEqbjnEb04nK4zFN63pAMnQSYK0TEZm/BNH8PAL7U7F+aGO8MWsZk05LzhtcZpj hvlGJbjdWCibB3aEBbUixltCqrf1V9ffAyDKVTHHufp8VeBL72MmBb7LGnhfdkkjWrLL S2ZK58mI5ssA3OiDrz41ztVq0RTcWEjJJ1orJ34vUH+NpZraI2iXwmGswXTVkX2vUiBT QT0zml/VFpsDZZuHQCBTiV8wcGotTc2lsrDy+syoXdU9b2qXUteOiI25rAZWsjLPX/mx wksw== X-Gm-Message-State: AOJu0Yx0ccjmOOVOK1DilwoFY1U4oY4LPCSuA3YXXmoaIsxk28Zt/XAn KFAloJuY0zTJt1Qmuinhb8Hxq/rmY/ABb/VV3lk= X-Google-Smtp-Source: AGHT+IEWZAhf7vsPJFYz/5nLRcr8YXbqV88sb54ek2OVyXhcQ3J/idWhn/tfj4KFoDiXUqR/by4h08V661I6zPJiCTs= X-Received: by 2002:a67:db14:0:b0:451:64e:4645 with SMTP id z20-20020a67db14000000b00451064e4645mr2584618vsj.12.1695829488927; Wed, 27 Sep 2023 08:44:48 -0700 (PDT) MIME-Version: 1.0 References: <20230921074637.4043468-1-adwivedi@marvell.com> In-Reply-To: <20230921074637.4043468-1-adwivedi@marvell.com> From: Jerin Jacob Date: Wed, 27 Sep 2023 21:14:22 +0530 Message-ID: Subject: Re: [PATCH v1] common/cnxk: fix initialization of MCAM ID To: Ankur Dwivedi Cc: dev@dpdk.org, jerinj@marvell.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 21, 2023 at 1:16=E2=80=AFPM Ankur Dwivedi wrote: > > The start and end mcam id is initialized when aged_flows_cnt is 0. The > boolean variable aging_enabled is not needed. > > Fixes: d110c44d29e7 ("common/cnxk: support flow aging") > > Signed-off-by: Ankur Dwivedi Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: fix aging initialization The start and end mcam id is initialized when aged_flows_cnt is 0. The boolean variable aging_enabled is not needed. Fixes: d110c44d29e7 ("common/cnxk: support flow aging") Cc: stable@dpdk.org Signed-off-by: Ankur Dwivedi > --- > drivers/common/cnxk/roc_npc_aging.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/common/cnxk/roc_npc_aging.c b/drivers/common/cnxk/ro= c_npc_aging.c > index 874a7cd4ff..4b845954b4 100644 > --- a/drivers/common/cnxk/roc_npc_aging.c > +++ b/drivers/common/cnxk/roc_npc_aging.c > @@ -56,7 +56,6 @@ check_timeout_cycles(struct roc_npc *roc_npc, uint32_t = mcam_id) > struct npc_age_flow_list_head *list; > struct npc_age_flow_entry *fl_iter; > struct roc_npc_flow_age *flow_age; > - bool aging_enabled =3D false; > > flow_age =3D &roc_npc->flow_age; > list =3D &npc->age_flow_list; > @@ -65,10 +64,9 @@ check_timeout_cycles(struct roc_npc *roc_npc, uint32_t= mcam_id) > fl_iter->flow->timeout_cycles < plt_tsc_cycles()) { > /* update bitmap */ > plt_bitmap_set(flow_age->aged_flows, mcam_id); > - if (!aging_enabled) { > + if (flow_age->aged_flows_cnt =3D=3D 0) { > flow_age->start_id =3D mcam_id; > flow_age->end_id =3D mcam_id; > - aging_enabled =3D true; > } > if (flow_age->start_id > mcam_id) > flow_age->start_id =3D mcam_id; > -- > 2.25.1 >