Re: [dpdk-dev] [PATCH] net/qede: remove dead code

[Jerin Jacob <jerinjacobk@gmail.com>]

On Fri, Jul 17, 2020 at 4:47 PM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This patch fixes (Logically dead code) coverity issue.
>
> Coverity issue: 261777, 261778
> Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
> Cc: stable@dpdk.org

@Rasesh Mody
Could you Ack this change to merge it?


> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
>  drivers/net/qede/qede_rxtx.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
> index 9878ba50e..ea264f59d 100644
> --- a/drivers/net/qede/qede_rxtx.c
> +++ b/drivers/net/qede/qede_rxtx.c
> @@ -647,8 +647,6 @@ int qede_alloc_fp_resc(struct qede_dev *qdev)
>
>         for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
>                 fp = &qdev->fp_array[sb_idx];
> -               if (!fp)
> -                       continue;
>                 fp->sb_info = rte_calloc("sb", 1, sizeof(struct ecore_sb_info),
>                                 RTE_CACHE_LINE_SIZE);
>                 if (!fp->sb_info) {
> @@ -678,8 +676,6 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev)
>
>         for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
>                 fp = &qdev->fp_array[sb_idx];
> -               if (!fp)
> -                       continue;
>                 DP_INFO(edev, "Free sb_info index 0x%x\n",
>                                 fp->sb_info->igu_sb_id);
>                 if (fp->sb_info) {
> --
> 2.23.0
>
>