Re: [PATCH] eventdev/eth_rx: fix queue config get API

[Jerin Jacob <jerinjacobk@gmail.com>]

On Wed, Feb 9, 2022 at 10:40 AM Naga Harish K S V
<s.v.naga.harish.k@intel.com> wrote:
>
> the memcpy size used in queue config get function is more than
> the source size. Use correct size to avoid copy of unnecessary
> data.
>
> Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get")
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>

Hi @Jayatheerthan, Jay

Could you review it?


> ---
>  lib/eventdev/rte_event_eth_rx_adapter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index ae1e260c08..e44499e887 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -3238,7 +3238,7 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id,
>                         RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID;
>         queue_conf->servicing_weight = queue_info->wt;
>
> -       memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev));
> +       memcpy(&queue_conf->ev, qi_ev, sizeof(queue_info->event));
>
>         dev = &rte_eventdevs[rx_adapter->eventdev_id];
>         if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) {
> --
> 2.23.0
>