From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03804A04B7; Tue, 13 Oct 2020 21:12:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 323621B9CE; Tue, 13 Oct 2020 21:12:07 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 6E17E1B96F for ; Tue, 13 Oct 2020 21:12:04 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id q25so968505ioh.4 for ; Tue, 13 Oct 2020 12:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W4osF2USc+dHgDMAei38PYb7vpxBJqDyYxHizoPn7Ic=; b=BrF9ifxf0HaPghA6ydVw6VPMSucQjJexXEvwRURw1uYMhPYlTSMqHqVoBdfGywpuTT vYEniIr0L+cEKvvSQlw41UZuIvKBEdn8v33zwtcD4FCG3uePolzS5G4MGwGHbHbNMBK3 b1IeGpioG1CKj51MFBAB66i/VcWi+WLUqCYiNQ4rcwvA6D6EZaM/kwcEWvhW2j6yNNCY ON13X8vf6VLUdL4/LjaL5W4DhoFpLx8JK5gaxTFJ7BmsO0woBm7Xr0q5idE5rVaYB2e+ 8fYjqa8zMw3itRkFrKhuxiYYu9JHz7zAdhCLMkI5FH8pxCxT2iYEGN6ZNPnQbP5lXXpq f61g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W4osF2USc+dHgDMAei38PYb7vpxBJqDyYxHizoPn7Ic=; b=bMLbYVL7yXxQ9ws10VIgRvinNpxJ/S/tYKj8bnUAEMvkNOV45SdfihdP8q5zhncIIB OaTgivq0VrcwP6yb+N4cRgkjc+Q+YFT3elc5A1nqjW+GuwURTr+BP7fmQZziqfgcBZCw bjFnFlNP0u2yWqtpO4ybYKuKxHVNdkugo9lvzbiLvEHpH9MZGf0SYQkiZz/8tYQOzr/k mDX2esL4rp9AdBWbvL06M9sOXTlBUXnPMqMY4r9twcEASaoOn0qFj7yEvjLxRquHeutQ Y8uQSfKiA0drjxuuz/8BsqFTjUGiBLD29KEyxdNTiW33wH155+EXI3of5Aj8tQzAny23 +c/g== X-Gm-Message-State: AOAM533spgxyu01VYGdY8wY94xIgNutHSKDzrBXwf3a7v9CLHOIyGX+L pliJ+FaEm4xKXcLNqN7nAAq+alSMVmUerUBdCHewifb0qI01MVO4 X-Google-Smtp-Source: ABdhPJwMqnuWbwalhPICKhJr2dBrbzRrhrne0fhfBnnr2adNCBuCf34nO1vOoihjoJ4HF4/bx35L5B2GMlYWXxuo4ks= X-Received: by 2002:a02:ca48:: with SMTP id i8mr263617jal.133.1602616322815; Tue, 13 Oct 2020 12:12:02 -0700 (PDT) MIME-Version: 1.0 References: <20200908105211.10066-1-radu.nicolau@intel.com> <46118f3466274596a663d7d44abb680a@intel.com> <20200925102805.GD923@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 14 Oct 2020 00:41:46 +0530 Message-ID: To: "Ananyev, Konstantin" Cc: "Nicolau, Radu" , "Van Haaren, Harry" , Honnappa Nagarahalli , "Richardson, Bruce" , "dev@dpdk.org" , "jerinj@marvell.com" , nd Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 7, 2020 at 4:22 PM Ananyev, Konstantin wrote: > > > On 10/6/2020 11:13 AM, Ananyev, Konstantin wrote: > > >>> -----Original Message----- > > >>> From: Jerin Jacob > > >>> Sent: Monday, October 5, 2020 5:35 PM > > >>> To: Nicolau, Radu > > >>> Cc: Honnappa Nagarahalli ; Richardson, Bruce > > >>> ; Ananyev, Konstantin > > >>> ; Van Haaren, Harry > > >>> ; dev@dpdk.org; jerinj@marvell.com; nd > > >>> > > >>> Subject: Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements > > >>> > > >>> On Tue, Sep 29, 2020 at 2:32 PM Nicolau, Radu wrote: > > >>>> a concern that another library not uses public ring API, > > > but instead accesses ring internals directly. Obviously such coding practice is not welcomed > > > as it makes harder to maintain/extend ring library in future. > > > About 2) - these new API can(/shoud) be marked an experimental anyway. > > > As another thing - it is still unclear what a performance gain we are talking about here. > > > Is it really worth it comparing to just using SP/SC? > > > > The change itself came after I analyzed the memory bound sections of the > > code, and I just did a quick test, I got about 3.5% improvement in > > throughput, maybe not so much but significant for such a small change, > > and depending on the usecase it may be more. > > > > As for the implementation itself, I would favour having a custom ring > > like container in the PMD code, this will solve the issue of using > > rte_ring internals while still allow for full optimisation. If this is > > acceptable, I will follow up by tomorrow. > > Sounds ok to me. Nicolau Radu, Could you supersede this patch, if the plan is to send it to a new version based on a custom ring? > Thanks > Konstantin >