DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Timothy McDaniel <timothy.mcdaniel@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
	 Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
	Gage Eads <gage.eads@intel.com>,
	 "Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] eventdev: add PCI probe named convenience function
Date: Sun, 11 Oct 2020 15:24:25 +0530
Message-ID: <CALBAE1PpvfUD1heWC2HZRhZF0Q6-tzH=pHtyVnLkjWk4WSsQ8w@mail.gmail.com> (raw)
In-Reply-To: <CALBAE1Ns_CosfJcFG5Eajfz6RhYP44MwU0ukKNEh-nmyDZ24iQ@mail.gmail.com>

On Thu, Oct 8, 2020 at 9:56 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Tue, Oct 6, 2020 at 1:41 AM Timothy McDaniel
> <timothy.mcdaniel@intel.com> wrote:
> >
> > Add new internal wrapper function for use by pci drivers as a
> > .probe function to attach to an event interface.  Same as
> > rte_event_pmd_pci_probe, except the caller can specify the name.
> >
> > Updated rte_event_pmd_pci_probe so as to not duplicate
> > code.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> > ---
> >  lib/librte_eventdev/rte_eventdev_pmd_pci.h | 44 ++++++++++++++++++++++--------
> >  1 file changed, 32 insertions(+), 12 deletions(-)
> >
>
> >   * @internal
> > + * Wrapper for use by pci drivers as a .probe function to attach to a event
> > + * interface.
> > + */
> > +static inline int
> > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
> > +                           struct rte_pci_device *pci_dev,
> > +                           size_t private_data_size,
> > +                           eventdev_pmd_pci_callback_t devinit)
>
>
> rte_event_pmd_pci_probe() added in
> lib/librte_eventdev/rte_eventdev_version.map file.
> Please add the new function in the map file. With above change:
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>


@McDaniel, Timothy
Could you send the updated version, I would like to merge this for RC1.


>
>
>
> > +{
> > +       char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN];
> > +
> > +       rte_pci_device_name(&pci_dev->addr, eventdev_name,
> > +                       sizeof(eventdev_name));
> > +
> > +       return rte_event_pmd_pci_probe_named(pci_drv,
> > +                                            pci_dev,
> > +                                            private_data_size,
> > +                                            devinit,
> > +                                            eventdev_name);
> > +}
> > +
> > +/**
> > + * @internal
> >   * Wrapper for use by pci drivers as a .remove function to detach a event
> >   * interface.
> >   */
> > --
> > 2.6.4
> >

  reply	other threads:[~2020-10-11  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 20:12 Timothy McDaniel
2020-10-08 16:26 ` Jerin Jacob
2020-10-11  9:54   ` Jerin Jacob [this message]
2020-10-12 14:02     ` McDaniel, Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1PpvfUD1heWC2HZRhZF0Q6-tzH=pHtyVnLkjWk4WSsQ8w@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=gage.eads@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git