From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B6EBA00BE; Fri, 11 Feb 2022 08:25:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 097F441141; Fri, 11 Feb 2022 08:25:26 +0100 (CET) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id 32B35410E5 for ; Fri, 11 Feb 2022 08:25:25 +0100 (CET) Received: by mail-io1-f52.google.com with SMTP id h7so10345537iof.3 for ; Thu, 10 Feb 2022 23:25:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mu0/QTr5qwrmh0VopvEyJbCAGr+irFeSnN+obkoPxPU=; b=NPeaDgGJKX32eW9hr276zpORRXxrxCdh98kY8aGYRTBQKRSuWQ9yyMSVYrR4OTmx2s 6LIsaGMRUGgAV6Oc09XllyFY55xPE9eJsH6uMCf17hUn47YBzQQ9l3zDHnrmerDtc/Uk zM/bCVZZHAweiv5Fn/HlT4xp+7lfK8lk4Z0xw8JBXy+8K6J//I3qIPQExsw2ALca658X 42l0rIBBxug5+b/PadRtVW4jjxr92RL9AKZAWVVoiKaQOXcF/lCHOADMGxCsCvu/HBEH QRn8hyDnrsd3aRiyq5E8Qjfhw4P8SdwHgKju5tDSOO/1jM7LhXqtIN7Gf5FxO9H6Bw2d yXKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mu0/QTr5qwrmh0VopvEyJbCAGr+irFeSnN+obkoPxPU=; b=RRjAP3PfhPCE48MOIem5zf3kG4QfSM1kdWco7onX3EXVx2WqjuC3feKnxgC7vzttHI q9nmGrC5o+ueeh/FKfbY/GYRlPiKgNv2F37iKfC9vZ1fmRIiMT8u0UF36nbwAQqQIZTq bj26ZT1s30RI+FeH6F0s4YGdnBSqx3RHIwCADzuGXGj1A/NOYNeMg7ds9k0H340a+gwe yfjZ+ND7xRiFHILDjOKWlM5qrseBAc1uXCT/RVWNE35KKKx6sDcNEsFvyVn0gvQJe9ki A3xzlyDF7LTMTFkNG+OFfppsm7jL80MTfaB70mN4b8nzFapg9WBwUxYzSKhijfTI2ycC up8g== X-Gm-Message-State: AOAM530eO2DYF4yTucOdhR8J2VluI41I74MadwIEM/omyWfLlMiogENl 02S/pLxkkbQHqz5t7g4120dL3XPO/G+U/C3lG7o= X-Google-Smtp-Source: ABdhPJxUG5vYr8s6Z/6uQ4CFwwLSKPHLNSC3Sr3V/Wispk52tOd0qZTf9d4L1fF7Y8gRkQtsvjKhlhQGmJMHEVD4/YU= X-Received: by 2002:a05:6602:2c47:: with SMTP id x7mr215925iov.94.1644564323532; Thu, 10 Feb 2022 23:25:23 -0800 (PST) MIME-Version: 1.0 References: <20220210115256.2744447-1-asekhar@marvell.com> In-Reply-To: <20220210115256.2744447-1-asekhar@marvell.com> From: Jerin Jacob Date: Fri, 11 Feb 2022 12:54:57 +0530 Message-ID: Subject: Re: [PATCH] mempool/cnxk: fix bug in batch alloc issue failure path To: Ashwin Sekhar T K Cc: dpdk-dev , Jerin Jacob , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh , Kiran Kumar K , Satheesh Paul , Anoob Joseph , Akhil Goyal Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 10, 2022 at 5:19 PM Ashwin Sekhar T K wrote: > > Fix bug in batch alloc issue failure path. Please specify what is the bug and what is the fix. > > Fixes: 91531e63f4 ("mempool/cnxk: add cn10k batch dequeue") > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/mempool/cnxk/cn10k_mempool_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mempool/cnxk/cn10k_mempool_ops.c b/drivers/mempool/cnxk/cn10k_mempool_ops.c > index 4c669b878f..6ebbf91de5 100644 > --- a/drivers/mempool/cnxk/cn10k_mempool_ops.c > +++ b/drivers/mempool/cnxk/cn10k_mempool_ops.c > @@ -202,7 +202,7 @@ cn10k_mempool_deq(struct rte_mempool *mp, void **obj_table, unsigned int n) > BATCH_ALLOC_SZ, 0, 1); > /* If issue fails, try falling back to default alloc */ > if (unlikely(rc)) > - return cn10k_mempool_enq(mp, obj_table, n); > + return cnxk_mempool_deq(mp, obj_table, n); > mem->status = BATCH_ALLOC_OP_ISSUED; > } > > -- > 2.32.0 >