From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EF95A0350; Sun, 28 Jun 2020 14:23:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25CBA1C21C; Sun, 28 Jun 2020 14:23:19 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 232761C1F4 for ; Sun, 28 Jun 2020 14:23:18 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id y2so14353884ioy.3 for ; Sun, 28 Jun 2020 05:23:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=C5jDmxil4Y1aUQHNdartrTwPPYDrVvOgWJWZ3LZLWis=; b=tbcLOSdYqzIzcptiIhPcrQDgfoMex33hN1CTIaRD5bUuxCkdqC5Vg8lXtLenqdbnrL i454OmDwSachUUdo8+Fud10rO2ilMlVWgNSrhW+sZIAErwBRnKy4AnHcl8t9z7VFK3yv nO6IhKX43QJqPpjSreOu3drnTHFkDyMje1fzY4dkBi4JQf0sL4CUAitAwNqA5edpUrTv Ify3V1Q0/3fdIjNnD5dg8NQQbHBAv6FB7p6PD0VoQQ1Z7d/TP5dqXlvr116CuRKLyPjX L0uwBrN9zRZJRlbq5ftGwiDU7BEEUkNao8VsoPqduTufxBD3MTueb4hi9SS34tP1Wd5z KJMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=C5jDmxil4Y1aUQHNdartrTwPPYDrVvOgWJWZ3LZLWis=; b=uRNz4YuPOIWmQ5hwpAXpGlYmHeyrubIaAMIr+tM33279nluzZ7n35g/J8eHXCC5kdd 3tLXD2ZUTn7M1Jqwhr105fWZa8ew7SuexhxhWaihBQ3rFj6AnEwft0yvgjIVIybbZClw UNXfxFkJa2wef5oB37IMdClOkTLtw+FuLkUE4K451MRlAndrebzo1eNi3AOhYc7AflBw Jy4UxXtZT3/s/p7O6eVwJAHDbkvTZMqda5gdvsS9sJj50meKWgL9yszCzmki3WE9sV9r YXpYX+iQPsSZ169N/73+RRugpeR6tIIJw5leR2unzsYi8oO6iSZips67rqfLYHGvcoF7 uynQ== X-Gm-Message-State: AOAM531y2rKbKUneLRmJzRpWfLzbW40xab4oW+TuL4VFD5ACXc414/K1 iu3NYNqcyiwTNju6PA5tvze1pbqrxwQEz98z2os= X-Google-Smtp-Source: ABdhPJwYa4d99gpViaX/e+h0TQ9p3FrFvxgtLDRWWRggwI0je/pWa2lyb6W0t0aV+pEWZ92QC1A0vCkmR9OgPOjK8Q4= X-Received: by 2002:a05:6638:1511:: with SMTP id b17mr5833799jat.113.1593346997425; Sun, 28 Jun 2020 05:23:17 -0700 (PDT) MIME-Version: 1.0 References: <20200628055850.5275-1-rmody@marvell.com> <20200628055850.5275-5-rmody@marvell.com> In-Reply-To: <20200628055850.5275-5-rmody@marvell.com> From: Jerin Jacob Date: Sun, 28 Jun 2020 17:53:01 +0530 Message-ID: To: Rasesh Mody Cc: Jerin Jacob , Ferruh Yigit , dpdk-dev , GR-Everest-DPDK-Dev , Igor Russkikh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 4/4] net/qede: add support for get register operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jun 28, 2020 at 11:29 AM Rasesh Mody wrote: > > Add support for .get_reg eth_dev ops which will be used to collect the > firmware debug data. > > PMD on detecting on some HW errors will collect the FW/HW Dump to a > buffer and then it will save it to a file implemented in > qede_save_fw_dump(). > > Dump file location and name: > Location: or DPDK root > Name: qede_pmd_dump_mm-dd-yy_hh-mm-ss.bin > > DPDK applications can initiate a debug data collection by invoking DPDK > library=E2=80=99s rte_eth_dev_get_reg_info() API. This API invokes .get_r= eg() > interface in the PMD. > > PMD implementation of .get_reg() collects the FW/HW Dump, saves it to > data field of rte_dev_reg_info and passes it to the application. It=E2=80= =99s > the responsibility of the application to save the FW/HW Dump to a file. > We recommendation using the file name format used by qede_save_fw_dump(). > > Signed-off-by: Rasesh Mody > Signed-off-by: Igor Russkikh > --- > drivers/net/qede/Makefile | 1 + > drivers/net/qede/base/bcm_osal.c | 25 +++ > drivers/net/qede/base/bcm_osal.h | 5 + > drivers/net/qede/qede_ethdev.c | 1 + > drivers/net/qede/qede_ethdev.h | 25 +++ > drivers/net/qede/qede_regs.c | 271 +++++++++++++++++++++++++++++++ > 6 files changed, 328 insertions(+) > create mode 100644 drivers/net/qede/qede_regs.c > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethde= v.c > index 717b80839..52a4f046b 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -2430,6 +2430,7 @@ static const struct eth_dev_ops qede_eth_dev_ops = =3D { > .udp_tunnel_port_add =3D qede_udp_dst_port_add, > .udp_tunnel_port_del =3D qede_udp_dst_port_del, > .fw_version_get =3D qede_fw_version_get, > + .get_reg =3D qede_get_regs, Please update this feature in doc/guides/nics/features/qede.ini. > };