From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ashwin Sekhar T K <asekhar@marvell.com>
Cc: dev@dpdk.org, Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
jerinj@marvell.com, pbhagavatula@marvell.com,
psatheesh@marvell.com, anoobj@marvell.com, gakhil@marvell.com,
hkalra@marvell.com, Kommula Shiva Shankar <kshankar@marvell.com>
Subject: Re: [PATCH] common/cnxk: fix pool buffer size in opaque mode
Date: Wed, 18 Oct 2023 10:00:49 +0530 [thread overview]
Message-ID: <CALBAE1PvMzUbqzch3Q80hnkJwoB5Y=AWCJzxG4qrLzTXTbuAJA@mail.gmail.com> (raw)
In-Reply-To: <20231013163548.2226503-1-asekhar@marvell.com>
On Fri, Oct 13, 2023 at 10:06 PM Ashwin Sekhar T K <asekhar@marvell.com> wrote:
>
> From: Kommula Shiva Shankar <kshankar@marvell.com>
>
> Pool buffer size in opaque mode must always be set to 0.
>
> Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
>
> Signed-off-by: Kommula Shiva Shankar <kshankar@marvell.com>
> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/common/cnxk/roc_npa.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
> index b76b8e2342..6c14c49901 100644
> --- a/drivers/common/cnxk/roc_npa.c
> +++ b/drivers/common/cnxk/roc_npa.c
> @@ -517,7 +517,11 @@ npa_aura_pool_pair_alloc(struct npa_lf *lf, const uint32_t block_size,
> /* Update pool fields */
> pool->stack_base = mz->iova;
> pool->ena = 1;
> - pool->buf_size = block_size / ROC_ALIGN;
> + /* In opaque mode buffer size must be 0 */
> + if (!pool->nat_align)
> + pool->buf_size = 0;
> + else
> + pool->buf_size = block_size / ROC_ALIGN;
> pool->stack_max_pages = stack_size;
> pool->shift = plt_log2_u32(block_count);
> pool->shift = pool->shift < 8 ? 0 : pool->shift - 8;
> --
> 2.25.1
>
prev parent reply other threads:[~2023-10-18 4:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 16:35 Ashwin Sekhar T K
2023-10-18 4:29 ` Jerin Jacob
2023-10-18 4:30 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PvMzUbqzch3Q80hnkJwoB5Y=AWCJzxG4qrLzTXTbuAJA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=anoobj@marvell.com \
--cc=asekhar@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=kshankar@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=psatheesh@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).