From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76D3342B98; Thu, 25 May 2023 11:29:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5285A40DF8; Thu, 25 May 2023 11:29:14 +0200 (CEST) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by mails.dpdk.org (Postfix) with ESMTP id C259840DDB for ; Thu, 25 May 2023 11:29:12 +0200 (CEST) Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-783eb14ae3cso545899241.2 for ; Thu, 25 May 2023 02:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685006952; x=1687598952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=C2Uk4zUJslIjdlNI2Q8Db0cch9VIaFbc7ejkw9J26bM=; b=G9S5W2q67Jqjb/fmBmE0mDIKScCJW/8xLcTNTzOi/tRyLStDPD0twWMha3d1mnuTZ9 FL1N65MuvoURiutrRlaCQlSyENS8n2XxS7JxXTNg0pK6n5T9CAoPlzM9g6lI1FRQ5JjF vQVThCrY2F4PFr/YFEWrEiUpKGHB6gtd7JldSjq0AKfbyoXXrd7f7Z1so5/SGupMrnkE yjfg0hmQ6Cc4XgNNH4YkZmq0xJnVyFE/qwaLEDs6Bv+psbWTpPzML9nWx7P5tmAPr/GR kx85oA3kgv3De26YiSRg5BrftMG20WfCSZ5lwahSbznEQnGcFE3dnQ3icJRM2/003oOi WrLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685006952; x=1687598952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C2Uk4zUJslIjdlNI2Q8Db0cch9VIaFbc7ejkw9J26bM=; b=IreLzEjFPXOwYZ3NXw9VpHpbKkEmwbOZnYt4UCJHLIyJCjZFy1rxWEtvI5i7B6JFNk cLbb68HcxvH8//0EE/LxY8yyeVzGUVSV24qq3Z4yXt4NNo9ZHiFR2fQE74dWVSeDimeo XLyLFLprZEQltfCxFVAUmCEQgbddRB9/3Jx6hcg/DlBI7YSQxIfPK2EbslnGk7RSNr70 OrA7ovPtAydXTej3Mrk8rai+DLXiLe5ClK01HUlQEtQECEWKm/btGRMj8vO7ht6SIbQb Hmmfm9kNAsE8JQ7w0VqaZdVj+8L1DNgbsnRlhyTr6pYvqphbqXjUBU6058IMSfySV0E1 WlaQ== X-Gm-Message-State: AC+VfDzyezViJ2ieGFrTt78UzZlMb3BtzMLnrXuj/C+Lx8APQEcneMtV RjfX1Ayn4v/eeIelH7yu+tSDnf8xM6mcZWaQxBnl344Y8zBszw== X-Google-Smtp-Source: ACHHUZ69prFx4c2e4j5C0EyhN7zsDcddjOor592VcswyZwBK8lxVjkyECohs4DpRPhkNBG3523GD2lu46WmuPjDdaXE= X-Received: by 2002:a67:fd6f:0:b0:439:4900:c27 with SMTP id h15-20020a67fd6f000000b0043949000c27mr4599032vsa.18.1685006952069; Thu, 25 May 2023 02:29:12 -0700 (PDT) MIME-Version: 1.0 References: <20230411091144.1087887-1-ndabilpuram@marvell.com> <20230524100407.3796139-1-ndabilpuram@marvell.com> <20230524100407.3796139-32-ndabilpuram@marvell.com> In-Reply-To: <20230524100407.3796139-32-ndabilpuram@marvell.com> From: Jerin Jacob Date: Thu, 25 May 2023 14:58:45 +0530 Message-ID: Subject: Re: [PATCH v2 32/32] common/cnxk: add check for null auth and anti-replay To: Nithin Dabilpuram Cc: Kiran Kumar K , Sunil Kumar Kori , Satha Rao , jerinj@marvell.com, dev@dpdk.org, Srujana Challa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 24, 2023 at 3:38=E2=80=AFPM Nithin Dabilpuram wrote: > > From: Srujana Challa > > As per IPsec RFC, the anti-replay service can be selected for > an SA only if the integrity service is selected for that SA. > This patch adds the validation check for the same. Please fix the following in this series: [for-next-net]dell[dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh -n 32 ### [PATCH] common/cnxk: add pool BPID to RQ while using common pool WARNING:SPACING: space prohibited between function name and open parenthesi= s '(' #130: FILE: drivers/common/cnxk/roc_nix_fc.c:441: + TAILQ_FOREACH (roc_nix_tmp, roc_idev_nix_list_get(), next) { total: 0 errors, 1 warnings, 347 lines checked ### [PATCH] common/cnxk: fix CPT backpressure disable on LBK WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("")' - ie: 'Fixes: 0663a84524e5 ("common/cnxk: enable backpressure on CPT with inline inbound")' #12: Fixes: 0663a84524e ("common/cnxk: enable backpressure on CPT with inline inbound") total: 0 errors, 1 warnings, 27 lines checked ### [PATCH] common/nix: check for null derefernce WARNING:TYPO_SPELLING: 'derefernce' may be misspelled - perhaps 'dereferenc= e'? #4: Subject: [PATCH] common/nix: check for null derefernce ^^^^^^^^^^ WARNING:SPACING: space prohibited between function name and open parenthesi= s '(' #56: FILE: drivers/common/cnxk/roc_nix_fc.c:445: + TAILQ_FOREACH (roc_nix_tmp, nix_list, next) { total: 0 errors, 2 warnings, 39 lines checked 29/32 valid patches [for-next-net]dell[dpdk-next-net-mrvl] $ > > Signed-off-by: Srujana Challa <schalla@marvell.com> > --- > drivers/common/cnxk/cnxk_security.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/common/cnxk/cnxk_security.c b/drivers/common/cnxk/cn= xk_security.c > index 13ca2c7791..a8c3ba90cd 100644 > --- a/drivers/common/cnxk/cnxk_security.c > +++ b/drivers/common/cnxk/cnxk_security.c > @@ -155,6 +155,10 @@ ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_= word2 *w2, > > switch (auth_xfrm->auth.algo) { > case RTE_CRYPTO_AUTH_NULL: > + if (w2->s.dir =3D=3D ROC_IE_SA_DIR_INBOUND && ips= ec_xfrm->replay_win_sz) { > + plt_err("anti-replay can't be supported w= ith integrity service disabled"); > + return -EINVAL; > + } > w2->s.auth_type =3D ROC_IE_OT_SA_AUTH_NULL; > break; > case RTE_CRYPTO_AUTH_SHA1_HMAC: > @@ -1392,6 +1396,11 @@ cnxk_on_ipsec_inb_sa_create(struct rte_security_ip= sec_xform *ipsec, > if (ret) > return ret; > > + if (crypto_xform->type !=3D RTE_CRYPTO_SYM_XFORM_AEAD && > + crypto_xform->auth.algo =3D=3D RTE_CRYPTO_AUTH_NULL && ipsec-= >replay_win_sz) { > + plt_err("anti-replay can't be supported with integrity se= rvice disabled"); > + return -EINVAL; > + } > if (crypto_xform->type =3D=3D RTE_CRYPTO_SYM_XFORM_AEAD || > auth_xform->auth.algo =3D=3D RTE_CRYPTO_AUTH_NULL || > auth_xform->auth.algo =3D=3D RTE_CRYPTO_AUTH_AES_GMAC) { > -- > 2.25.1 >