From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33328A0093; Fri, 17 Jun 2022 15:18:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB22940F19; Fri, 17 Jun 2022 15:18:29 +0200 (CEST) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by mails.dpdk.org (Postfix) with ESMTP id 3FA0F40DDD for ; Fri, 17 Jun 2022 15:18:28 +0200 (CEST) Received: by mail-qv1-f49.google.com with SMTP id q104so6340918qvq.8 for ; Fri, 17 Jun 2022 06:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dTT+IQhfR6X/6UNq/gRTgDqiI9UEkILoiAsqN1VadO4=; b=m6GoXDsyL0AcD2J7Z5JTBSkKZuueg2APRjb4jDusEmmJbhCa5LAanj7yL5aOJ0SUSB fgnBvuKnuFNcKzuscqKkjr/fF0vnVLpL3D/PrkSepQ0IliWLBXi0A0LoLSZX0gKNqkzb adgZV4HOUMGcPr4pNGdo+ZiOV7ASVOYik2rxM3bCc3HclSp9p0pEgeBCos6DCjIQFPhh yc0A9GxmsAf+i2oXsDWx/HlxMh07ZgMHfN/YlkEsc6w2aoUYdd8cUUaB0masa66uKXT7 G1PfawXzXRsUmyr7E7ufQcuCm/ldPEInygNzrOXHdBRrHPS/DaKe6EQe1Ma7jnX6VGw9 nWxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dTT+IQhfR6X/6UNq/gRTgDqiI9UEkILoiAsqN1VadO4=; b=w+d+I7+wySq26W3jKrZ4/Es7eXTxT5TCQymjRyoFDFyC2rEXTQzg5VnXkW3lEkYM7i PHDE7q6OpOa7rsEye2epjya4w8wac3jgdtGUIRMFIsDf/3Qcn7/VV0YggGVWqj/Kh/qu wfR3U145TMjjHWLWdBcC5ez5vZqyirKK3WlN9CxuSMYHvMw2yfKmsR+cwPTynZwpieLG 8J78WPtziqncuCYuEF1b8GoOGnkTJRyteNnUWykUg/8nn5guTxA1n7x6FTr+yOGugmmu pVtA3jOXa4yler15c6xKydsNREny2ihHjyc+wY54SMqHSSKxGjTBbuhYD2FKUfYoOlWm Azvw== X-Gm-Message-State: AJIora+LCzZ91iSAHRyVfii0/mlKi5L3npAlFSAPPmbecSKTt12HO9I0 U3XnTJmtpXTrfBYfLtmASp/5q80uFTpoAWmL1Sgvzqt0Etw= X-Google-Smtp-Source: AGRyM1usSCldqKGdFxWCflVW//vitcFL8+J0DuScnhKh1+KVFdR517o7i9D8vCTngxoW4P9K8G3ibpZRjC8i1gW0vhg= X-Received: by 2002:a05:6214:5f8d:b0:464:6b1b:1bf2 with SMTP id ls13-20020a0562145f8d00b004646b1b1bf2mr8232239qvb.0.1655471907565; Fri, 17 Jun 2022 06:18:27 -0700 (PDT) MIME-Version: 1.0 References: <20220614122904.159946-1-bruce.richardson@intel.com> <20220615171013.36426-1-bruce.richardson@intel.com> <20220615171013.36426-3-bruce.richardson@intel.com> In-Reply-To: <20220615171013.36426-3-bruce.richardson@intel.com> From: Jerin Jacob Date: Fri, 17 Jun 2022 18:48:01 +0530 Message-ID: Subject: Re: [PATCH v2 2/2] common/cnxk: add include for macro definition To: Bruce Richardson Cc: dpdk-dev , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 15, 2022 at 10:41 PM Bruce Richardson wrote: > > The header file "roc_io.h" uses the "__plt_always_inline" macro but > don't include "roc_platform.h" to get the definition of it. This > inclusion is not necessary for compilation, but the lack of it can > confuse some indexers - such as those in eclipse, which reports the > lines: > > "static __plt_always_inline uint64_t" > > as possible definitions of a variable called "uint64_t". This confusion > leads to uint64_t being flagged as an unknown type in all other parts of > the project being indexed, e.g. across all of DPDK code. > > Adding in the include of roc_platform.h makes it clear to the indexer > that those lines are part of a function definition, and that allows > eclipse to correctly recognise uint64_t as a type from stdint.h > > Signed-off-by: Bruce Richardson Acked-by: Jerin Jacob Applied 2/2 patch to dpdk-next-net-mrvl/for-next-net. Thanks 1/2 patch is delegated to Thomas. > --- > V2: fix copy-paste error, where header name replacement was missed > --- > drivers/common/cnxk/roc_io.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/common/cnxk/roc_io.h b/drivers/common/cnxk/roc_io.h > index 62e98d9d00..9d73e263f7 100644 > --- a/drivers/common/cnxk/roc_io.h > +++ b/drivers/common/cnxk/roc_io.h > @@ -5,6 +5,8 @@ > #ifndef _ROC_IO_H_ > #define _ROC_IO_H_ > > +#include "roc_platform.h" /* for __plt_always_inline macro */ > + > #define ROC_LMT_BASE_ID_GET(lmt_addr, lmt_id) \ > do { \ > /* 32 Lines per core */ \ > -- > 2.34.1 >