From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47969A04FA; Mon, 3 Feb 2020 10:42:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B9D01BFE2; Mon, 3 Feb 2020 10:42:19 +0100 (CET) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id E8BF11BFC4; Mon, 3 Feb 2020 10:42:17 +0100 (CET) Received: by mail-il1-f195.google.com with SMTP id v13so12024474iln.4; Mon, 03 Feb 2020 01:42:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VZ7VPHKP5KEsfsA9p9/Nwx4J9V/qcMIyiuKfjRqyg34=; b=GwecZswfb4HUtk+NmVmLuiXJJoyWwQmh5u2yeaDlHBNcGrgX+aonz++vkXc4DF9A6N m3hjC8qY8XqM0b9VzscVqLOrp0VP6TuyzJh5fBiycxT4K1CjPDPlGu+cd3AOYzgWnb8y EnCoEgS4DdPJVwGpu4lj86XUmRQ6zRTgXzpoOmtpfL0YcvneJLiwESGNKhOuctTBcCmb Mt1YIph8+2mJsQv9byLbmvfgwdz4mtMZxAU9RCOKmdG/VoEg4PrAqMj25BTb6ndPki5j 94UUFj2Qu7LefnD4nLItnkUeyhiiyEwubLIKemtAL2RGMxwbdKRnS/LSEhq/3AOxWDkN TyMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VZ7VPHKP5KEsfsA9p9/Nwx4J9V/qcMIyiuKfjRqyg34=; b=T4Dqc9XIjkxqDCynkbmFA2YJShdjC2V45hxlmlJ/Tv66MWOX2pIn2L/eEW5iM2KQf+ +daxlr1NRxTxlX7UgMng6wjM/xKOr+yAoZpiIE1nQTVriBvgb3uAXp10vvnPKxn4HsN1 1sDmXHFew+VMdDSg6vAvuzsPUHvrQ5bKaQq0ceBkOGMR47SqUFqPTvEj9h2QPFpCpLqh Rbo50GwWS/Zz3JSkaAa7U6VDn+TrPOVIMqWxmhAneM2UVL63UcihMsqPwANEOLCPskh0 k0AyQe9i1SZV7xxHw/wjlymiGFafYXIYeAgVVgGF4AJIhrPch44vpb6fB0famf2DW5jA G32g== X-Gm-Message-State: APjAAAXsd9bv2+ujdJwWCtfn49SoCRO11RFxJHY2Hfx0LpgLd8MBYN/z vg7m6R39m62Zt0IMO1X3k5IofmJtknoJsW5/ebM= X-Google-Smtp-Source: APXvYqx8S1fN5l6OJlmLQGqGTmdzUdImrbFGYPTSd+Ae7TSROS/yE4+s6bdAy3d+3rZ7AjlfSo8WT+6wofFTX9CKqB4= X-Received: by 2002:a92:3949:: with SMTP id g70mr15093979ila.294.1580722937168; Mon, 03 Feb 2020 01:42:17 -0800 (PST) MIME-Version: 1.0 References: <20200130160151.18000-1-kirankumark@marvell.com> <20200130162324.22183-1-kirankumark@marvell.com> In-Reply-To: <20200130162324.22183-1-kirankumark@marvell.com> From: Jerin Jacob Date: Mon, 3 Feb 2020 15:12:01 +0530 Message-ID: To: Kiran Kumar K , Ferruh Yigit , dpdk stable Cc: Jerin Jacob , Nithin Dabilpuram , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx2: enable full flow control for HIGIG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 30, 2020 at 9:54 PM wrote: > > From: Kiran Kumar K > > When HIGIG flow control enabled with CGX, We are disabling Tx flow control. > Added check to enable the full flow control in HIGIG mode. > > Signed-off-by: Kiran Kumar K > --- > V2 changes: > * Updated commit log Updated the commit message to: net/octeontx2: fix Tx flow control for HIGIG Tx flow controlled is disabled in the Ax silicon version due to an errata. This errata is not applicable for HIGIG Tx flow control, therefore not enabling in HIGIG case. Fixes: 602009ee2dfb ("net/octeontx2: support HIGIG2") Cc: stable@dpdk.org Signed-off-by: Kiran Kumar K Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > > drivers/net/octeontx2/otx2_flow_ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/octeontx2/otx2_flow_ctrl.c b/drivers/net/octeontx2/otx2_flow_ctrl.c > index c6d7b1971..1c6929e76 100644 > --- a/drivers/net/octeontx2/otx2_flow_ctrl.c > +++ b/drivers/net/octeontx2/otx2_flow_ctrl.c > @@ -213,6 +213,7 @@ otx2_nix_update_flow_ctrl_mode(struct rte_eth_dev *eth_dev) > > /* To avoid Link credit deadlock on Ax, disable Tx FC if it's enabled */ > if (otx2_dev_is_Ax(dev) && > + (dev->npc_flow.switch_header_type != OTX2_PRIV_FLAGS_HIGIG) && > (fc_conf.mode == RTE_FC_FULL || fc_conf.mode == RTE_FC_RX_PAUSE)) { > fc_conf.mode = > (fc_conf.mode == RTE_FC_FULL || > -- > 2.17.1 >