From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7C424331C; Mon, 13 Nov 2023 16:57:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A876D402DF; Mon, 13 Nov 2023 16:57:27 +0100 (CET) Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by mails.dpdk.org (Postfix) with ESMTP id ECD4140698 for ; Mon, 13 Nov 2023 16:57:25 +0100 (CET) Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4219f89ee21so26870851cf.3 for ; Mon, 13 Nov 2023 07:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699891045; x=1700495845; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JGY/1UFy/dKKUQx98Z8Gw2P8HIE7wdKb2Cgzwg4pXmA=; b=deMU8YtiZSlMQ5q+8gBlaqCgSbhl+XI1V9HfA1mSqFyV03yWsQSDD4HR+0Cb4FWgy7 OA0jwiwZdAtf9WGsj2aEyYHtFKUfv7Zg1rQtC6zR5KMVRuv+utCHpaEiZ7ZH+7CTvy5s qeba8Wi2HTQirH/JgOuyFb6pSyOHsQdaafurgVzYjyp13Tch6rF8i9YjGEW4f+tu1g4t PHJX9RN6waNDu9qW5Av5TkR5hfXQKYPjmKEmLulBYaL3qDdxEzZ+YJWMfKwxV0Yx82Q4 fbxeA8x4iLo+IvPzJZpa/S+j/5zr7F/JTQqtuJqOdESvJDsnd43h0BJNfNU8ZfcYorEf MBgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699891045; x=1700495845; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGY/1UFy/dKKUQx98Z8Gw2P8HIE7wdKb2Cgzwg4pXmA=; b=RuQMfDbEGYHbKrudnrNyXecyFY33M6Ru8ZBV6Ici6oQHQG9yhcB4L1e8yXgnzDoBDA CJorVR4ZTSqPoSNGtk6bfRRSYjJfKuO79sM/rN+44SmCZYYCjUFp/sNco2jBUA/VElWB 2vldOO8QXlBkHAbbk0ZYcJQ46eoedBwARXyGgtaXwOTY0O/9bDaR0loF2ZWxJ2jWWXcz 3tibWzlZOHtZwGA6ZMkmEJmSfQ4th4WzwG0iOhwZ4kNgj7JPDj1DhAx/fL/0oC8C7t/1 QIUMYYdIikuvUCz7lqdvdjwY76s5fBeqALlRT9BfvaP+Ks8qvtgDzuYMm7mN1KyQVzgo V1ug== X-Gm-Message-State: AOJu0YwECDMvgvy6Q4xbRbNM1GIZS+v8Hm8o+POw+uNNbvv4RTDtJUeJ 0jiuVW0CJNLIIbaoTmg9fsijvNWtIRXatg60EA9RXFgxgYdbLg== X-Google-Smtp-Source: AGHT+IFQ28EyeN4efpkTyiNLupWtutSU2RKhmdkxU+uQW/xVQPoFMznzpxM396HXz6Om4o4Ft0UA955T/B0WDOeNw7Q= X-Received: by 2002:ac8:5d8a:0:b0:421:a0da:afc4 with SMTP id d10-20020ac85d8a000000b00421a0daafc4mr9059475qtx.39.1699891045205; Mon, 13 Nov 2023 07:57:25 -0800 (PST) MIME-Version: 1.0 References: <20231113053115.15142-1-syalavarthi@marvell.com> In-Reply-To: <20231113053115.15142-1-syalavarthi@marvell.com> From: Jerin Jacob Date: Mon, 13 Nov 2023 21:26:58 +0530 Message-ID: Subject: Re: [PATCH v1 1/1] ml/cnxk: fix fast-path synchronization To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, jerinj@marvell.com, aprabhu@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 13, 2023 at 11:01=E2=80=AFAM Srikanth Yalavarthi wrote: > > Segfaults are reported with TVM/LLVM models as NULL value > is read by dequeue thread for the op handle. This is due > synchronization issue between enqueue and dequeue threads. > > This fix ensures the op handle written to internal request > structure is committed before the dequeue threads read the > handle value. > > Fixes: 88001b4d88de ("ml/cnxk: update fast path functions") > > Signed-off-by: Srikanth Yalavarthi Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/ml/cnxk/cnxk_ml_ops.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ml/cnxk/cnxk_ml_ops.c b/drivers/ml/cnxk/cnxk_ml_ops.= c > index 81866ceaa6..971362b242 100644 > --- a/drivers/ml/cnxk/cnxk_ml_ops.c > +++ b/drivers/ml/cnxk/cnxk_ml_ops.c > @@ -1596,6 +1596,7 @@ cnxk_ml_enqueue_burst(struct rte_ml_dev *dev, uint1= 6_t qp_id, struct rte_ml_op * > jcmdq_full: > queue->head =3D head; > qp->stats.enqueued_count +=3D count; > + rte_wmb(); > > return count; > } > -- > 2.42.0 >