From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53F36440E7; Mon, 27 May 2024 17:36:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44E1B402D4; Mon, 27 May 2024 17:36:07 +0200 (CEST) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by mails.dpdk.org (Postfix) with ESMTP id 13721402C5 for ; Mon, 27 May 2024 17:36:05 +0200 (CEST) Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6f8e7b6c5dfso408563a34.1 for ; Mon, 27 May 2024 08:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716824164; x=1717428964; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dcZ58ubEM3PQWjJl1VlvcIKoCqyxZDsx3GKOJWdTtkw=; b=EqHI250iap5Jg/CkRyYIvjy6QQZUGKiZ27mGjE3EGDaI8K/wr7hahq2wRf8GZJZVb3 xPeyWdt/sHuUn5JDoVgaEvp1OLkXSbwj0eQGRi8ktIYa23O+3m9DI9RRRL70IWKLH/xJ oaMfL0+70Z61FXfL5N86qUS9UA2esCkXRWS5/YZyl3NYnn/6VYQanGGY9Yp85uOldzfe ZnTKM1L0zROMG9Mk8WTO0ApS9yBCFcgIa2ehZhrQxwPWloCqj3RjBoZvxpfscsQ9thEI LB5KKg92mij4UQBlRsPEysrcHFsJBKlmnXiFSaKDit/y1hEaeecQwK1QBWzdHiQBATvP pMcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716824164; x=1717428964; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dcZ58ubEM3PQWjJl1VlvcIKoCqyxZDsx3GKOJWdTtkw=; b=YJLC6bIMhOqUG+KWXKXGefg0CKW3Zkx1n6RJBBjLoL8bppQK39iQjOhmPWRfMFwVsY +wSL20H1fEje0IJA5tPF+WIUkeYKCgn5qfBYVsfKp70r6PQWfMgoYr1D5+hxPdnAMTuU qZYseF3bM2jMcWhsiDnvNAtmwXMMU/b25AawpJRx69P4u7OYsRTjgp2Xeajs88xFbhla Xue11z93VC3JYl0ljz5u+WGwUFeg6h0v8xSmXzFLZ86IlA8ZS7ApklgeweXiz5ErvPcM QG1Zydqvk3G3/xsXq5/P5prvJOyPY1evDLwuPAiN0fuNVzXxozHh/LYCjfE2LON+5Rm8 FJpA== X-Forwarded-Encrypted: i=1; AJvYcCWdYa1Thlr1du3cDFTrjdm+hyP/z4/QqJ0OincHdYw/E53eiqKuuYxKSWbYIQBvbQR2b/ggZMhVyr/ACd8= X-Gm-Message-State: AOJu0Yx41ynKBYqUj8W6lYG0FnayH/bdk1WPO/+ltMPBGE3aU5qKD9v8 suS052A5UgXePbGu/8QUV/T+iCY6PXEzjWHMDYZQd2qGqXpyDxqiCH20skIcGDBKiILK3MWel+9 K7U/uiFmJRB6HRED27QHlVHobjNU= X-Google-Smtp-Source: AGHT+IE3monSqFfCmfwm+BUgDqtvkzbxaJeTDnfGafpwySURA0c4WHuGcGQ855+NcF9wK5hpxoQ9nUWnTeN4kRjpxb8= X-Received: by 2002:a05:6870:5691:b0:24f:d1aa:9bd0 with SMTP id 586e51a60fabf-24fd1aaba64mr6811282fac.13.1716824163930; Mon, 27 May 2024 08:36:03 -0700 (PDT) MIME-Version: 1.0 References: <20231109183323.2880-1-mattias.ronnblom@ericsson.com> <20240524192437.183960-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20240524192437.183960-1-mattias.ronnblom@ericsson.com> From: Jerin Jacob Date: Mon, 27 May 2024 21:05:37 +0530 Message-ID: Subject: Re: [PATCH] event/dsw: support explicit release only mode To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Jerin Jacob , dev@dpdk.org, hofors@lysator.liu.se, bruce.richardson@intel.com, Peter Nilsson J , =?UTF-8?B?U3ZhbnRlIErDpHJ2c3Ryw6V0?= , Heng Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, May 25, 2024 at 1:13=E2=80=AFAM Mattias R=C3=B6nnblom wrote: > > Add the RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE capability to the > DSW event device. > > This feature may be used by an EAL thread to pull more work from the > work scheduler, without giving up the option to forward events > originating from a previous dequeue batch. This in turn allows an EAL > thread to be productive while waiting for a hardware accelerator to > complete some operation. > > Prior to this change, DSW didn't make any distinction between > RTE_EVENT_OP_FORWARD and RTE_EVENT_OP_NEW type events, other than that > new events would be backpressured earlier. > > After this change, DSW tracks the number of released events (i.e., > events of type RTE_EVENT_OP_FORWARD and RTE_EVENT_OP_RELASE) that has > been enqueued. > > For efficency reasons, DSW does not track the *identity* of individual > events. This in turn implies that a certain stage in the flow > migration process, DSW must wait for all pending releases (on the > migration source port, only) to be received from the application, to > assure that no event pertaining to any of the to-be-migrated flows are > being processed. > > With this change, DSW starts making a distinction between forward and > new type events for credit allocation purposes. Only RTE_EVENT_OP_NEW > events needs credits. All events marked as RTE_EVENT_OP_FORWARD must > have a corresponding dequeued event from a previous dequeue batch. > > Flow migration for flows on RTE_SCHED_TYPE_PARALLEL queues remains > unaffected by this change. > > A side-effect of the tweaked DSW migration logic is that the migration > latency is reduced, regardless if implicit relase is enabled or not. > > Signed-off-by: Mattias R=C3=B6nnblom 1) Update releases for PMD specific section for this new feature 2) Fix CI issue as applicable https://patches.dpdk.org/project/dpdk/patch/20240524192437.183960-1-mattias= .ronnblom@ericsson.com/ http://mails.dpdk.org/archives/test-report/2024-May/672848.html https://github.com/ovsrobot/dpdk/actions/runs/9229147658