From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 016F9A034F; Tue, 28 Apr 2020 09:57:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD08E1D543; Tue, 28 Apr 2020 09:57:49 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 25E4E1D53E for ; Tue, 28 Apr 2020 09:57:48 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id k6so21857726iob.3 for ; Tue, 28 Apr 2020 00:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wdwtfSIBHDCxySivUSaMUNQ9Lrvg9Zvr0XyrQ7r5CWU=; b=VLNcwjQBx9UAleJmQTS7X/ovr3v1r0ZUeFkJcw55XFqTwFa5RnOzmuphoE4fOgfQHz UrNs0ajaMnoE+VNyYedLaL+gcbFXPORMWeKeGdLWnBCSDBaz75VbwcOslOVEuSxUue+H TwBg9qkcwhyY7c6AcZdB9Wmide+tO6oBFMupd8S3t9ph5WHEZLkU3G4r1l1+z21u42PO 2wHAtPTrTwBwO7DcF50CFcR2wqhZ+5j9TFEzi5ARPHc5aglmtzlgYVYHEWTzolNrzBM7 N5rSCM23g9T42/aFYrcn5bUeUve831zXy75MYoWlBmwJEfvpx96jvcawUYANcKgZ9aeR My3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wdwtfSIBHDCxySivUSaMUNQ9Lrvg9Zvr0XyrQ7r5CWU=; b=YSL97GyBJLOcjSq51RzDtVnAakMMuAN5Q8vXEsOpFinzlpRQNniHFRrP/urO5pGAFf 9bRKjQKR7hOxu7Emh3Zs4jdJBvr0+zV1BtKep0veprYdrRj+eQA9se/1g/DSuQYUlO6Z rQjgaWbea/l/+bsXpPf8g3/molBUUJdV/j/K957dKGVfiFhD5YvhctHAcfRqrj3bRb5z H1A3VLNquD/EwmH7BDgts45yaHTlOQ9k+9NP17C7BEsEUQRJU6Gv+rgSD5Vv2qTxHr6W nXsuBEhjJh+G+JeioS7j6P8M/cdwT5z+KsVarE20zykO9DY812Cm8VvVoB1GsOTItIJH shiA== X-Gm-Message-State: AGi0PubaPbpL/aLT1vNzuCYSaDxhB3Bk/D5i9stYBIvhmCZsiA3jvxv5 zqnsb7oQEJQKJafPmhhW8/22vRl5dWddwkaPe98= X-Google-Smtp-Source: APiQypJLZEm2Gs+xx4SW4wdgGO/Km8gM/K1Heo3TBeT7Mzynnsc+mqB09535ksTHFoDD1aTWzxiN4Ajxc3ZU6BXgdwI= X-Received: by 2002:a5e:9806:: with SMTP id s6mr25026824ioj.59.1588060667412; Tue, 28 Apr 2020 00:57:47 -0700 (PDT) MIME-Version: 1.0 References: <20200427215849.116064-1-thinhtr@linux.vnet.ibm.com> In-Reply-To: <20200427215849.116064-1-thinhtr@linux.vnet.ibm.com> From: Jerin Jacob Date: Tue, 28 Apr 2020 13:27:30 +0530 Message-ID: To: Thinh Tran Cc: dpdk-dev , David Christensen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 28, 2020 at 3:29 AM Thinh Tran wro= te: > > The AltiVec header file breaks boolean type: > > In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0, > from ../lib/librte_mempool/rte_mempool.h:54, > from ../lib/librte_mbuf/rte_mbuf.h:38, > from ../lib/librte_net/rte_ether.h:23, > from ../drivers/common/mlx5/mlx5_nl.h:10, > from ../drivers/common/mlx5/mlx5_nl.c:23: > ../lib/librte_eal/include/rte_trace_point.h: In function > =E2=80=98__rte_trace_point_fp_is_enabled=E2=80=99: > ../lib/librte_eal/include/rte_trace_point.h:226:9: error: incompatible > types when returning type =E2=80=98int=E2=80=99 but =E2=80=98__vector __b= ool int {aka > __vector(4) __bool int}=E2=80=99 was expected > return false; > > This is the same as > https://git.dpdk.org/dpdk/commit/?id=3D725f5dd > > and yet, there is no better solution for it > > Signed-off-by: Thinh Tran > --- > lib/librte_eal/include/rte_trace_point.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_eal/include/rte_trace_point.h b/lib/librte_eal/in= clude/rte_trace_point.h > index 4d956ec16..2ede9e3ba 100644 > --- a/lib/librte_eal/include/rte_trace_point.h > +++ b/lib/librte_eal/include/rte_trace_point.h > @@ -26,6 +26,12 @@ extern "C" { > #include > #include > > +#if defined(__PPC64__) && !defined(__APPLE_ALTIVEC__) > +#undef bool > +/* redefine as in stdbool.h */ > +#define bool _Bool > +#endif NACK. Please move the fix to rte_common.h or similar as it not specific to trace. if you do so, the following hack also not need. https://git.dpdk.org/dpdk/commit/?id=3D725f5dd > + > /** The tracepoint object. */ > typedef uint64_t rte_trace_point_t; > > -- > 2.17.1 >