From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B688A04AD; Fri, 1 May 2020 15:26:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF7271D962; Fri, 1 May 2020 15:26:25 +0200 (CEST) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 2DFFD1D95F for ; Fri, 1 May 2020 15:26:24 +0200 (CEST) Received: by mail-il1-f195.google.com with SMTP id r2so4429074ilo.6 for ; Fri, 01 May 2020 06:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7LtQN3hX0dOqm8zIfbv0bUMFj7O3NWI9kTMKD3iyPXY=; b=JlZcjnz7kHQj/+cEe+fu9749kfkf61/qUq2vCFFJ1I7ku/+hLoCzDgggCxAmQ6AcRR TzkxJLuXaKb5KQufpxviW4Hir9scvzvmEh0C/4sWVMcuDm6cvuYxm7dRz4r4gZhhvEr/ hxrxQCfwWiDZ9l6iIq6i8dLFPLT72cHaVDxCu/L4wFz3pzfmX+9/n3id5BJUIxjSB63C LsV5ZiCIfPPAkH3auP42WHgrs7/pKBxhGEMaGCDkEKAz7fl6dRNrRpdmySvLdwKCSXZW wxlukLZjyJN+5PaQ7k1svL7IgMZJPDX6cnz0M17oXnX+kDD8HIGniBG85lNQ4ar42CCG nU3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7LtQN3hX0dOqm8zIfbv0bUMFj7O3NWI9kTMKD3iyPXY=; b=iHPSz1ttAfZo0NTL1J823IdgpeXR6C+cWQJhz6oN9aW0biBeCFDRoJsGIp/lKHMvNb ge6WYCYx/95jjOz0dAoHVPSK7+fN80kANmbUziRlEXlFFx8l1sPvAAwi+dIEx+6kHtg/ kzOH/c1RQS51Zvm70jZ8bl9ld/wpngi7wSPjBpLutpT4/nX5Nn8CY0YcKJlrRrGhRjAK V5EY/gP3Vm5KPnxN9CFiIOVN80Dsx2jYEFy1ur+kbiXzG5KY3D6N8bIcV4aQTDUVDTSG 15/Icz5msgdsvIDhfrBRxoXa5JnVQ9as52MrltB03k6AvWu3FleKYvlpDFskw88erRiV vLhQ== X-Gm-Message-State: AGi0PuZt/VZkGmYkzgzqag8YF9DradoEdud3FPMFtHKBxIxjuFA5Egf9 ATP5o6fAW5DVUqPWrBon9uJ+uoN3GiM58kURq68= X-Google-Smtp-Source: APiQypIneO5WROWZPYX3KtIX2iDLoi+KCVeKgVGjuCMoNGZUGImFDKKAb1CFqk6ej2Cxe6ZkhzRoJOFCgZY0mMQC5ig= X-Received: by 2002:a92:d341:: with SMTP id a1mr3623581ilh.130.1588339583437; Fri, 01 May 2020 06:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20200427181039.1943-1-pbhagavatula@marvell.com> In-Reply-To: <20200427181039.1943-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Fri, 1 May 2020 18:56:07 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , Anatoly Burakov , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eventdev: fix device probe and remove for secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 27, 2020 at 11:40 PM wrote: > > From: Pavan Nikhilesh > > When probing event device in secondary process skip reinitializing > the device data structure as it is already done in primary process. > > When removing event device in secondary process skip closing the > event device as it should be done by primary process. > > Fixes: 322d0345c2bc ("eventdev: implement PMD registration functions") Cc: stable@dpdk.org > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob > --- > lib/librte_eventdev/rte_eventdev.c | 13 ++++++++----- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +++++--- > 2 files changed, 13 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c > index b987e0745..9aca7fbd5 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -1364,14 +1364,17 @@ rte_event_pmd_allocate(const char *name, int socket_id) > > eventdev->data = eventdev_data; > > - strlcpy(eventdev->data->name, name, RTE_EVENTDEV_NAME_MAX_LEN); > + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > > - eventdev->data->dev_id = dev_id; > - eventdev->data->socket_id = socket_id; > - eventdev->data->dev_started = 0; > + strlcpy(eventdev->data->name, name, > + RTE_EVENTDEV_NAME_MAX_LEN); > > - eventdev->attached = RTE_EVENTDEV_ATTACHED; > + eventdev->data->dev_id = dev_id; > + eventdev->data->socket_id = socket_id; > + eventdev->data->dev_started = 0; > + } > > + eventdev->attached = RTE_EVENTDEV_ATTACHED; > eventdev_globals.nb_devs++; > } > > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > index 8fb61386f..443cd38c2 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > @@ -112,9 +112,11 @@ rte_event_pmd_pci_remove(struct rte_pci_device *pci_dev, > if (eventdev == NULL) > return -ENODEV; > > - ret = rte_event_dev_close(eventdev->data->dev_id); > - if (ret < 0) > - return ret; > + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > + ret = rte_event_dev_close(eventdev->data->dev_id); > + if (ret < 0) > + return ret; > + } > > /* Invoke PMD device un-init function */ > if (devuninit) > -- > 2.17.1 >