From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ori Kam <orika@nvidia.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ferruh Yigit <ferruh.yigit@intel.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Olivier Matz <olivier.matz@6wind.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
Date: Thu, 8 Apr 2021 13:14:11 +0530 [thread overview]
Message-ID: <CALBAE1PySMiUmW1oB68Yx2nCXEpk2z=TXhJ2+Q=yBr9UTpUZKg@mail.gmail.com> (raw)
In-Reply-To: <DM6PR12MB49877C3441F9BEA6F1552FE7D6759@DM6PR12MB4987.namprd12.prod.outlook.com>
On Thu, Apr 8, 2021 at 3:45 AM Ori Kam <orika@nvidia.com> wrote:
>
> Hi Jerin,
>
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
> >
> > On Wed, Apr 7, 2021 at 4:02 PM Ori Kam <orika@nvidia.com> wrote:
> > >
> > > Hi Jerin,
> >
> > Hi Ori,
> >
> >
> > >
> > > > -----Original Message-----
> > > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > > Sent: Tuesday, April 6, 2021 10:40 AM
> > > > To: Ori Kam <orika@nvidia.com>
> > > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
> > > >
> > > > On Mon, Apr 5, 2021 at 11:35 PM Ori Kam <orika@nvidia.com> wrote:
> > > > >
> > > > > Currently, DPDK application can offload the checksum check,
> > > > > and report it in the mbuf.
> > > > >
> > > > > However, as more and more applications are offloading some or all
> > > > > logic and action to the HW, there is a need to check the packet
> > > > > integrity so the right decision can be taken.
> > > > >
> > > > > The application logic can be positive meaning if the packet is
> > > > > valid jump / do actions, or negative if packet is not valid
> > > > > jump to SW / do actions (like drop) a, and add default flow
> > > > > (match all in low priority) that will direct the miss packet
> > > > > to the miss path.
> > > > >
> > > > > Since currenlty rte_flow works in positive way the assumtion is
> > > > > that the postive way will be the common way in this case also.
> > > > >
> > > > > When thinking what is the best API to implement such feature,
> > > > > we need to considure the following (in no specific order):
> > > > > 1. API breakage.
> > > > > 2. Simplicity.
> > > > > 3. Performance.
> > > > > 4. HW capabilities.
> > > > > 5. rte_flow limitation.
> > > > > 6. Flexability.
> > > >
> > > >
> > > > Alteast in Marvell HW integrity checks are functions of the Ethdev Rx
> > > > queue attribute.
> > > > Not sure about other Vendor HW.
> > >
> > > I'm not sure what do you mean?
> >
> > What I meant is, What will be the preferred way to configure the feature?
> > ie. Is it as ethdev Rx offload or rte_flow?
> >
> > I think, in order to decide that, we need to know, how most of the
> > other HW express this feature?
> >
>
> As I see it both ways could be used,
> Maybe even by the same app,
>
> One flow is to notify the application when it sees the packet
> (RX offload) and one is to use as an item to route the packet
> when using rte_flow.
>
> Maybe I'm missing something, on your suggestion how will
> application route the packets? Or it will just receive them with flags
> on the RX queue?
Just receive them with flags on the Rx queue, in order to avoid
duplicating features
in multiple places.
>
>
>
> >
> > > This is the idea of the patch, to allow application to route the packet
> > > before getting to the Rx,
> > > In any case all items support is dependent on HW capabilities.
> >
> >
> >
> >
>
> Best,
> Ori
next prev parent reply other threads:[~2021-04-08 7:44 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 18:04 Ori Kam
2021-04-06 7:39 ` Jerin Jacob
2021-04-07 10:32 ` Ori Kam
2021-04-07 11:01 ` Jerin Jacob
2021-04-07 22:15 ` Ori Kam
2021-04-08 7:44 ` Jerin Jacob [this message]
2021-04-11 4:12 ` Ajit Khaparde
2021-04-11 6:03 ` Ori Kam
2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 0/2] " Gregory Etelson
2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 1/2] ethdev: " Gregory Etelson
2021-04-13 15:16 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add support for integrity item Gregory Etelson
2021-04-13 17:15 ` Ferruh Yigit
2021-04-14 12:56 ` [dpdk-dev] [PATCH v4 0/2] add packet integrity checks Gregory Etelson
2021-04-14 12:56 ` [dpdk-dev] [PATCH v4 1/2] ethdev: " Gregory Etelson
2021-04-14 13:27 ` Ferruh Yigit
2021-04-14 13:31 ` Ferruh Yigit
2021-04-14 12:57 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add support for integrity item Gregory Etelson
2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 0/2] add packet integrity checks Gregory Etelson
2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 1/2] ethdev: " Gregory Etelson
2021-04-14 17:24 ` Ajit Khaparde
2021-04-15 15:10 ` Ori Kam
2021-04-15 15:25 ` Ajit Khaparde
2021-04-15 16:46 ` Thomas Monjalon
2021-04-16 7:43 ` Ori Kam
2021-04-18 8:15 ` Gregory Etelson
2021-04-18 18:00 ` Thomas Monjalon
2021-04-14 16:09 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add support for integrity item Gregory Etelson
2021-04-14 16:26 ` [dpdk-dev] [PATCH v5 0/2] add packet integrity checks Ferruh Yigit
2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 " Gregory Etelson
2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 1/2] ethdev: " Gregory Etelson
2021-04-18 18:11 ` Thomas Monjalon
2021-04-18 19:24 ` Gregory Etelson
2021-04-18 21:30 ` Thomas Monjalon
2021-04-18 15:51 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add support for integrity item Gregory Etelson
2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 0/2] add packet integrity checks Gregory Etelson
2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 1/2] ethdev: " Gregory Etelson
2021-04-19 8:47 ` Thomas Monjalon
2021-04-19 8:29 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add support for integrity item Gregory Etelson
2021-04-19 11:20 ` [dpdk-dev] [PATCH v7 0/2] add packet integrity checks Ferruh Yigit
2021-04-19 12:08 ` Gregory Etelson
2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 " Gregory Etelson
2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 1/2] ethdev: " Gregory Etelson
2021-04-19 14:09 ` Ajit Khaparde
2021-04-19 16:34 ` Thomas Monjalon
2021-04-19 17:06 ` Ferruh Yigit
2021-04-19 12:44 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add support for integrity item Gregory Etelson
2021-04-19 14:09 ` Ajit Khaparde
2021-04-08 8:04 ` [dpdk-dev] [PATCH] ethdev: add packet integrity checks Andrew Rybchenko
2021-04-08 11:39 ` Ori Kam
2021-04-09 8:08 ` Andrew Rybchenko
2021-04-11 6:42 ` Ori Kam
2021-04-11 17:30 ` Ori Kam
2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 0/2] " Gregory Etelson
2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 1/2] ethdev: " Gregory Etelson
2021-04-12 17:36 ` Ferruh Yigit
2021-04-12 19:26 ` Ori Kam
2021-04-12 23:31 ` Ferruh Yigit
2021-04-13 7:12 ` Ori Kam
2021-04-13 8:03 ` Ferruh Yigit
2021-04-13 8:18 ` Ori Kam
2021-04-13 8:30 ` Ferruh Yigit
2021-04-13 10:21 ` Ori Kam
2021-04-13 17:28 ` Ferruh Yigit
2021-04-11 17:34 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for integrity item Gregory Etelson
2021-04-12 17:49 ` Ferruh Yigit
2021-04-13 7:53 ` Ori Kam
2021-04-13 8:14 ` Ferruh Yigit
2021-04-13 11:36 ` Ori Kam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PySMiUmW1oB68Yx2nCXEpk2z=TXhJ2+Q=yBr9UTpUZKg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).