From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] event/octeontx: remove selftest from dev args
Date: Fri, 20 Nov 2020 17:56:52 +0530 [thread overview]
Message-ID: <CALBAE1PyrFrs6D06-8mq-nKZtaTR6uOKX8Owoqq9+4jUeRnoRQ@mail.gmail.com> (raw)
In-Reply-To: <20201119135736.4085-2-pbhagavatula@marvell.com>
On Thu, Nov 19, 2020 at 7:28 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Since selftest now depends on dynamic mbuf fields it is not
> feasible to run selftest on device probe.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Series applied to dpdk-next-eventdev/for-main. Thanks.
> ---
> doc/guides/eventdevs/octeontx.rst | 12 ------------
> drivers/event/octeontx/ssovf_evdev.c | 22 ++++------------------
> drivers/event/octeontx/ssovf_evdev.h | 2 --
> 3 files changed, 4 insertions(+), 32 deletions(-)
>
> diff --git a/doc/guides/eventdevs/octeontx.rst b/doc/guides/eventdevs/octeontx.rst
> index 79cae9f7d..435e1e953 100644
> --- a/doc/guides/eventdevs/octeontx.rst
> +++ b/doc/guides/eventdevs/octeontx.rst
> @@ -63,18 +63,6 @@ Example:
> ./your_eventdev_application --vdev="event_octeontx"
>
>
> -Selftest
> ---------
> -
> -The functionality of OCTEON TX eventdev can be verified using this option,
> -various unit and functional tests are run to verify the sanity.
> -The tests are run once the vdev creation is successfully complete.
> -
> -.. code-block:: console
> -
> - --vdev="event_octeontx,selftest=1"
> -
> -
> Enable TIMvf stats
> ------------------
> TIMvf stats can be enabled by using this option, by default the stats are
> diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
> index 6f242aac1..e60a7dc69 100644
> --- a/drivers/event/octeontx/ssovf_evdev.c
> +++ b/drivers/event/octeontx/ssovf_evdev.c
> @@ -710,8 +710,7 @@ ssovf_close(struct rte_eventdev *dev)
> }
>
> static int
> -ssovf_selftest(const char *key __rte_unused, const char *value,
> - void *opaque)
> +ssovf_parsekv(const char *key __rte_unused, const char *value, void *opaque)
> {
> int *flag = opaque;
> *flag = !!atoi(value);
> @@ -775,10 +774,8 @@ ssovf_vdev_probe(struct rte_vdev_device *vdev)
> const char *name;
> const char *params;
> int ret;
> - int selftest = 0;
>
> static const char *const args[] = {
> - SSOVF_SELFTEST_ARG,
> TIMVF_ENABLE_STATS_ARG,
> NULL
> };
> @@ -799,18 +796,9 @@ ssovf_vdev_probe(struct rte_vdev_device *vdev)
> "Ignoring unsupported params supplied '%s'",
> name);
> } else {
> - int ret = rte_kvargs_process(kvlist,
> - SSOVF_SELFTEST_ARG,
> - ssovf_selftest, &selftest);
> - if (ret != 0) {
> - ssovf_log_err("%s: Error in selftest", name);
> - rte_kvargs_free(kvlist);
> - return ret;
> - }
> -
> - ret = rte_kvargs_process(kvlist,
> - TIMVF_ENABLE_STATS_ARG,
> - ssovf_selftest, &timvf_enable_stats);
> + ret = rte_kvargs_process(kvlist, TIMVF_ENABLE_STATS_ARG,
> + ssovf_parsekv,
> + &timvf_enable_stats);
> if (ret != 0) {
> ssovf_log_err("%s: Error in timvf stats", name);
> rte_kvargs_free(kvlist);
> @@ -877,8 +865,6 @@ ssovf_vdev_probe(struct rte_vdev_device *vdev)
> edev->max_event_ports);
>
> ssovf_init_once = 1;
> - if (selftest)
> - test_eventdev_octeontx();
> return 0;
>
> error:
> diff --git a/drivers/event/octeontx/ssovf_evdev.h b/drivers/event/octeontx/ssovf_evdev.h
> index 90d760a54..10163151c 100644
> --- a/drivers/event/octeontx/ssovf_evdev.h
> +++ b/drivers/event/octeontx/ssovf_evdev.h
> @@ -86,8 +86,6 @@
> #define SSO_GRP_GET_PRIORITY 0x7
> #define SSO_GRP_SET_PRIORITY 0x8
>
> -#define SSOVF_SELFTEST_ARG ("selftest")
> -
> /*
> * In Cavium OCTEON TX SoC, all accesses to the device registers are
> * implictly strongly ordered. So, The relaxed version of IO operation is
> --
> 2.17.1
>
prev parent reply other threads:[~2020-11-20 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 12:23 [dpdk-dev] [PATCH 1/2] event/octeontx2: " pbhagavatula
2020-11-19 12:23 ` [dpdk-dev] [PATCH 2/2] event/octeontx: " pbhagavatula
2020-11-19 13:15 ` [dpdk-dev] [PATCH 1/2] event/octeontx2: " David Marchand
2020-11-19 13:30 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2020-11-19 13:36 ` David Marchand
2020-11-19 13:45 ` Pavan Nikhilesh Bhagavatula
2020-11-19 13:57 ` [dpdk-dev] [PATCH v2 " pbhagavatula
2020-11-19 13:57 ` [dpdk-dev] [PATCH v2 2/2] event/octeontx: " pbhagavatula
2020-11-20 12:26 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PyrFrs6D06-8mq-nKZtaTR6uOKX8Owoqq9+4jUeRnoRQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).