From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7524A2F18 for ; Thu, 3 Oct 2019 07:57:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C766B1BFC4; Thu, 3 Oct 2019 07:57:32 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id AEBD71BFA1 for ; Thu, 3 Oct 2019 07:57:31 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id u8so2799461iom.5 for ; Wed, 02 Oct 2019 22:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1OZ52Q1+0g+Fly9cLxleJ47psUmUqfBaj8sBtsmwsNw=; b=uHQJ+oBnkwSUuskJcFJ/8g1LGkqGCIJzEvHiIUusltv/diYZgs6dhJChu32UPfbEiu llB6t1N6PFiJ+2TgV4vGCtaPWGgu90aajz+nYsqyGsivAJAuokFpiFlQLwH0Je0EaHZ0 men7vZDuDGDHslNJvJADVeot6gygXLK4JZLE8GH65sCDF2yGaHGs7TZGt94xRwCv1sST mjMs/Q1OYQ5X96fhv2yxvJ13qrxxtJUugP/FYtcZ+Ogy9gm4669F6WAWKCVrTVx4hEQH 8JL5hurcyAwVAtuiyWKZG4A1ysBmqGAbzvJK75vw+XHgdmo2UH5wik6hgkdezPI87Jat mTQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1OZ52Q1+0g+Fly9cLxleJ47psUmUqfBaj8sBtsmwsNw=; b=fKmC9bT9qTdD1KL/bBRqMzMqcW3mGNuub/FWohMm1ZJ4a+SRin7K1/X9cs1BrNqOxD mX4BQg1Vl16BAlGv8kgU7Y9evAINJs5cyozSVVzTANaRoMusHvYjZ2sHzXdFVBBOCHmd kp2ItQAPVSfPUxxXGDbmA8UVk2h8ohrMecLaaUGXsotoOvGgf6hpKyCsWTBtmKLPnz9V LW+j5pl01/bG4R1aySuT7G+9ticlxMIRLhZZNaN0ZH2X3gHFZbuh8ZF07jAB1DUAtiQ6 tjRGLFFUKpXf77T6CvyQF8Hfd9rNIYpUKQFezYI1mEhiqzzKXIolbj4ktb2DQyMf1jPn atvQ== X-Gm-Message-State: APjAAAVeDtc9rAL8TEFmKw3Dd62F34uW27gd+cdYr7VYVai3LJ+geRYk StwPjcHbYVjkNvEeH7YXWkd/G1PIM1E9eA2Gm/Q= X-Google-Smtp-Source: APXvYqyGba1JuOzwij8h81FFZBHd2OlEtCMNeu9jQhzL80zEvbMZYYPfSGRE2ddV0neFR+b0OrvIl4+/koQlBtgy7BQ= X-Received: by 2002:a5d:8143:: with SMTP id f3mr7159450ioo.294.1570082250720; Wed, 02 Oct 2019 22:57:30 -0700 (PDT) MIME-Version: 1.0 References: <20190906072548.12304-1-rmody@marvell.com> <20191002191456.28488-1-rmody@marvell.com> In-Reply-To: <20191002191456.28488-1-rmody@marvell.com> From: Jerin Jacob Date: Thu, 3 Oct 2019 11:27:19 +0530 Message-ID: To: Rasesh Mody Cc: dpdk-dev , Jerin Jacob , Ferruh Yigit , GR-Everest-DPDK-Dev@marvell.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 3, 2019 at 12:45 AM Rasesh Mody wrote: > > Hi, > > Currently, BNX2X PMD uses a very old firmware 7.2.51. > This patch series updated the base driver to use to latest > firmware 7.13.11. The latest firmware comprises of enhancements > and fixes. > > v3: > - Addressed gcc 9.2 build issues > v2: > - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11" > - Addressed most of checkpatch issues > > Thanks! > -Rasesh > > Rasesh Mody (3): > net/bnx2x: update and reorganize HW registers > net/bnx2x: update HSI code > net/bnx2x: update to latest FW 7.13.11 I don't think this patch comes as _base_ code, Please fix the trivial and genuine check path errors. [master][dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh ### net/bnx2x: update HSI code WARNING:TYPO_SPELLING: 'entires' may be misspelled - perhaps 'entries'? #863: FILE: drivers/net/bnx2x/ecore_hsi.h:2844: + /* 9 entires for the C2S PCP map for each inner VLAN PCP + 1 default */ total: 0 errors, 1 warnings, 0 checks, 5425 lines checked ### net/bnx2x: update to latest FW 7.13.11 CHECK:CAMELCASE: Avoid CamelCase: #174: FILE: drivers/net/bnx2x/ecore_fw_defs.h:18: + (IRO[151].base + ((assertListEntry) * IRO[151].m1)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ ^ CHECK:CAMELCASE: Avoid CamelCase: #178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23: + (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23: + (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \ ^ CHECK:CAMELCASE: Avoid CamelCase: #193: FILE: drivers/net/bnx2x/ecore_fw_defs.h:26: + (IRO[163].base + ((funcId) * IRO[163].m1)) CHECK:CAMELCASE: Avoid CamelCase: #199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30: + (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2)) CHECK:CAMELCASE: Avoid CamelCase: #199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30: + (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32: + (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32: + (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \ CHECK:CAMELCASE: Avoid CamelCase: [65/1889] #215: FILE: drivers/net/bnx2x/ecore_fw_defs.h:40: + (IRO[316].base + ((pfId) * IRO[316].m1) + ((iscsiEqId) * IRO[316].m2)) CHECK:CAMELCASE: Avoid CamelCase: #287: FILE: drivers/net/bnx2x/ecore_fw_defs.h:87: +#define CSTORM_VF_PF_CHANNEL_STATE_OFFSET(vfId) \ CHECK:CAMELCASE: Avoid CamelCase: #368: FILE: drivers/net/bnx2x/ecore_fw_defs.h:142: + (IRO[187].base + ((portId) * IRO[187].m1)) CHECK:CAMELCASE: Avoid CamelCase: #414: FILE: drivers/net/bnx2x/ecore_fw_defs.h:172: + (IRO[215].base + ((portId) * IRO[215].m1) + ((clientId) * \ CHECK:CAMELCASE: Avoid CamelCase: #420: FILE: drivers/net/bnx2x/ecore_fw_defs.h:175: + (IRO[216].base + ((qzoneId) * IRO[216].m1)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241: + (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241: + (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: +#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: +#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276: +#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1) [16/1889] CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: +#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276: +#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #577: FILE: drivers/net/bnx2x/ecore_fw_defs.h:378: +#define TSDM_TIMER_TICK_RESUL_CHIP (1 * (1e-6)) ^ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r_order == MAX_RD_ORD' #1119: FILE: drivers/net/bnx2x/ecore_init_ops.h:499: + if ((CHIP_IS_E1(sc) || CHIP_IS_E1H(sc)) && (r_order == MAX_RD_ORD)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #1537: FILE: drivers/net/bnx2x/ecore_sp.h:138: +#define ECORE_ILT_ZALLOC(x, y, size) \ do { \ x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \ if (x) { \ if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ size, (struct bnx2x_dma *)x, \ + "ILT", RTE_CACHE_LINE_SIZE) != 0) { \ rte_free(x); \ x = NULL; \ + *(y) = 0; \ } else { \ *y = ((struct bnx2x_dma *)x)->paddr; \ } \ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects? #1537: FILE: drivers/net/bnx2x/ecore_sp.h:138: +#define ECORE_ILT_ZALLOC(x, y, size) \ do { \ x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \ if (x) { \ if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ size, (struct bnx2x_dma *)x, \ + "ILT", RTE_CACHE_LINE_SIZE) != 0) { \ rte_free(x); \ x = NULL; \ + *(y) = 0; \ } else { \ *y = ((struct bnx2x_dma *)x)->paddr; \ } \ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects? #2191: FILE: drivers/net/bnx2x/ecore_sp.h:1967: +#define PF_MAC_CREDIT_E2(sc, func_num) \ + ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_MAC_CREDIT_CNT) / \ + (func_num) + GET_NUM_VFS_PER_PF(sc) * VF_MAC_CREDIT_CNT) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects? > > doc/guides/nics/bnx2x.rst | 4 +- > drivers/net/bnx2x/bnx2x.c | 63 +- > drivers/net/bnx2x/bnx2x.h | 95 +- > drivers/net/bnx2x/bnx2x_osal.h | 29 + > drivers/net/bnx2x/bnx2x_rxtx.c | 10 +- > drivers/net/bnx2x/ecore_fw_defs.h | 252 +- > drivers/net/bnx2x/ecore_hsi.h | 3508 ++++++++------- > drivers/net/bnx2x/ecore_init.h | 214 +- > drivers/net/bnx2x/ecore_init_ops.h | 192 +- > drivers/net/bnx2x/ecore_mfw_req.h | 11 +- > drivers/net/bnx2x/ecore_reg.h | 6617 +++++++++++++++++++--------- > drivers/net/bnx2x/ecore_sp.c | 48 +- > drivers/net/bnx2x/ecore_sp.h | 308 +- > 13 files changed, 7185 insertions(+), 4166 deletions(-) > create mode 100644 drivers/net/bnx2x/bnx2x_osal.h > > -- > 2.18.0 >