From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05DC6A0C5A; Sat, 14 Aug 2021 17:55:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 737F140696; Sat, 14 Aug 2021 17:55:39 +0200 (CEST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by mails.dpdk.org (Postfix) with ESMTP id 5EE634068F for ; Sat, 14 Aug 2021 17:55:38 +0200 (CEST) Received: by mail-lj1-f177.google.com with SMTP id a7so20329454ljq.11 for ; Sat, 14 Aug 2021 08:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sH3uIbX6t2pLscFeoEiwel+b/+0M51K7k0gbxLSyQNw=; b=RQnrjkC1fkiryi7gKUha3p+u6QN7/9rawQ+4eK6Ek3E6g5lV83HtdELFqc6iPyAP4R CI83O61n6ajGYl3YsoJVZfe9sl+F30zb+y1v2jHnuyDGRB/pRfH2J8/s6z80rOdEFdUY GQvKettK/w5dma9vXE56EDw7pU+Tt7w1kC7ZUCtSkO1XdR0mmLZygjwfzE7bjV0W7wX1 6ErG0faVDrI5NgbZwt0e5yNmRBVN3DkqvO1s0RfPDy/6tYoR9adt+xMhH+79QHqt0wtH JcPD0YoOk4BiiBnJ4cTO9Jj/s5/4C3pLdfWELFQ8T1iK/gf9SKYbkXPh4v70bVshYBQX UgIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sH3uIbX6t2pLscFeoEiwel+b/+0M51K7k0gbxLSyQNw=; b=jy5ksgRUI9ItMWOfk3jgsoHGZ0Z+iW3pq1wxsDMNKDv8/O5prF/BhkMMD3L7qRQXQ/ L+Apsb8LGWTUi0Apr/n31vloASHKx+ymKzCDH2eit+fELq7zeC6FS+OZAc44MjL5uwjE UbjPKU2e7kcGc1E1MvQMp/t64ociBksdOhjCztMlFnKbbHMy3ytk0S/MUJTox8oLs8pV BR0vtOM2upIpysz9iXfIIZA1ag1HzkGf7j4IW3OLpArtlHy4ddwM83jsEdVYXDGJHOTR jUHWzJ9vbKkCKfgVF+Om5akAPY6XA2TzlSzaCHTBpItC6ixcNOQ8vWk88U2/OLrXfozv AYjg== X-Gm-Message-State: AOAM533y6HZ/z447uWnEHxcauTTxjAyUlZTzsHipH0w+HJZTuu64COVP tdpjaoIs/pTWXorhoHEFErJTLudSDd5B+5y3YXc= X-Google-Smtp-Source: ABdhPJx4R2N6HR/eq1UjPjAi0dRcXq1CFl1WUyjHb+8Aok3pWiQN0VPCi0XTlrrg0eG4Lg7ENCXkQFiwnZ2d8IkMDi8= X-Received: by 2002:a2e:2f0c:: with SMTP id v12mr5772729ljv.381.1628956537775; Sat, 14 Aug 2021 08:55:37 -0700 (PDT) MIME-Version: 1.0 References: <20200227071126.75162e92@Sovereign> <20200228060727.192491-1-dmitry.kozliuk@gmail.com> <20200228060727.192491-6-dmitry.kozliuk@gmail.com> In-Reply-To: <20200228060727.192491-6-dmitry.kozliuk@gmail.com> From: William Tu Date: Sat, 14 Aug 2021 08:55:01 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC PATCH 5/5] mk/windows: add virtio-net PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, I'm looking at this patch and have some questions. On Thu, Feb 27, 2020 at 10:08 PM Dmitry Kozlyuk wrote: > > Signed-off-by: Dmitry Kozlyuk > --- > drivers/net/virtio/virtio_ethdev.c | 4 + > kernel/windows/netuio/netuio.inf | 6 + > lib/librte_eal/windows/eal/eal.c | 4 + Why do we need these change below? I thought to add a new Windows driver support, we only need to compile the drivers/net/xxx, and add the device ID to netuio.inf, at the dpdk-kmod repo? > mk/exec-env/windows/dpdk.sln | 754 +++++++++--------- > mk/exec-env/windows/l2fwd/l2fwd.vcxproj | 242 +++--- > mk/exec-env/windows/l3fwd/l3fwd.vcxproj | 292 +++---- > .../librte_pmd_i40e.vcxproj.filters | 198 +++++ > .../librte_pmd_net_virtio.vcxproj | 129 +++ > 8 files changed, 989 insertions(+), 640 deletions(-) > create mode 100644 mk/exec-env/windows/librte_pmd_net_virtio/librte_pmd_i40e.vcxproj.filters > create mode 100644 mk/exec-env/windows/librte_pmd_net_virtio/librte_pmd_net_virtio.vcxproj Thanks William