From: William Tu <u9012063@gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>, Pallavi Kadam <pallavi.kadam@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows
Date: Wed, 15 Sep 2021 13:22:53 -0700 [thread overview]
Message-ID: <CALDO+SZd27P--duJffTKCE=+huYd0aRLH=c8Vz-FO14-05bD4Q@mail.gmail.com> (raw)
In-Reply-To: <20210915220517.656c8167@sovereign>
On Wed, Sep 15, 2021 at 12:05 PM Dmitry Kozlyuk
<dmitry.kozliuk@gmail.com> wrote:
>
> 2021-09-15 18:44 (UTC+0000), William Tu:
> > This patch enables building the ixgbe driver for Windows.
> > It also enables its dependencies on security and cryptodev.
>
> Tal Shnaiderman posted patches for cryptodev and security today,
> so I won't comment on that part. IMO your patch should depend on them
> (https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies).
>
> [...]
> > diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h
> > index cacf724198..fe28029ef7 100644
> > --- a/drivers/net/ixgbe/base/ixgbe_osdep.h
> > +++ b/drivers/net/ixgbe/base/ixgbe_osdep.h
> > @@ -17,6 +17,12 @@
> > #include <rte_byteorder.h>
> > #include <rte_io.h>
> >
> > +#ifndef RTE_EXEC_ENV_WINDOWS
> > +#include <netinet/in.h>
> > +#else
> > +#include <Ws2tcpip.h>
> > +#endif
> > +
>
> #include <rte_ip.h> instead.
Hi Dmitry,
Thanks for your feedback.
I will send v2.
William
next prev parent reply other threads:[~2021-09-15 20:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 18:44 William Tu
2021-09-15 19:05 ` Dmitry Kozlyuk
2021-09-15 20:22 ` William Tu [this message]
2021-09-18 14:24 ` William Tu
2021-09-18 14:55 ` Dmitry Kozlyuk
2021-09-18 15:10 ` William Tu
2021-09-22 20:58 ` [dpdk-dev] [PATCH v2] " William Tu
2021-09-22 21:01 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDO+SZd27P--duJffTKCE=+huYd0aRLH=c8Vz-FO14-05bD4Q@mail.gmail.com' \
--to=u9012063@gmail.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).