From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 22071A00E6 for ; Thu, 16 May 2019 18:29:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AAA1326C; Thu, 16 May 2019 18:29:20 +0200 (CEST) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by dpdk.org (Postfix) with ESMTP id 037761D7 for ; Thu, 16 May 2019 18:29:17 +0200 (CEST) Received: by mail-qt1-f194.google.com with SMTP id h1so4674937qtp.1 for ; Thu, 16 May 2019 09:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n4Z/pZOhnGR+Hu8pou49C5gwjhdZhV1DcTf9EnyJLyg=; b=BMd3rxM81Hg+sqihsz9cCmGUFbVqkYe3+4wwHHZddjdkcOsRFYDf01IfNNy7MDsyMo nMyFp6tNHt9KyTaS4gY+yMO4396LvNm0tP7um9I8QvQYRSlrVLWqEWVk2TbG90atxvhb hmQ3EHGzqQoZsOpco5rAUKBcGaJSTruRqPLkvLNt7Qq0GySaipzjmEVrrQXyY6+4RUZr rICp4k8Txgrc9sLxvaS7oC7sUkHLdwsEjd5Y1BVy2vfjzbdlzpSuoKs6gxKvVCbJb0az eF/AeSEfNAwH+yECy9metqwy/5LFguVqwNa9p7IP1PxgQNryAND3JMQ6wksUDG7h7j6R UIcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n4Z/pZOhnGR+Hu8pou49C5gwjhdZhV1DcTf9EnyJLyg=; b=lwJxEHGRrZcgo7Ydzvli8t3B+RsO5fScACcnMI3PZYn3AYeaVWRryv+F/QLn1IlMrJ ejjGBBjEzj/PZSRJoPpVuY8H8Y+A+Mff4KfDDN2EXMQIVhTgFvgQBKoQrKNpmAB8+w/I mpvLVoEeB9F2EZtePYUVVZ2NDCH7TnRcIkZZi2uRpu1xfvts7UvLb69rZC7TU47ILn1W h3uNljfjDGAeB/gq2POV3BtIRpfPePCEdC4PxLACJAGDZHvyIbogNqz+R5ogW8yZRR1I qVDMwRlgHnpMsK9OaS4WHXX5kpt2sNwUN+kJpOpWLwKDsntDb5gzIRhYfiVpxu+I70+A KxdQ== X-Gm-Message-State: APjAAAUenMJh8xvbC2EXeAcBZ2qDJnNx+fFNvToYqaZtXlUvxnyHHdSc odzHm2trXNZyFVVoRlq1weDYlffOAgy1Yii1iA0= X-Google-Smtp-Source: APXvYqwEBkzSoUrBzAKLOHhCYO7KX0+K4+M4ihNtjouEao/GWt1vIPiKe4iK0Dh0UtgUHZY+xMO7ivT6v2GkuVtpFzk= X-Received: by 2002:ac8:243:: with SMTP id o3mr14285124qtg.104.1558024157339; Thu, 16 May 2019 09:29:17 -0700 (PDT) MIME-Version: 1.0 References: <1557951879-123265-1-git-send-email-u9012063@gmail.com> <16a81a92627551d03e6c7620787468f0e77462fc.camel@debian.org> In-Reply-To: <16a81a92627551d03e6c7620787468f0e77462fc.camel@debian.org> From: William Tu Date: Thu, 16 May 2019 09:28:41 -0700 Message-ID: To: Luca Boccassi Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: add libelf for pmd_af_xdp. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 16, 2019 at 1:59 AM Luca Boccassi wrote: > > On Wed, 2019-05-15 at 13:24 -0700, William Tu wrote: > > The libbpf requires linking elf library. Fix it by > > adding -lelf. > > > > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > > Signed-off-by: William Tu < > > u9012063@gmail.com > > > > > --- > > mk/rte.app.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > > index 7c9b4b538e52..e5d15218618a 100644 > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -145,7 +145,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += > > -lrte_mempool_dpaa2 > > endif > > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet > > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += -lrte_pmd_af_xdp > > -lbpf > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += -lrte_pmd_af_xdp > > -lbpf -lelf > > _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD) += -lrte_pmd_ark > > _LDLIBS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += -lrte_pmd_atlantic > > _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += -lrte_pmd_avp > > Hi, > > This was already discussed, and libbpf needs to link with libelf itself > as it's an internal dependency. It was already fixed in the kernel tree > some time ago, so it should be correct with a recent version. If you > are using an old version you can either update or fix it in your > application. So I don't think we should carry this work-around > ourselves in DPDK, as we'll end up overlinking when using fixed libbpf > versions. OK. Thank you!