From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C0276A0C43;
	Fri,  8 Oct 2021 23:42:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3B84140DF7;
	Fri,  8 Oct 2021 23:42:27 +0200 (CEST)
Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com
 [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 8F68E40DF6
 for <dev@dpdk.org>; Fri,  8 Oct 2021 23:42:25 +0200 (CEST)
Received: by mail-lf1-f51.google.com with SMTP id n8so42019393lfk.6
 for <dev@dpdk.org>; Fri, 08 Oct 2021 14:42:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=6z2VoZIO55u38DyOSlWCRPYpJdub8kuCJ4SciRtNU2o=;
 b=UPC9Dg3jDvFBFeQAlXBuoSTwlWKzxuyN9SDk+9y5YtlLsbJdcvP0rd2+BTeVDHiO3W
 lvR8ltQ0HmJ764NlgQTCox/Xc0FT9sOnG7Qitg11ZQBhBIgqlRlVNWYdLCZB8OgWYMu4
 u/uwPUu5zRt4ZNXnUcIP0jrupQSNNFzhTJP9oQGYU+Pc+f/dkGTIuXGBIIglA3Nnjrft
 Rjhb7Qhi/W3OxTbFK+RtMoaaSUtjYIcDeInhMVLBq3EBCLi22lSQngBx5g0iaeJ+bAyq
 L2uPuk5H/w5DyRnBFRQzPfigt38etTKU54V8ZJnZLVM7uhK9VW0BUx2RYxwu8L7Fiime
 K9eA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=6z2VoZIO55u38DyOSlWCRPYpJdub8kuCJ4SciRtNU2o=;
 b=O7vTPXTw3YF5SmWboJE8zJk2rMJJTaEIHp/xBU/hWjncOWR3/vr+Hc9rBk1g0O6Csh
 HGukMjgNSWP/+sL3uuy4SS+hYrgbrGx3FI1AOYuM1cJSPx/eEs+eo7D4j0S8s93ypc6a
 bsOIcGhegfN52r/NRXBf/ZhGGpOsv9YnZbNAMyDXSTSZF5TrII0xG39CI7ThEGWUB9pI
 7+Du/iy823omYoYj1OBvkyb+KvsO5yz+MlP5Xwa9dSEzF4mSBM56HLUHCwjyi/0P8HTn
 mycUmyUTaYs8B7pljkL+jaj82i8mNXzFzyTLLvGqyX1sHhiaGFdxSgh5Qy2C50zNOHui
 fvHw==
X-Gm-Message-State: AOAM533qC0eawH6yzeg9Yq0y9QpPCnQ+mwqD5hgae8i7IvioZogw9eRg
 yhHA1xPLt5axhAPZSdsq5IuuWdfyO+82U+aRoJA=
X-Google-Smtp-Source: ABdhPJxGpm/dfcux+2214hisyk5IvqhNMER+ymOMkeD6Ia7ynbExHe0ULDDWzA68xPm+oq4gxiwyeR6gysAhs0JdNWk=
X-Received: by 2002:a05:651c:3c3:: with SMTP id
 f3mr6200226ljp.222.1633729344948; 
 Fri, 08 Oct 2021 14:42:24 -0700 (PDT)
MIME-Version: 1.0
References: <20211007202451.90271-1-u9012063@gmail.com>
 <20211008135346.875-1-u9012063@gmail.com>
 <20211008233535.5e872404@sovereign>
In-Reply-To: <20211008233535.5e872404@sovereign>
From: William Tu <u9012063@gmail.com>
Date: Fri, 8 Oct 2021 14:41:48 -0700
Message-ID: <CALDO+Sa4ZPaHKjYLS69X_i5_8zML+oBNWrdNAuPqEC-zAr8XfQ@mail.gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>, Pallavi Kadam <pallavi.kadam@intel.com>, 
 David Marchand <david.marchand@redhat.com>, Haiyue Wang <haiyue.wang@intel.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Oct 8, 2021 at 1:35 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> 2021-10-08 06:53 (UTC-0700), William Tu:
> > This patch enables building the e1000 driver for Windows.
> > I tested using two Windows VM on top of VMware Fusion,
> > creating two e1000 devices with device ID 0x10D3,
> > verifying rx/tx works correctly using dpdk-testpmd.exe
> > rxonly and txonly mode.
> >
> > Signed-off-by: William Tu <u9012063@gmail.com>
> > Cc: Haiyue Wang <haiyue.wang@intel.com>
>
> Will there be an accompanying kmods patch to add the device ID to .inf?
>
> With device ID added to netuio, in QEMU with -device e1000e,
> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> > diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst
> > index 041c9a09a3a5..03ae23838bfa 100644
> > --- a/doc/guides/nics/e1000em.rst
> > +++ b/doc/guides/nics/e1000em.rst
> > @@ -1,6 +1,8 @@
> >  ..  SPDX-License-Identifier: BSD-3-Clause
> >      Copyright(c) 2010-2014 Intel Corporation.
> >
> > +.. include:: <isonum.txt>
> > +
> >  Driver for VM Emulated Devices
> >  ==============================
> >
> > @@ -153,3 +155,14 @@ The following are known limitations:
> >  #.  Qemu e1000 only supports one interrupt source, so link and Rx interrupt should be exclusive.
> >
> >  #.  Qemu e1000 does not support interrupt auto-clear, application should disable interrupt immediately when woken up.
> > +
> > +Windows Configuration
> > +---------------------
> > +
> > +- Follow the :doc:`guide for Windows <../windows_gsg/run_apps>`
> > +  to setup the basic DPDK environment.
> > +
> > +- Identify the Intel\ |reg| Ethernet adapter.
> > +
> > +- To load NetUIO driver, follow the steps mentioned in `dpdk-kmods repository
> > +  <https://git.dpdk.org/dpdk-kmods/tree/windows/netuio/README.rst>`_.
>
> There is nothing special about setting up this device on Windows.
> I think we don't need this part.

Thank you. I will add the Device ID to netuio.inf file
and remove the above part.
Will wait for Pallavi's test and resend the patch.

Thanks
William