From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5383A0548; Tue, 24 Aug 2021 18:11:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20694406A3; Tue, 24 Aug 2021 18:11:58 +0200 (CEST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id E0D5640687 for ; Tue, 24 Aug 2021 18:11:56 +0200 (CEST) Received: by mail-lf1-f44.google.com with SMTP id r9so46693684lfn.3 for ; Tue, 24 Aug 2021 09:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oi8FViFbtXz7g+ZYPlnqxCpDeHqt0P4MajAei0E26jw=; b=RPTLup+eQiKCye+6KangyuU/BtEhsQoJ9pZLq8tX2H7ck/xyA+ZDKhAXq3W9M9trQ8 UTYLWQNdwxEYLweVl6/FRsiJ2SVgKej2OYRFS8GMLsz+s+cZLj/03YBE1SXvUrJHZlSO 8dI9PHh1sFJEUYqgkkApa7pQbf5vknvAs5uiwGwHrVZWDYHR/UxnaVHYakqOgNrpcWmV mjLudMiSm1Oa3Rwn/Nokr3Zyk39YONP48O1FvNc7jwHcq1ZKXyITAMf4ZrZnCGwyxDPY JKFhmM+b93B0a6zo2iREqE1sz6nQAYCEN4AzLOGZQhV/YqTZ2vQ0FW3ovbQoRBX/mX4t Is/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oi8FViFbtXz7g+ZYPlnqxCpDeHqt0P4MajAei0E26jw=; b=KryCIoz8bsbWbemN8Uw13uyOndadQ6yXW3a7JMozDDBd6d8RL74oGpZ+xFk/n/w6/t hFyoG4TwOCRRmKYVjjZA2/zKMHxfBkAOHEGRQxM2997cPbUx1Be/XXEkbdGP6vECKPa6 TPLRvDzWyc6o/vIHg68mWxcWxa6hJVDuI+FQtrrhJFAcfdVQjtt3luMvWd2kE3fZQ+uK PNQ1RXGBdLGBUmTKddb/gpgwCPTx5er/8dNZr0k/znT8Ie+FNIuEuvQ/SwRvHYsGpEbo LsCh2vg1gXtrAiuzCKHfdxLtyWqxz+69IQGTDgtV9llawcFjxIuN9zJVBNXK/M/ZvYUK rH+A== X-Gm-Message-State: AOAM531/qe1CoymbcfIyGj2DEYBB112MTYhkv0PRt62UelDF/cch6vkE CL/+Xakc573l8A5/YHmhGCc403HWm5id8dMXK70= X-Google-Smtp-Source: ABdhPJwdDnNG4K7UJdzEZeYhqamv8bveig5waoL6uEEb2BOIZqZZ3GF7uS6TwKxH7sQ7N4xgsJ6DQsjBlL839ANXVI4= X-Received: by 2002:a05:6512:2248:: with SMTP id i8mr29831335lfu.258.1629821516281; Tue, 24 Aug 2021 09:11:56 -0700 (PDT) MIME-Version: 1.0 References: <20210818232632.7068-1-u9012063@gmail.com> <20210823130343.87247-1-u9012063@gmail.com> <20210823221403.10312c5b@sovereign> In-Reply-To: <20210823221403.10312c5b@sovereign> From: William Tu Date: Tue, 24 Aug 2021 09:11:19 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Nick Connolly Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8] eal: remove sys/queue.h from public headers. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 23, 2021 at 12:14 PM Dmitry Kozlyuk wrote: > > 2021-08-23 13:03 (UTC+0000), William Tu: > [...] > > /* This macro permits both remove and free var within the loop safely.*/ > > -#ifndef TAILQ_FOREACH_SAFE > > -#define TAILQ_FOREACH_SAFE(var, head, field, tvar) \ > > - for ((var) = TAILQ_FIRST((head)); \ > > - (var) && ((tvar) = TAILQ_NEXT((var), field), 1); \ > > +#ifndef RTE_TAILQ_FOREACH_SAFE > > +#define RTE_TAILQ_FOREACH_SAFE(var, head, field, tvar) \ > > + for ((var) = RTE_TAILQ_FIRST((head)); \ > > + (var) && ((tvar) = RTE_TAILQ_NEXT((var), field), 1); \ > > (var) = (tvar)) > > #endif > > 1. Unlike TAILQ_FOREACH_SAFE, new RTE_ macro doesn't need #ifdef. > > 2. There should be no period at the end of the subject > (./devtools/check-git-log.sh would show that). > > Except for these nits, > Acked-by: Dmitry Kozlyuk Thanks for your review. I will fix it and send another version. William