From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BB41DA054F;
Tue, 18 Feb 2020 22:17:13 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 0CEA81BFFA;
Tue, 18 Feb 2020 22:17:13 +0100 (CET)
Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com
[209.85.222.195]) by dpdk.org (Postfix) with ESMTP id 60D731BFA5
for <dev@dpdk.org>; Tue, 18 Feb 2020 22:17:11 +0100 (CET)
Received: by mail-qk1-f195.google.com with SMTP id c20so21038037qkm.1
for <dev@dpdk.org>; Tue, 18 Feb 2020 13:17:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=ZOAKIxv3JRUvZ2okO9a77LfuydJomHnK9QqE5Ov1DlI=;
b=APMJJFyVQ0qO5TEV7KWGSXlYjr4h/s4ElUVeidEA+lZ33lf1ZAtlNP/7HLgC+8aA8k
pyzKXrMDt3AhfEar/VFvH9kZdISZzZe8jgdqfKX+TBxglf5v+LMe6byndI9bdAJFJbZD
KP/yw/RWLGtVtYIKgtw+yHHi4fIIhrc6CviPPyq0hPxHfnBk3bOS7+Ps/nZTtQp5dITZ
FFGqtqFs9zCa4gmqci4bAk1pR4ZHwQtJWIMJrVVwn4V+otNtOZy41zirA0vpcHQAyMog
Ka711/3vw/U45pRoIOM9NI+21hxH/XqDh6gPbwImCk7d6D0xDojwWEIU7gcjc/SS5DtQ
utMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=ZOAKIxv3JRUvZ2okO9a77LfuydJomHnK9QqE5Ov1DlI=;
b=tid33M3DlqqbG5vuGPf58Gt/Lt+npEQOVOHKFXMuNwSN1jBNBd7zoYAoKJ0sokYNTt
qI1HTmIo77xhp8Z2wii/967CIqT7nhe3atw9g0nJYQTqRx7Jg4iLJ5bSZOpyzms8Urvc
8HTFE4S4dvJARhQ3lyb0zzILnzzq60Yc4OSc9LexYJIJI84PCnmOGfNSFw+VemuR9NZP
fiW3yHcrOPSEmBol8DuiN7pc/drJrw1NzBxBn/7gppxz2ExiFIic3Kyf/miESUavZ+ps
ETIZ21xvw2pTe2E5HDYMtN6O+oRneJ+AqwgROyQj/04wE6B2KSaKOFMWmfu7OslVRVwh
sbrg==
X-Gm-Message-State: APjAAAU/+0oVsVE93GodhmRIW1X1lJ/+Bb32IrhTB9lte9BzVnikF3+6
uhZ3HFSfeCq6KVEctUIbK3tCG5b0XVBHXlrqGvY=
X-Google-Smtp-Source: APXvYqysJlf6hM1flwrez8ESMnRUa0dSpdn6G9iCofWPFLPJwSke8FtEFCqd7OQ2q3pqUAgFCMeQ73sGIRKzAwTcaGA=
X-Received: by 2002:a37:b602:: with SMTP id g2mr20888514qkf.174.1582060630646;
Tue, 18 Feb 2020 13:17:10 -0800 (PST)
MIME-Version: 1.0
References: <20200218000229.86621-1-dmitry.kozliuk@gmail.com>
In-Reply-To: <20200218000229.86621-1-dmitry.kozliuk@gmail.com>
From: William Tu <u9012063@gmail.com>
Date: Tue, 18 Feb 2020 13:16:34 -0800
Message-ID: <CALDO+SawUwR9Rq34Q3UfYSB0g5ZnUUn_097tW-pUR2fKA+VWSA@mail.gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>, Olivier Matz <olivier.matz@6wind.com>,
Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
Omar Cardona <ocardona@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>, Ranjit Menon <ranjit.menon@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 0/7] MinGW-w64 support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Mon, Feb 17, 2020 at 4:02 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> This patch series add support for building DPDK using MinGW-w64.
>
> MinGW-w64 provides GNU toolchain and independent platform SDK on
> Windows. It also supports cross-compilation to Windows from POSIX
> systems by providing cross tollchains and libraries [0]. It does NOT
> emulate a full POSIX environment, like Cygwin or MSYS do.
>
> There are advantages in using MinGW-w64 in addition to Clang:
>
> 1. Cross-compilation out-of-the-box. MinGW-w64 is provides a pthread
> implementation, GNU getopt, and Windows platform SDK.
>
> 2. Easier porting of POSIX applications using DPDK to Windows, because
> application code can use the same benefits as mentioned above.
>
> 3. Having both primary compilers enabled on Windows provides more
> diagnostics and generally prevents non-portable code.
>
> [0]: http://mingw-w64.org
>
> v3 Changes:
>
> Rebase onto the latest Windows EAL.
> Prevent format attribute conflict with upcoming v20.05 patches.
> Remove redundant CFLAGS from Meson.
> Remove links to Meson bugtracker from docs (PR merged into upstream).
> Fix Clang warnings using about GNU options.
>
> v2 Changes:
>
> Add patch to use lowercase system header filenames.
> Move Meson cross-file for x86 to arch directory.
> Change wording in comments.
> Add Meson version warning in documentation.
>
> ---
I have to apply below diff to make it work:
diff --git a/lib/librte_eal/windows/eal/include/pthread.h
b/lib/librte_eal/windows/eal/include/pthread.h
index 4ac24de0aa27..b9dd18e56815 100644
--- a/lib/librte_eal/windows/eal/include/pthread.h
+++ b/lib/librte_eal/windows/eal/include/pthread.h
@@ -14,7 +14,7 @@
extern "C" {
#endif
-#include <Windows.h>
+#include <windows.h>
#define PTHREAD_BARRIER_SERIAL_THREAD TRUE
Otherwise, the series look good to me.
Acked-by: William Tu <u9012063@gmail.com>
Thanks
William