From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 688D7A0C4D; Fri, 20 Aug 2021 18:09:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F48B4013F; Fri, 20 Aug 2021 18:09:15 +0200 (CEST) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mails.dpdk.org (Postfix) with ESMTP id 9908D4003E; Fri, 20 Aug 2021 18:09:13 +0200 (CEST) Received: by mail-lj1-f180.google.com with SMTP id i28so18081592ljm.7; Fri, 20 Aug 2021 09:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dSuE+RRiYHogy4fyyXfo9rT5N5z5RNYlGq4p00pUiAk=; b=e8dTO+eqZ7k+VZuUw6gmAUriTljHf0ZLyXXmMgaiXYYxiZxX5KphzuOFnbilB2fcFZ 3WtCvkjyIImSeKTR0CVkwCj4pxFlWnufj0bbJBEwwJ6j/6fUYTen5p9igcbv7C81ufDD sWOPQ/WKUrSQQCchE1ms2mosrI0fnpTzHXqdMR0weP/YcyosMK7oYbI/Ea1GNJRfCO1H LA9DsEk9WrzNQZrhriS0WrCyxAlgDpp9GSpHrrZwOlNrsz95Phr2r9M1obsHJH5M4o+6 ol0UqNoehBt/gnD2HVWF/tWij51cefJMyBdTFuTx8T+2waCtizNQJwlUOoaHOcPlzhcO G8xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dSuE+RRiYHogy4fyyXfo9rT5N5z5RNYlGq4p00pUiAk=; b=n1fpZcdSzzwWYFVxTJcuJUBdWI4htU53IyUwCFm3VjMwlRrhlSFn8Nm+lkgDl+cbeM lIcUDj+lk4vdus0rY1em+dz/cDqLat4B5cCYTt51qEkBtUENp1mdrLY9W5JOnRiGWgXn hKbwooYCDzMvEnjLrMdWm3reRTxBOG4V7kJEEMv9GTA/Y3MGZUAAbo7PBQZEdC2nn6Ir KHzHPQGmU/pVLve19EicVNzQ7XI2PEtpeycOKt52kyKhLyGl8h3tdv1QxxJK2ljezT9D mY5szo/W+xnhLBKtEAZ46iCcjrRhRvthBjCqAj4jPF+MO2oG95fQm9hXOImaGVhtcEiA ryEA== X-Gm-Message-State: AOAM532w9Ssb4wI83xA9C6UgUZh9tCGkkoG+8vtXMlLFQuXtkLkJZ7sk E+gmmLEB0OHw9I37lmvVklVXZteXoMsnOGgX98A= X-Google-Smtp-Source: ABdhPJyqCT6+PmRWWEfvhJ3aRUa5335eMMWS0uMiCtOVcaVjYRKY7zf1tgKRrnsnFjZ+p1Ep4fWLZN42i6hWcF0RHIY= X-Received: by 2002:a2e:b042:: with SMTP id d2mr11021024ljl.279.1629475753070; Fri, 20 Aug 2021 09:09:13 -0700 (PDT) MIME-Version: 1.0 References: <20210819231446.810897-1-dmitry.kozliuk@gmail.com> In-Reply-To: <20210819231446.810897-1-dmitry.kozliuk@gmail.com> From: William Tu Date: Fri, 20 Aug 2021 09:08:36 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Tal Shnaiderman , stable@dpdk.org, Bruce Richardson , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Tal Shnaiderman Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] build: propagate Windows system dependencies to pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 19, 2021 at 4:15 PM Dmitry Kozlyuk wrote: > > Windows EAL depends on some system libraries. They were linked using > add_project_link_arguments('-l'), which prevented meson from adding > them to Libs.private of pkg-config file. As a result, applications using > pkg-config to find DPDK hit link errors, for example: > > librte_eal.a(eal_windows_eal_debug.c.obj) : error LNK2019: unresolved > external symbol __imp_SymInitialize referenced in function > rte_dump_stack > > Reference required libraries in EAL using ext_deps meson variable. > bus/pci and net/pcap depend on lib/eal and will pull them automatically. > Drop advapi32 dependency, as MinGW locates VirtualAlloc2() dynamically. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > Fixes: c91717eb75c8 ("eal/windows: support exit and panic") > Cc: talshn@nvidia.com > Cc: stable@dpdk.org > > Reported-by: William Tu > Signed-off-by: Dmitry Kozlyuk > --- Thanks for the fix. I've tested on my Windows environment and it works ok. the libdpdk.pc shows the required libraries. Acked-by: William Tu