From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCC71A0C45; Sat, 18 Sep 2021 16:25:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71C9A40041; Sat, 18 Sep 2021 16:25:19 +0200 (CEST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id C2C3E4003D for ; Sat, 18 Sep 2021 16:25:17 +0200 (CEST) Received: by mail-lf1-f52.google.com with SMTP id y28so44670775lfb.0 for ; Sat, 18 Sep 2021 07:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pAYlxID3pBA6Qkkp905WvrLN4dqBDbHn5NPklP3pCBo=; b=Z+MYaZFpKlMPn92ubv83sWjyThejZtLDl+Cw2ifMAkYOUAqz5gO61MOY5Cw2ZuDkTJ Tbo9FHUv0ca6Fu7HRFaFgb3DcwVlasc8sEyR/M/DWXsY3s2JIzyiL7esr/flyY9EQEgN n9xoW8WZCcyR0qQdGjCshWP/WMga0cXwxMTZogJ3Wv3YCzvvygs9j3BGavieH3uqGiyL 9TVR7p3JTw+28bhdIR4Wv8nUxJ9Z9DTHJe0DYXTZgh1Jam228Rha66jim/Er9rdWLJUW ED9/9qVnP7sB9jNydejET7gIC7nEkJ9lxJsgMcIiughcna3+t+juDpukt5kDpuSbunDQ KZag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pAYlxID3pBA6Qkkp905WvrLN4dqBDbHn5NPklP3pCBo=; b=ai6NN787+IspaZ4a2zZtE0b+ZXUxgG1ReuyZ3dQfCLMIBxV2/GvgUrdWnlpD53/xaM 7eoBqz5Dl815BJPq+b8oSktEKE9VrUFj2sY6nW2tB65hQ+0nPhzx5uyv6WSfRNhvi27T a0FKW03EXkGJ7Ey2tWIMNiOZ+mqQrlqxtD1VY5QQhg6JxpGigwrtpudRg72M42jr+X+Z kU9vsBvLiOJ6Cda/nd7Y4OP41pHPRB47N4816ySSluwfVE3LWx3EEi6zTu+Ei/THkbyd B6cYtlBpq2YRx7zMRRb6R+OxFyc/NQXK3ERZkvyZTbRB1IWYS3vtMtlKUy2FIIb/CJiN vRrA== X-Gm-Message-State: AOAM5339ObGLoysBCsUc8lJGf8zHBxsuQu8B/nO72L8UuYAt/pBS53cI HotWHfQJMz1gNcjmH0rByrxlQgDYVzFGPQkOoCY= X-Google-Smtp-Source: ABdhPJy9nsOAYzBHmcmzKdAlax90Nb7lhkcfISiRo8hUV6UlbGeLzBGbqGaUT5yWMkKJrj26ZP/UwC6LMMrOy4bXvlE= X-Received: by 2002:a05:651c:510:: with SMTP id o16mr14309108ljp.257.1631975117295; Sat, 18 Sep 2021 07:25:17 -0700 (PDT) MIME-Version: 1.0 References: <20210915184448.92751-1-u9012063@gmail.com> <20210915220517.656c8167@sovereign> In-Reply-To: <20210915220517.656c8167@sovereign> From: William Tu Date: Sat, 18 Sep 2021 07:24:40 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Pallavi Kadam , Ranjit Menon , Tal Shnaiderman Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 15, 2021 at 12:05 PM Dmitry Kozlyuk wrote: > > 2021-09-15 18:44 (UTC+0000), William Tu: > > This patch enables building the ixgbe driver for Windows. > > It also enables its dependencies on security and cryptodev. > > Tal Shnaiderman posted patches for cryptodev and security today, > so I won't comment on that part. IMO your patch should depend on them > (https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies). > Hi Dmitry, I checked Tal's patch and actually there is no dependency. Tal's patch is at driver/crypto, https://inbox.dpdk.org/dev/20210914053833.7760-8-talshn@nvidia.com/T/ and this patch is enabling lib/cryptodev and lib/security I will send v2 by breaking the ixgbe part and lib/security and cryptodev part. Thanks, William