From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36185A00BE; Tue, 7 Jul 2020 17:24:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 198DE1DE74; Tue, 7 Jul 2020 17:24:10 +0200 (CEST) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id DF2B81DE0F for ; Tue, 7 Jul 2020 17:24:07 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id h17so35180940oie.3 for ; Tue, 07 Jul 2020 08:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=radio-canada-ca.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hPZvCh6AKCHdDRmtnfh6hC9mZhTeJP4eKNuSIo21wTo=; b=olxwU6JqygqMgfvWPPduEkwdKPaFvZNNhk+3VpivYIWSgj8mmX2R7NO/R0pi3z2eqc LhhzE/rGPCfcQuxv7PKajlUtED53PYiyA5ZPhT3TtK9m+uxPSIvDhTDqmgSZ8RRLnrFY luzhPOAFt28QhmmggL28K0MuJIaBeNHOIXJUEWLGqxAqtc2hXViw481dKidnCB4DRp7i L/NZdxKxRcqoNtkHBhq7MOQNZ/MImOgcwaBBIfZrqhdyNIY2leR4dhoa8DIwHIs3XSV5 OgmQnfV4neDFkTfkFbxR8u2fkN3wD4u2mxR/vYE55NHI5xntIKAoFjR/Icu65/2zV4pu 2wCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hPZvCh6AKCHdDRmtnfh6hC9mZhTeJP4eKNuSIo21wTo=; b=twJrlIki8+vZPHr27UwWrmLl/C67REfy8UZ8Uxs/MmGbrj8AESQMd7QY6r5DKNOTLj ePh/e8K0Ta65TA5+qny7a6dHWGTXeMB6rBGJGmgFJsm1PexaqBJQCnGroWg4hdOLngHa iVrjDI4RiDw5/GCQ9Q+D1V28Tiig1iff2z1LkjahV24Cu3Fhxhrg3MMwro7xVGircKAG CuK9XAgMupgVi0HRdtJYH84gFztkGEAPIN4Zog4eRuD9b9fW4M548NbcDIAMGl9jcD2j daal8W8xH7WLBBycfgiDLoUPm3TQvxWgYzRn3yuNG5cc9oKBfKdDrjjWThHNoAK3d7ue a+HQ== X-Gm-Message-State: AOAM533tGoxo330BeBkply+mS8jGw3aXJsRSDbS4cc9KT8q4AAdfT6VB s9SkCIhxXMwo4L/soD3ZwCOkmXr+R+S2AZiJcbzxaw== X-Google-Smtp-Source: ABdhPJxC+4IyVdHHszXUUEdys6dq5oJ60QGewCdMekpw5hf1+flodwhruQ5qitmlrZJ/XyWjRadf+zmMx9QXELQNq7c= X-Received: by 2002:aca:ed92:: with SMTP id l140mr3794430oih.25.1594135447118; Tue, 07 Jul 2020 08:24:07 -0700 (PDT) MIME-Version: 1.0 References: <20200625190119.265739-1-vivien.didelot@gmail.com> <20200625190119.265739-2-vivien.didelot@gmail.com> <20200626064151.GV12564@platinum> In-Reply-To: <20200626064151.GV12564@platinum> From: PATRICK KEROULAS Date: Tue, 7 Jul 2020 11:23:55 -0400 Message-ID: To: Olivier Matz Cc: Vivien Didelot , dev@dpdk.org, Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC PATCH 1/3] net/mlx5: add timestamp-to-ns converter from libibverbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 26, 2020 at 2:41 AM Olivier Matz wrote: > Should mlx5dv_get_clock_info() be called for each convesion? In the man > page [1], we can read this: > > If the clock_info becomes too old then time conversion will return > wrong conversion results. The user must ensure that > mlx5dv_get_clock_info(3) is called at least once every > max_clock_info_update_nsec as returned by the mlx5dv_query_device(3) > function. > > I understand this as mlx5dv_get_clock_info() being slower than > mlx5dv_ts_to_ns(), and should not be called for each packet. Right. I plan to use rte_timer (like in drivers/net/ena/) to query clock info periodically. > > I suppose that when rdma-core library does a conversion to nanosec, it > takes in account the fact that system and device are not synchronized > (are they?). PTP daemon like linuxptp is in charge of syncing both device and system clocks with external master. Thanks. PK