From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91D334383E; Fri, 5 Jan 2024 16:51:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CADC402D8; Fri, 5 Jan 2024 16:51:30 +0100 (CET) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by mails.dpdk.org (Postfix) with ESMTP id 463BA402CC for ; Fri, 5 Jan 2024 16:51:28 +0100 (CET) Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3bbce1202ebso1132122b6e.2 for ; Fri, 05 Jan 2024 07:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; t=1704469887; x=1705074687; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0/bIdiO5IGuSPNUWRKRxFYHXFL9xKDzlzwdl90tsWoc=; b=M3WdJ+A2SYLohb9rV8i1OE/5s0Uioq29mDl5PnQYfAvPr7AdneY/nOt8Nd5mFFBwHS WFr9ncW3FobI2aIDjThV/rT1zn/6MAwDRzgSYFlzYSfxR7XdWivJBsDRAOitQ/k1wJIa Q0NbWuKkVP1Yp1X0HqN/Dv2az2A5XIL/RHtDtD2UmpH//DFwiWkUj5MIooOueG6cpofa g8HE/feSc1nfsy2PxtIRhLfJEZpQgBsR9B+zwPtvmdPce2+7p8BxSg5l9exeK2rfEYIj MWtN1PX0DPJkKdYQVNTaFxEIvOAMfMRcFSGe4Iaw9kPPGdUp/Mb5Dw36qLn+gevZMysU hMLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704469887; x=1705074687; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/bIdiO5IGuSPNUWRKRxFYHXFL9xKDzlzwdl90tsWoc=; b=s3lQ9lVlvwTzU5KLTWaWGPxxqTOfV1tr0W2j91ocpLS0N3AxvPkX8ebHZkX5zT2Rop KpX8DZ3wmu/606B1r/ierGtmITbGcqdWKP65uHQP3DDn8p0u0vy6Me8V8kqYjKaVuMrd iUZNyC7Eb6JwWslk5xDxRaT7rK1OX4ep8zjeqvQUymkUOq28XZiTzdDG7fB/KKveujuq nJvqNQdEyKdkkfIlRy8ZghlKJeDthsmYWEEKP4RLlOJRZs97V5DvGDo5+TenB4Xxx4zF vT145as1/m6lGUepQ40i0ZoVwefaiKIpTyE9BeXLem2/nTIcaEtXL0yCy7iHdbdawKbe bNlg== X-Gm-Message-State: AOJu0YzJFMI7Ykt4KVaTuxsp+BEk1HCJglqSfVY/kLFUwn4iE70PxLBc R0c3MboiEoulBeZoz6+AY62lgW/IP3tKbfLrEmFn2sct14IiLw== X-Google-Smtp-Source: AGHT+IFiZPJqz77drORD83jVz1Xva6G9KuLEfISdiyYlWoxsGjyJ44oNE9zH63EKK90hFgenvF9V6rf24Vots8EZ3/A= X-Received: by 2002:a05:6808:1313:b0:3bb:f6dd:d872 with SMTP id y19-20020a056808131300b003bbf6ddd872mr2597147oiv.77.1704469887513; Fri, 05 Jan 2024 07:51:27 -0800 (PST) MIME-Version: 1.0 References: <20231121164903.3982163-1-christian.ehrhardt@canonical.com> In-Reply-To: From: =?UTF-8?Q?Stanis=C5=82aw_Kardach?= Date: Fri, 5 Jan 2024 16:50:50 +0100 Message-ID: Subject: Re: [PATCH] build: riscv is not a valid -march value To: David Marchand Cc: christian.ehrhardt@canonical.com, dev , Thomas Monjalon , Luca Boccassi , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 22, 2023 at 5:41=E2=80=AFPM David Marchand wrote: > > On Wed, Nov 22, 2023 at 5:17=E2=80=AFPM Bruce Richardson > wrote: > > > > On Wed, Nov 22, 2023 at 05:02:56PM +0100, David Marchand wrote: > > > On Tue, Nov 21, 2023 at 5:49=E2=80=AFPM wrote: > > > > > > > > From: Christian Ehrhardt > > > > > > > > If building riscv natively with -Dplatform=3Dgeneric config/meson.b= uild > > > > will select cpu_instruction_set=3Driscv. > > > > > > > > That was fine because config/riscv/meson.build did override it to v= alid > > > > values later, but since b7676fcccab4 ("config: verify machine arch > > > > flag") it will break the build as it tries to test -march=3Driscv w= hich > > > > is not a value value. > > > > > > > > The generic setting used in most cases is rv64gc, set this here > > > > as well. > > > > > > > > Fixes: b7676fcccab4 ("config: verify machine arch flag") > > > > Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture") > > > > > > > > Signed-off-by: Christian Ehrhardt > > > > --- > > > > config/meson.build | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/config/meson.build b/config/meson.build > > > > index d732154731..a9ccd56deb 100644 > > > > --- a/config/meson.build > > > > +++ b/config/meson.build > > > > @@ -152,7 +152,7 @@ if cpu_instruction_set =3D=3D 'generic' > > > > elif host_machine.cpu_family().startswith('ppc') > > > > cpu_instruction_set =3D 'power8' > > > > elif host_machine.cpu_family().startswith('riscv') > > > > - cpu_instruction_set =3D 'riscv' > > > > + cpu_instruction_set =3D 'rv64gc' > > > > > > Copying more people. > > > > > > This fix is probably the best, so close to the release. > > > > > > > Agreed > > I took this patch as is, for now. Sorry for reviving an old thread, I was on a rather long OoO, hence I did not answer. Thank you for taking this patch. > > > > > > > > > However, I think a more complete fix would be to set this here to gen= eric. > > > And do the march validation in config/riscv/meson.build in a similar > > > fashion to ARM. > > > > > > Or maybe the validation added in b7676fcccab4 ("config: verify machin= e > > > arch flag") should be moved after subdir(arch_subdir). > > > Bruce, opinion? > > > > > > > Probably the first of these two is best, to do the march validation in = the > > riscv-specific file. However, I've no strong opinions either way. > > Stanislaw, could you look at doing some enhancement on this topic? > And, in any case, what we lack is a CI for RISC V. It seems that there is not much traction for RISC-V DPDK yet. StarFive seems to be focused more on the platform side of things and therefore I don't have any server-grade HW to really run CI on. > > > -- > David Marchand > -- Best Regards, Stanis=C5=82aw Kardach