From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12FF5A0581; Tue, 22 Nov 2022 13:00:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A81C142D5A; Tue, 22 Nov 2022 13:00:58 +0100 (CET) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mails.dpdk.org (Postfix) with ESMTP id AD5C2427EB for ; Tue, 22 Nov 2022 13:00:56 +0100 (CET) Received: by mail-io1-f49.google.com with SMTP id e189so10765977iof.1 for ; Tue, 22 Nov 2022 04:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2OB/cbcK+4BN8DTcxCYdGwTKJApe1ijaCpXggPlZr20=; b=bOI7ZgY3DvoMbd1alKCdMJXfe9wRZ5lumokDczvVkjBSRBNccn3Y+DRKcURDv0JZlf w4rbamszK+Zif91HRDtzLa2wmiIDFpIf/9RIxdXxeEUsff8rZt3IXE4QzBad9/SP87/3 sGQI7Wg9n6eWE3wl2e06CHeHzQi+H93eS4h62nV5yszqS+Zs+euRE9vwsXq8/+Oa/qqo NEWXEy/XDao21E1tz89SEqTdMwx8lepFUubOwTY8zwL6hVqixMxfWyDu9VEgAc8y0IJH OjOqLldy4tU7LKwqI01IzuWw7WgSicx1WFzfbcNP0O7akilmXFZEfo/i6ibBq+KXjt/5 Hx/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2OB/cbcK+4BN8DTcxCYdGwTKJApe1ijaCpXggPlZr20=; b=AxiyZkghpdIbXnxxrjOfhTZCsFiDbURp73cFwuC11wM7vgQ+CrCMhxTKOVI+j175mz cE5kkhv7igBvGZRJdgR94Kt/U4s3XQLmuTLfMxCxuOFCcmY16Wo+1wnZTMV88QjhL90A AbRx+vKkdI/uaivRZgDOvGC5dH3pdf0q/2PsELvh2S9AhACZKXZ8KlwNRDWBZi6Mt0HS WqdpoqGp8PW7oln4kuknVBDvduqQBIK56Tcjl+zu2LP4U9tB45Hs8ITIDGBqx1m7GBR5 Ct2QKRrz33llxm1KQ+0VqiZbiIDKQsPUPHjgzSDrG7mguP4yFnUTPsfWTsHka5bAf88z x+KA== X-Gm-Message-State: ANoB5pkUkoJ3qSrTXbs8IrrRxTvZcS5YTNhPkwmJQe7D9M7kSt2eHaSa spbi1JTSTXrSW3DWtZDt9RBGFU4US2iI4GBX33RHrw== X-Google-Smtp-Source: AA0mqf7mCV/74NkTHoobDfKIa5nwY9NXb47WG6LgM5IEID/jmyf4rG4927wvb0yq7JH574XS+CJWZAc+6R2UXgps5jY= X-Received: by 2002:a5d:9499:0:b0:6de:dee8:b91d with SMTP id v25-20020a5d9499000000b006dedee8b91dmr3185765ioj.64.1669118455865; Tue, 22 Nov 2022 04:00:55 -0800 (PST) MIME-Version: 1.0 References: <20221115173516.33051-1-stephen@networkplumber.org> <20221122113739.2486678-1-david.marchand@redhat.com> In-Reply-To: <20221122113739.2486678-1-david.marchand@redhat.com> From: =?UTF-8?Q?Stanis=C5=82aw_Kardach?= Date: Tue, 22 Nov 2022 13:00:19 +0100 Message-ID: Subject: Re: [PATCH v2] doc: avoid meson deprecation in setup To: David Marchand Cc: dev@dpdk.org, Stephen Hemminger , Bruce Richardson , Zhangfei Gao , Ruifeng Wang , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Elena Agostini , Min Zhou , Shepard Siegel , Ed Czeck , John Miller , Zyta Szpak , Liron Himi , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , David Hunt , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 22, 2022 at 12:38 PM David Marchand wrote: > > From: Stephen Hemminger > > The command "meson build" causes a deprecation warning with meson 0.64.0. > > WARNING: Running the setup command as `meson [options]` instead of > `meson setup [options]` is ambiguous and deprecated. > > Therefore fix the examples in the documentation. > > Signed-off-by: Stephen Hemminger > Acked-by: Bruce Richardson > Acked-by: Zhangfei Gao > Signed-off-by: David Marchand > --- > Changes since v1: > - fixed commitlog, > - dropped unrelated changes (and sometimes broken), > - fixed all (I am probably too optimistic) other occurences in the doc, > > --- > doc/guides/cryptodevs/armv8.rst | 2 +- > doc/guides/cryptodevs/bcmfs.rst | 2 +- > doc/guides/cryptodevs/uadk.rst | 2 +- > doc/guides/freebsd_gsg/build_dpdk.rst | 2 +- > doc/guides/gpus/cuda.rst | 6 +-- > doc/guides/howto/openwrt.rst | 2 +- > doc/guides/linux_gsg/build_dpdk.rst | 8 ++-- > .../linux_gsg/cross_build_dpdk_for_arm64.rst | 12 +++--- > .../cross_build_dpdk_for_loongarch.rst | 2 +- > .../linux_gsg/cross_build_dpdk_for_riscv.rst | 4 +- > doc/guides/nics/ark.rst | 2 +- > doc/guides/nics/mvneta.rst | 2 +- > doc/guides/nics/mvpp2.rst | 2 +- > doc/guides/platform/bluefield.rst | 4 +- > doc/guides/platform/cnxk.rst | 8 ++-- > doc/guides/platform/octeontx.rst | 8 ++-- > doc/guides/prog_guide/build-sdk-meson.rst | 39 +++++++++++-------- > doc/guides/prog_guide/lto.rst | 2 +- > doc/guides/prog_guide/profile_app.rst | 4 +- > .../sample_app_ug/vm_power_management.rst | 4 +- > doc/guides/windows_gsg/build_dpdk.rst | 4 +- > 21 files changed, 63 insertions(+), 58 deletions(-) > > diff --git a/doc/guides/cryptodevs/armv8.rst b/doc/guides/cryptodevs/armv= 8.rst > index 8963f66a20..1a006754cb 100644 > --- a/doc/guides/cryptodevs/armv8.rst > +++ b/doc/guides/cryptodevs/armv8.rst > @@ -47,7 +47,7 @@ To build DPDK with this virtual crypto PMD, the user is= required to: > > .. code-block:: console > > - meson build > + meson setup build > ninja -C build > > The corresponding device can be created only if the following features > diff --git a/doc/guides/cryptodevs/bcmfs.rst b/doc/guides/cryptodevs/bcmf= s.rst > index f5dcd59c87..d18a253913 100644 > --- a/doc/guides/cryptodevs/bcmfs.rst > +++ b/doc/guides/cryptodevs/bcmfs.rst > @@ -70,7 +70,7 @@ for cross compiling on x86 platform. > .. code-block:: console > > cd > - meson --cross-file config/arm/arm64_stingray_linux_gcc > + meson setup --cross-file config/arm/arm64_stingray_linux_= gcc > cd > ninja > > diff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.= rst > index 1325eaca3f..9af6b88a5a 100644 > --- a/doc/guides/cryptodevs/uadk.rst > +++ b/doc/guides/cryptodevs/uadk.rst > @@ -87,7 +87,7 @@ Test steps > > cd dpdk > mkdir build > - meson build (--reconfigure) > + meson setup build (--reconfigure) > cd build > ninja > sudo ninja install > diff --git a/doc/guides/freebsd_gsg/build_dpdk.rst b/doc/guides/freebsd_g= sg/build_dpdk.rst > index d335b97cfc..514d18c870 100644 > --- a/doc/guides/freebsd_gsg/build_dpdk.rst > +++ b/doc/guides/freebsd_gsg/build_dpdk.rst > @@ -44,7 +44,7 @@ Building DPDK > The following commands can be used to build and install DPDK on a system= . > The final, install, step generally needs to be run as root:: > > - meson build > + meson setup build > cd build > ninja > ninja install > diff --git a/doc/guides/gpus/cuda.rst b/doc/guides/gpus/cuda.rst > index 55fc7d1e86..114e3bc8cb 100644 > --- a/doc/guides/gpus/cuda.rst > +++ b/doc/guides/gpus/cuda.rst > @@ -24,8 +24,8 @@ You need to indicate to meson where CUDA headers files = are through the CFLAGS va > Three ways: > > - Set ``export CFLAGS=3D-I/usr/local/cuda/include`` before building > -- Add CFLAGS in the meson command line ``CFLAGS=3D-I/usr/local/cuda/incl= ude meson build`` > -- Add the ``-Dc_args`` in meson command line ``meson build -Dc_args=3D-I= /usr/local/cuda/include`` > +- Add CFLAGS in the meson command line ``CFLAGS=3D-I/usr/local/cuda/incl= ude meson setup build`` > +- Add the ``-Dc_args`` in meson command line ``meson setup build -Dc_arg= s=3D-I/usr/local/cuda/include`` > > If headers are not found, the CUDA GPU driver library is not built. > > @@ -51,7 +51,7 @@ An example would be: > > .. code-block:: console > > - $ meson build -Dc_args=3D"-I/usr/local/cuda/include -I/path/to/gdrcopy= /include" > + $ meson setup build -Dc_args=3D"-I/usr/local/cuda/include -I/path/to/g= drcopy/include" > > If headers are not found, the CUDA GPU driver library is built without t= he CPU map capability > and will return error if the application invokes the gpudev ``rte_gpu_me= m_cpu_map`` function. > diff --git a/doc/guides/howto/openwrt.rst b/doc/guides/howto/openwrt.rst > index e1d7db2a90..be902c505f 100644 > --- a/doc/guides/howto/openwrt.rst > +++ b/doc/guides/howto/openwrt.rst > @@ -100,7 +100,7 @@ first. > ar =3D 'x86_64-openwrt-linux-ar' > strip =3D 'x86_64-openwrt-linux-strip' > > - meson builddir --cross-file openwrt-cross > + meson setup builddir --cross-file openwrt-cross > ninja -C builddir > > Running DPDK application on OpenWrt > diff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/b= uild_dpdk.rst > index 4f2def15ed..bbd2efc9d8 100644 > --- a/doc/guides/linux_gsg/build_dpdk.rst > +++ b/doc/guides/linux_gsg/build_dpdk.rst > @@ -53,7 +53,7 @@ To configure a DPDK build use: > > .. code-block:: console > > - meson build > + meson setup build > > where "build" is the desired output build directory, and "" can= be > empty or one of a number of meson or DPDK-specific build options, descri= bed > @@ -140,7 +140,7 @@ automatically built as part of a meson build too. > To do so, pass a comma-separated list of the examples to build to the > `-Dexamples` meson option as below:: > > - meson -Dexamples=3Dl2fwd,l3fwd build > + meson setup -Dexamples=3Dl2fwd,l3fwd build > > As with other meson options, this can also be set post-initial-config us= ing `meson configure` in the build directory. > There is also a special value "all" to request that all example applicat= ions whose > @@ -166,12 +166,12 @@ The following meson command can be used on RHEL/Fed= ora systems to configure a 32 > assuming the relevant 32-bit development packages, such as a 32-bit libc= , are installed:: > > PKG_CONFIG_LIBDIR=3D/usr/lib/pkgconfig \ > - meson -Dc_args=3D'-m32' -Dc_link_args=3D'-m32' build > + meson setup -Dc_args=3D'-m32' -Dc_link_args=3D'-m32' build > > For Debian/Ubuntu systems, the equivalent command is:: > > PKG_CONFIG_LIBDIR=3D/usr/lib/i386-linux-gnu/pkgconfig \ > - meson -Dc_args=3D'-m32' -Dc_link_args=3D'-m32' build > + meson setup -Dc_args=3D'-m32' -Dc_link_args=3D'-m32' build > > Once the build directory has been configured, > DPDK can be compiled using ``ninja`` as described above. > diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/gu= ides/linux_gsg/cross_build_dpdk_for_arm64.rst > index cbe9d171f8..e4de5c8d18 100644 > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > @@ -167,19 +167,19 @@ Cross Compiling DPDK with GNU toolchain using Meson > To cross-compile DPDK on a desired target machine we can use the followi= ng > command:: > > - meson cross-build --cross-file > + meson setup cross-build --cross-file > ninja -C cross-build > > For example if the target machine is aarch64 we can use the following > command, provided the cross file has been modified accordingly:: > > - meson aarch64-build-gcc --cross-file config/arm/arm64_armv8_linux_gcc > + meson setup aarch64-build-gcc --cross-file config/arm/arm64_armv8_lin= ux_gcc > ninja -C aarch64-build-gcc > > If the target machine is aarch32 we can use the following command, > provided the cross file has been modified accordingly:: > > - meson aarch32-build --cross-file config/arm/arm32_armv8_linux_gcc > + meson setup aarch32-build --cross-file config/arm/arm32_armv8_linux_g= cc > ninja -C aarch32-build > > LLVM/Clang toolchain > @@ -230,7 +230,7 @@ Assuming the file with augmented ``c_args`` and ``c_l= ink_args`` > is named ``arm64_armv8_linux_clang``, > use the following command to cross-compile DPDK for the target machine:: > > - meson aarch64-build-clang --cross-file config/arm/arm64_armv8_linux_c= lang > + meson setup aarch64-build-clang --cross-file config/arm/arm64_armv8_l= inux_clang > ninja -C aarch64-build-clang > > Cross Compiling DPDK with LLVM/Clang toolchain using Meson on Ubuntu 18.= 04 > @@ -247,7 +247,7 @@ On Ubuntu 18.04, these packages are needed: > > Use the following command to cross-compile DPDK for the target machine:: > > - meson aarch64-build-clang --cross-file config/arm/arm64_armv8_linux_c= lang_ubuntu1804 > + meson setup aarch64-build-clang --cross-file config/arm/arm64_armv8_l= inux_clang_ubuntu1804 > ninja -C aarch64-build-clang > > Building for an aarch64 SoC on an aarch64 build machine > @@ -258,7 +258,7 @@ you don't need a separate cross toolchain, just a dif= ferent set of > configuration options. To build for an aarch64 SoC, use the -Dplatform m= eson > option:: > > - meson soc_build -Dplatform=3D > + meson setup soc_build -Dplatform=3D > > Substitute with one of the supported SoCs > > diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst b/do= c/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst > index 1549cc86d5..7f75960e9e 100644 > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst > @@ -81,7 +81,7 @@ To cross-compile DPDK for generic LoongArch we can use = the following command: > > .. code-block:: console > > - meson cross-build --cross-file config/loongarch/loongarch_loongarch64= _linux_gcc > + meson setup cross-build --cross-file config/loongarch/loongarch_loong= arch64_linux_gcc > ninja -C cross-build > > Supported cross-compilation targets > diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst b/doc/gu= ides/linux_gsg/cross_build_dpdk_for_riscv.rst > index 9e121645a8..7d7f7ac72b 100644 > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst > @@ -68,13 +68,13 @@ Cross Compiling DPDK with GNU toolchain using Meson > > To cross-compile DPDK for a desired target machine use the following com= mand:: > > - meson cross-build --cross-file > + meson setup cross-build --cross-file > ninja -C cross-build > > For example if the target machine is a generic rv64gc RISC-V, use the fo= llowing > command:: > > - meson riscv64-build-gcc --cross-file config/riscv/riscv64_linux_gcc > + meson setup riscv64-build-gcc --cross-file config/riscv/riscv64_linux= _gcc > ninja -C riscv64-build-gcc > > If riscv-gnu-toolchain is used, binary names should be updated to match.= Update > Thanks for fixing this! Acked-by: Stanislaw Kardach --=20 Best Regards, Stanis=C5=82aw Kardach