From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA6E3A0524; Mon, 19 Apr 2021 16:44:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A0504130F; Mon, 19 Apr 2021 16:44:37 +0200 (CEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id A9DBB412E6 for ; Mon, 19 Apr 2021 16:44:36 +0200 (CEST) Received: by mail-wm1-f46.google.com with SMTP id d200-20020a1c1dd10000b02901384767d4a5so2245525wmd.3 for ; Mon, 19 Apr 2021 07:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6uPhR8lbey9BehqP09sGU2smtCCRB33Pma48ADNBypc=; b=eamuMofY2/nRMrq19BZIQ7WkUuehLH4Ifp8xzfm/VHhwMLJ7CnRejVbVoQBRBAhG/f LfBp9LvsRDyA4AGWszNNDBbODU0645vokMA9CCrq9GJEkvVYEZQUKjzAshrrTe9f1N4B mEPoMbXuCprDpwo/xUAS6pKYNPmFkJk0253+eBkjsJhBaR7UypIRRB1NAoSJmi8ANslw KM+ptUC3fsOrafjRGkFw+06/s+r7aD4eS1c0xACQLTKKwC/iJy4MzrpFhtB5iu02mzJZ 539dMmRnEOImhgJZ6R7EoYKoPSOZyHNrpbYlgIfffqdesRXiOfyejGGByDLB1jMJ5MSC f8oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6uPhR8lbey9BehqP09sGU2smtCCRB33Pma48ADNBypc=; b=ouRK5N6H4SnosZiBI+UmG0EYj+ZPiFNnRO+iYJtesMASS0h0ygeSIIAR2t7uQcr9zT ie2H+qcVoZOWTi8QJjWV6Mt+l2awk1WoMKK/n+LZDv4fpRD8iyPUcXgTLUaYZbV/rYyl hC+Ge3gxHjHOt/t/CJTYR4u1gZCmVB3bDzWa90AoxucXCnsHZEXv8JeyEAViYUSb3k5F igPovRczmO8Di9XvRHrkIpnHgJiCfLCIoKMENPLpv1KTp8Mwh/OLz/DjIkkHPpHf3G/W sJpdsIsUzhrXoWPYmhBaXyNQaihvz3Q938JxNnZMgR9DuPsZgapOLbnCJOse0SZDK522 Zz1Q== X-Gm-Message-State: AOAM531piI4Np4L0kf9dVb0ydEj/RK+vALEMtsc6X7931g0v/YCAK0l4 fF5I3ieNJxot1fRZS+UvITgUQA== X-Google-Smtp-Source: ABdhPJwQNUaxoFvvWLwGnl04cgr9L16B8IuA34Ec4dylND4ZiZVbMWLt0ZqESlQAn51Phm2RXjgSlA== X-Received: by 2002:a05:600c:350b:: with SMTP id h11mr11177254wmq.103.1618843476242; Mon, 19 Apr 2021 07:44:36 -0700 (PDT) Received: from toster (89-73-146-138.dynamic.chello.pl. [89.73.146.138]) by smtp.gmail.com with ESMTPSA id r2sm23013255wrt.79.2021.04.19.07.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 07:44:35 -0700 (PDT) Date: Mon, 19 Apr 2021 16:44:34 +0200 From: =?utf-8?Q?Stanis=C5=82aw?= Kardach To: David Marchand Cc: Olivier Matz , dev , dpdk stable Message-ID: References: <20210412082901.652736-1-kda@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 16, 2021 at 08:34:29AM +0200, David Marchand wrote: > On Mon, Apr 12, 2021 at 10:29 AM Stanislaw Kardach wrote: > > > > The lock-free stack implementation (RTE_STACK_F_LF) is supported only on a > > subset of platforms, namely x86_64 and arm64. Platforms supporting 128b atomics > > have to opt-in to a generic or C11 implementations. All other platforms use a > > stubbed implementation for push/pop operations which are basically NOPs. > > However rte_stack_create() will not fail and application can proceed assuming > > it has a working lock-free stack. > > Did you actually hit this issue or is this only theoretical? > I can only think of ppc64 displaying such behavior. > I actually hit this issue while working on a RISC-V port. My reasoning here is that sooner or later someone else will stumble upon this, either on ppc64 or while trying to port to some new platform. It is also a really nasty limitation do debug given the silent nature of the failure. > > -- > David Marchand > -- Best Regards, Stanislaw Kardach