From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61DFBA0032; Wed, 11 May 2022 12:28:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 128F3410F2; Wed, 11 May 2022 12:28:50 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 3097A40DDD for ; Wed, 11 May 2022 12:28:48 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id d19so2745081lfj.4 for ; Wed, 11 May 2022 03:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YWbFxILD8w5P7IsFAv8U0q60iYLeqIo91Lo/cb6BgBo=; b=sHTM+r0bemBIrgKecFI3ZnW459Mg8O4b04sDPEuzhrZIMP7crzn7pJFWcmRgO1eBF3 LkxetDhBviqGxuJoTfrSVAxPQUsYZ4fKtlZLgQlj6L78cvbSH6Mx+IM2TNaN2XA+rEnb A+xdpU26PbiD72xUYbKMMK0s9HizZUwLnSfTyauUsn2Tt2IGJgGLA0g1gukoG1gJaPSd JdTECbfS5+nHNVF5jxSEvFVE52BK6fOWf5sSYDBHQUbN1tEPT5J6VJvnL09xorLxtrR3 Jy7QecPBfFAFxeAdWHDA92FmFWPUgITiVxNSvH4mdStCqENDfZdA4yqYSxMBeU+3v/00 lKeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YWbFxILD8w5P7IsFAv8U0q60iYLeqIo91Lo/cb6BgBo=; b=l5Iouri9E+zwgYswDA/FRGdDYV8p5MMsydfoRNOOvAXoiJe8/wUQBYW/5LmVIGwH0W BaAhasRY+/lJcnfQjce9SPhGXx9+kEHni5RIlNoSBdH21f8j8zVCg2BIAo3XMvUyhmwz feEHyvCB2IC6wkm9JSTW7hsi6JpoNeAmIeJxLi1Sr47L5SGKXdSNGYoFwMejnPHAHjCa OqRBX8nVe0kd88WJWo1YlZEX4LcQ8Uek9mReZtBwDyhAQzjXy6Pwzz45aIdyLMRaHU1b eO2M69mqgG7eNVLAJjuBvXmw6LQ82kZcDO9aqQUve3NJXqWDdLGH0cqx+6qSWWlgN3DX 8JlA== X-Gm-Message-State: AOAM531fwp+jqL/feo14AREpPBkR3awYlkf+7g/9DY27sHO5cIaV75Oe y+v/KaQFzQpWmuplArQdU1f4FaZHlhofDCf17MqfIw== X-Google-Smtp-Source: ABdhPJz3P8HmJmUfDThDnrPRtVI8pJJ/quIaldW8emBNWDsgEZnDG0PmNwS7VzveO2upkYOTRueuiyYFnNBThSMa4mM= X-Received: by 2002:a05:6512:3096:b0:473:b43c:1678 with SMTP id z22-20020a056512309600b00473b43c1678mr19826731lfd.289.1652264927715; Wed, 11 May 2022 03:28:47 -0700 (PDT) MIME-Version: 1.0 References: <20220505173003.3242618-1-kda@semihalf.com> <8931664.CDJkKcVGEf@thomas> <98CBD80474FA8B44BF855DF32C47DC35D8705C@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8705C@smartserver.smartshare.dk> From: =?UTF-8?Q?Stanis=C5=82aw_Kardach?= Date: Wed, 11 May 2022 12:28:11 +0200 Message-ID: Subject: Re: [PATCH 00/11] Introduce support for RISC-V architecture To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Thomas Monjalon , David Marchand , dev , Frank Zhao , Sam Grove , Marcin Wojtas , upstream@semihalf.com, Stephen Hemminger Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 11, 2022 at 10:09 AM Morten Br=C3=B8rup wrote: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Monday, 9 May 2022 14.31 > > > > 09/05/2022 14:24, Stanis=C5=82aw Kardach: > > > On Fri, May 6, 2022 at 11:13 AM David Marchand > > > > > wrote: > > > > About the new "Sponsored-by" tag, it should not raise warnings in > > the > > > > CI if we agree on its addition. > > > > > > > I'll modify it in V2 to be in form of: > > > Sponsored by: StarFive Technology > > > > You mean removing the hyphen? > > I think it is better to keep it so all tags have the same format. > > I agree with Thomas. Please keep the hyphen. > > > > > > ... > > > Signed-off-by: ... > > > > > > This was suggested by Stephen Hemminger as having a precedent in > > Linux > > > kernel. Interestingly enough first use of this tag in kernel source > > was > > > this year in January. > > I don't get it! Should employees start adding Sponsored-by: to their commits, when doing it as part of their job? And how about cont= ract developers, should they also add a Sponsored-by: tag, s= ince they are working under contract and getting paid by that company? If I understand correctly, the concern about the commit log staying technical and not introducing extra elements not beneficial to the project, correct? In the scope of this particular patchset, the companies sponsoring the work are in copyrights for appropriate files, so I can remove the tags. For my own curiosity, what would be a proper way for a contract developer to mark the company sponsoring the work? Some companies may not care, others will. Maybe it would be beneficial to add a comment on this into the contributing guide (or it's already there and I've missed it)? > > Can someone please provide a reference to the discussion about this on th= e LKML? I'm curious why they felt the need for such a tag. Actually I can't find any discussion on this. Perhaps it was missed because: "Sponsored by" (without a hyphen) doesn't trigger checkpatch and only 2 patches (6 and 7) in whole patchset contain it. Patchset for reference: https://www.spinics.net/lists/linux-wireless/msg220474.html > > > > > The precedent is not strong enough to be copied in my opinion. > > I agree. Also, if it is an acceptable signature tag, the checkpatch.pl sc= ript should be updated: > > https://elixir.bootlin.com/linux/v5.18-rc6/source/scripts/checkpatch.pl#L= 607 > >