DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jacques Fourie <jacques.fourie@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] L4 rx checksum verification in tun/tap pmd
Date: Wed, 16 Dec 2020 10:58:11 -0500
Message-ID: <CALX0vxB0HGd97-P9ZVfLS5A3U3uVyH27ksp9nWKj3zOB8149SQ@mail.gmail.com> (raw)

Hi,

I noticed that TCP rx checksum verification fails when using the tap pmd.
In this particular case packets with correct checksums will always have
PKT_RX_L4_CKSUM_BAD set in ol_flags. The rte_ipv4_udptcp_cksum() and
rte_ipv6_udptcp_cksum() functions already return the ones complement of the
checksum, unlike rte_raw_cksum(), which is used for the L3 checksum
verification. After changing the code to use rte_ipv4_udptcp_cksum()
instead of ~rte_ipv4_udptcp_cksum() the problem seems to be fixed. The same
thing goes for rte_ipv6_udptcp_cksum().

Regards,
Jacques

                 reply	other threads:[~2020-12-16 15:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALX0vxB0HGd97-P9ZVfLS5A3U3uVyH27ksp9nWKj3zOB8149SQ@mail.gmail.com \
    --to=jacques.fourie@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git