From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 558F9A0524; Thu, 13 May 2021 12:52:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D06C54067E; Thu, 13 May 2021 12:52:04 +0200 (CEST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mails.dpdk.org (Postfix) with ESMTP id C83FE4003F for ; Thu, 13 May 2021 12:52:03 +0200 (CEST) Received: by mail-ed1-f52.google.com with SMTP id r11so6437281edt.13 for ; Thu, 13 May 2021 03:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZiNdZgh5MQ5vDhZ0ZFxy7nYYTc2qSkPwmB51TfDFNmc=; b=onQ2Dx4zSmmBYoCk5r5VW1Si3mjn1CFaeUTVpw3I97HkvA5qvv3ULvx/wjV8foSHYM hJ9LleE6i8YFf14VDc7DYvugEGVE5cLRqVBPTZ2YRIh8gFFk+YF8LitID6hCnCLPaxw7 rwOjeMsRXGGosnMYbMeoQptVvi4kM4BALEnZpKbJAWDmdn9iagGnqZN9oqFuoHmPuuks IKVpBT6vFf7yUaVfYbwY5VGHLqKg1UrASiAIBHQxTuFXnIhnguYb8qf46ERiVSSv2Bd2 PF0bCG3JqVZhGy3642xP/ZrFuGL6hUkURmMvwuCjS+u43P37MSktMP/7OSYP934Nkc4M Riig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZiNdZgh5MQ5vDhZ0ZFxy7nYYTc2qSkPwmB51TfDFNmc=; b=aLBSxDDzzQsnNQ23VeNu6XySgnNYILZmXoBO6R0D8CTrmPD9fgiplKXxG4wic2u+Ey ulErbaUCAJtOYiMcHNcUl9b2X2oqF9bfckT8aj8ENvKoqGakvtMaSWoa0Zc3HeT4ct95 C4QnuPqUA0QopA9+gQaZUCnsHoUygySG0nW3VYAKfKHPMg2TYqNT74SozFMV5qhVGGc6 wPvxV9sVPYRNOrfS/wBYwAYAHUVJFTJgqdlsmA4z/G1/0EvtSsiIPoF1ryD43RGHqCVr DhVZoB+uKq92jGObiYI2n5dGyiiWOqAw8JSa/DiAj2vf1U5AFSg+9yuXAGnwxwT+IqMI 64YA== X-Gm-Message-State: AOAM530+shntueLIUcuW8oaxqg09oAGGkV0nTs2d72WjVdf7kLep0Us8 W7DYr9iVy/JMB6s2ZEm1m5nFAKHfNFp0cfdWjzQL1Q== X-Google-Smtp-Source: ABdhPJyfZz35UMY7f11sA5Z7Jao+ZPQ/MPbvnNGbw3HYKZINRNNKC16BZ8HVJ7rCJcI4K2LH/i5Yok7iwHtWGFxpAJE= X-Received: by 2002:aa7:d685:: with SMTP id d5mr49878390edr.200.1620903123404; Thu, 13 May 2021 03:52:03 -0700 (PDT) MIME-Version: 1.0 References: <20210202081446.79331-1-wanjunjie@bytedance.com> In-Reply-To: From: Wan Junjie Date: Thu, 13 May 2021 18:51:52 +0800 Message-ID: To: "Xia, Chenbo" Cc: David Marchand , Maxime Coquelin , "dev@dpdk.org" , Peng He , Zhihong Wang , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [External] RE: [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 13, 2021 at 6:24 PM Xia, Chenbo wrote: > > > -----Original Message----- > > From: David Marchand > > Sent: Thursday, May 13, 2021 4:39 PM > > To: Xia, Chenbo ; Maxime Coquelin > > > > Cc: Wan Junjie ; dev@dpdk.org; Peng He > > ; Zhihong Wang > > Subject: Re: [dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while > > IOMMU disabled > > > > On Wed, Apr 7, 2021 at 9:10 AM Xia, Chenbo wrote: > > > > > > > -----Original Message----- > > > > From: Wan Junjie > > > > Sent: Tuesday, February 2, 2021 4:15 PM > > > > To: Xia, Chenbo ; Maxime Coquelin > > > > > > > > Cc: dev@dpdk.org; Wan Junjie ; Peng He > > > > ; Zhihong Wang > > > > Subject: [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU > > disabled > > > > > > > > If vhost device's IOMMU feature is disabled, iotlb mempool allocation > > > > is unnecessary. > > > > > > > > Reported-by: Peng He > > > > Signed-off-by: Wan Junjie > > > > Reviewed-by: Zhihong Wang > > > > --- > > > > 2.11.0 > > > > > > Patch applied to next-virtio/main with conflict resolved, Thanks > > > > This patch triggered a regression reported by Red Hat QE. > > https://bugs.dpdk.org/show_bug.cgi?id=703 > > > > Reverting the patch is enough to fix the regression. > > > > I'll let you guys decide on the next step for 21.05. > > > > > > -- > > David Marchand > > I cannot reproduce this issue on my machine. > > @Wan Junjie Could you reproduce this? I prefer to revert the patch if things > are not very clear as it is only a minor optimization. > > Thanks, > Chenbo > > Hi Chenbo, I am not available for this now. Please revert it. Will dig it later. Thanks, Junjie