From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4ED9A00C5; Tue, 15 Feb 2022 10:50:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 718F8410F3; Tue, 15 Feb 2022 10:50:14 +0100 (CET) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by mails.dpdk.org (Postfix) with ESMTP id 36DDD40E78 for ; Tue, 15 Feb 2022 10:50:13 +0100 (CET) Received: by mail-ed1-f48.google.com with SMTP id w10so12524290edd.11 for ; Tue, 15 Feb 2022 01:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wqTt59K1RfFtE7cZdQcsVa+eVIW102miiPMeO+GyucA=; b=O+2Cd3y6fCaO5ZkByLXIgwU+Ns+tMHCPis14pCJ4g1pR3McTfruoYHNRfpa3SE52bL QzgE1PJ0CBYwh4MkgI0NX/5PcWWpq7Xe0MwtuHojH2kOpfNMnBxPvTWzaqGZdhFDfecw Trhk1PczH//x7E/x3ECiXjZNWOhCL7gY9u2UDOT2RnZwnEzvZfsGDcP555JPJ4DtyEKo X+c7jMfTaAI8AOtP+yNQF+8jiYAwVJA0rb40V/jKXVRyo82HqGeemCauQPiOubRtQwpj lVQ+jQM//zyKMUtbY7ucGLqfAaOtLEQDgy3NluFjCzsSoywRj01TrIU+k6gHElmKLDQE kPYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wqTt59K1RfFtE7cZdQcsVa+eVIW102miiPMeO+GyucA=; b=aIsnBsq1z3MmmCLvpAucASLWV0jUJVhmMc/8H+bu3ibgcIpzCqPjXF/w8p4EfWji7I 16rf4LyecrVnzjk2sELgqF4x589AZTDIAgbKvZpI4TApg/DGGlYsi+N3FMwiQvgW/dnG seiNmRGhzt6fcCzx85bfk/764/m6Ppb3s28K2p/eQODU/l4AYyh+Ae/x1WTpKbFizOvM 8efKnPJbJMOhnqkrFtpES0rcgMa89nbuPqKiouV66u1IW4gF+meDIgNR0oj1ZsDavFTI dz6lW3IjdEfe0LoON/WhiP4NN6d3VQh087J6bd9U/gsEHVg0XHtu5wrGnCTTNhhKNU5g uxZw== X-Gm-Message-State: AOAM530JBBh0y4m3Pwy9ylpJw0/Y314SM+iMbTyRuT8yQKXjGFj5baQk eb/9jRsu5E5dskfZ5PF1YOss/BO780PIQFr88ni0bJ53IQrjcg== X-Google-Smtp-Source: ABdhPJwqD7vB3xVNBM4uxhtpZYAYUPcAta5EiV/V2PBaAqdGsR8S/4fRDb+6WiqVHHWi8tqgYd/92gIneXTsQ1iFi1s= X-Received: by 2002:aa7:ccce:: with SMTP id y14mr3022302edt.89.1644918613004; Tue, 15 Feb 2022 01:50:13 -0800 (PST) MIME-Version: 1.0 References: <20220214081344.13637-1-wanjunjie@bytedance.com> <40e522da-2a94-1916-405d-c82cbf9004f3@huawei.com> In-Reply-To: <40e522da-2a94-1916-405d-c82cbf9004f3@huawei.com> From: Wan Junjie Date: Tue, 15 Feb 2022 17:50:02 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 1/2] net/bonding: add error hint for invald args To: "Min Hu (Connor)" Cc: dev@dpdk.org, Chas Williams Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Min Hu, Thanks for the reply Will fix it in v2. Regards, Wan Junjie On Tue, Feb 15, 2022 at 5:12 PM Min Hu (Connor) wrote: > > Hi, wan, > The headline has spelling errors. > > =E5=9C=A8 2022/2/14 16:13, Wan Junjie =E5=86=99=E9=81=93: > > When invalid args exsit, application exits with no error hint. > > Adding a log message here will help users to know the reson. > > > > Signed-off-by: Wan Junjie > > --- > > drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bondi= ng/rte_eth_bond_pmd.c > > index bfa931098e..aa6519f83c 100644 > > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > > @@ -3439,8 +3439,10 @@ bond_probe(struct rte_vdev_device *dev) > > > > kvlist =3D rte_kvargs_parse(rte_vdev_device_args(dev), > > pmd_bond_init_valid_arguments); > > - if (kvlist =3D=3D NULL) > > + if (kvlist =3D=3D NULL) { > > + RTE_BOND_LOG(ERR, "Invalid args in %s", rte_vdev_device_a= rgs(dev)); > > return -1; > > + } > > > > /* Parse link bonding mode */ > > if (rte_kvargs_count(kvlist, PMD_BOND_MODE_KVARG) =3D=3D 1) { > >