From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 9329A14E8 for ; Thu, 23 Mar 2017 23:20:15 +0100 (CET) Received: by mail-qk0-f181.google.com with SMTP id f11so6031128qkb.0 for ; Thu, 23 Mar 2017 15:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aysiLF6umqmXQJ83XYGDmiCEG2tpPPpz9qie4+Lv/xg=; b=QzYxn5xLIBT0nALAWPEm5RMsou/0X3crefPgMRio0XA1r1aRW92MNk1bCbQQGHWoUO OOr/dJTnZTubKh8Oqzs0Qfcw3M1ZT/k5SIB91EwkCOR41jguwCce9LN2g5CviA9vWa7c ILOImoLYOBNQtOJXFYkuVsMWkLOkrwXpHaGBrkHgRCdOi40BNb0v9nLAi37X5pjuwTVF M7E1Jc2hBsaUIvWnmILP+8IhVabGA7sGebb+73i6j7tF4dxY184yHRRp0P0Pr5yulx52 uuuOsF+/oopHqxrZAW4SlVpvvumtfyf/A01lHwyUtHHdYqkA1yRdvfNCtceTC2JJvwtt I6RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aysiLF6umqmXQJ83XYGDmiCEG2tpPPpz9qie4+Lv/xg=; b=IeTzVnZbdf+vWLg3b0FyrA6L+3WBRQ5aR5JQMht9C+xlZ1gBDEWpNbTS+tx9JlTqeh rXl8AgcHe4h5HjLs+QZBGmvOemJ3RJu4p7RnNiHfZeMscUcEhx2c9SU7O7RqXUGdj+LL /Sf+mRSGlCE1HVE3pOvo2i5/3VoXxUbWOr/cipIQHJCRGMTyJ8DBDzvuU9mGgKDOkTmP u0DZP7prbikIsmI3Rz1b683ag/WEbCxGun+omKgy/eyEoNSv/3O0e8bxIOo2LOZKh76E gK2ToLoFSP36dZdkxMEPn7fFv01uTgyCn3/ZlBDQWfzS0TFWwEs2SnMYTv/xAHuBs2Tk pATQ== X-Gm-Message-State: AFeK/H0XWdIHC/M1m95kFAFUqXQwc/HawC5StYmf4OEKc5EPgt1DwNKhUNJbS7uvO7/+mEZjT/Q9K1e5fGU3Zw== X-Received: by 10.55.151.3 with SMTP id z3mr4637814qkd.79.1490307614782; Thu, 23 Mar 2017 15:20:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.1.131 with HTTP; Thu, 23 Mar 2017 15:19:54 -0700 (PDT) In-Reply-To: References: <1490231015-31748-1-git-send-email-ed.czeck@atomicrules.com> <1490231015-31748-7-git-send-email-ed.czeck@atomicrules.com> From: Ed Czeck Date: Thu, 23 Mar 2017 18:19:54 -0400 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Thomas Monjalon , Shepard Siegel , John Miller Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 7/7] net/ark: Arkville PMD component integration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 22:20:15 -0000 On Thu, Mar 23, 2017 at 8:13 AM, Ferruh Yigit wrote: > > > > > +static > > +int > > Can be in same line. Fixed > > > +check_for_ext(struct rte_eth_dev *dev __rte_unused, > > + struct ark_adapter *ark __rte_unused) > > __rte_unused can go away Fixed > Hi Ed, > > Can you give some more details on "user extension" that loaded dynamically? > > How much the driver depends on it, what happens if the library is missing= ? > > And how do you deliver that shared library? > Dynamic libraries arem optional user provided extensions to the PMD. The driver funcations correctly without one. Here is the blurb from our doc file: doc/guides/nics/ark.rst The ARK PMD user extensions are a feature of Arkville=E2=80=99s DPDK net/ark poll mode driver, allowing users to add their own code to extend the net/ark functionality without having to make source code changes to the driver. One motivation for this capability is that while DPDK provides a rich set of functions to interact with NIC-like capabilities (e.g. MAC addresses and statistics), the Arkville RTL IP does not include a MAC. Users can supply their own MAC or custom FPGA applications, which may require control from the PMD. The user extension is the means providing the control between the user's FPGA application and the existing DPDK features via the PMD.