From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F657A056A; Wed, 10 Mar 2021 22:53:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DF7922A586; Wed, 10 Mar 2021 22:53:26 +0100 (CET) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mails.dpdk.org (Postfix) with ESMTP id 1DA6922A49F for ; Wed, 10 Mar 2021 22:53:24 +0100 (CET) Received: by mail-lf1-f43.google.com with SMTP id r3so27964520lfc.13 for ; Wed, 10 Mar 2021 13:53:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IV7LU/thZuh/wltIRbBKkIFPJd5SvHjOiXszaomDURg=; b=KV+aueRj1Fa8bZyf3RH0WU4K7sMRUleSNoZEuWwtgHRbAVQtVuROjlboSRDGj7jSlf q1dNxQBEP1H80ALsGmIggLIdQpCdeTcYBvUfOJOUHf0pxolOguFLkjJffXNESfpVbCip puXvoU26AMGqnQ/7TK6B4nuSJZRyUxIx2YiIr4BaEHjGf9o/UsM9oEmoGCg3ptQ7yz7H hAZlKlWGaFkPqE7XkGHOVUrY0s4J5qVMKzsdR5NvbLzTrIxobBncIFV2NuPC9L7/Hk3X 4OBjEdigT41iHMfHvy6xuuWJsRDnIexZZBPmlxZPqm5li+ST/v8LC7avF3cDnd+LWI4X rGZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IV7LU/thZuh/wltIRbBKkIFPJd5SvHjOiXszaomDURg=; b=jvujLVsn7HRwBbKjejIzzLyD5WhjNwa/M+Cg5WLYyVVKMECC51TwgdeQUyP8Eg3Wy6 nOwMQRr5HViLsYFs72zkv9P23GeQobV3YI8ragEqbKOTnAfU//c1laatzdEKWG6/OZNU a+IZbLjTNG7/PVwkWKyrZdpT3S41VgfyUYjm8QsrsvleA9gdESUN8sO8jeDlb0frtHMD /fqBxMri/MIRNG6vwSmPX7BLlcAsywZ6sj1o+5j8XNV96SdYh/6GeNVdCZA3vrKFPljU kPrRdAyfwEKPSnSspsDXGMZAXjfnTGDj1WxTsw3NRO8N7VfjkKDqC065jvYp7zlrs3RT QZzw== X-Gm-Message-State: AOAM533DaHiJOzwgMx3/0c2K8N3rdDN95cJWQ4vF9hV0iXLnxXRnZQmW L8SS5WFsNuq7xN4k7Idn3N79nHOT8zAeLmZaOGsayg== X-Google-Smtp-Source: ABdhPJwGVTRqSXtOPdwBm1ZBI055tynmXHlSw21N+o6ziLh1rBjJfS/cRXKzIDAm7FtirmH6W9/Ji3xUk2rlRVvKuFc= X-Received: by 2002:ac2:5bcb:: with SMTP id u11mr280786lfn.603.1615413203529; Wed, 10 Mar 2021 13:53:23 -0800 (PST) MIME-Version: 1.0 References: <20210304165637.24658-1-ed.czeck@atomicrules.com> <20210309160818.3553-1-ed.czeck@atomicrules.com> <20210309160818.3553-5-ed.czeck@atomicrules.com> <3f558b98-66d1-ce63-9ee0-90364cd51146@intel.com> In-Reply-To: From: Ed Czeck Date: Wed, 10 Mar 2021 16:53:12 -0500 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Shepard Siegel , John Miller , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 10, 2021 at 11:44 AM Ferruh Yigit wrote: > > On 3/10/2021 3:02 PM, Ed Czeck wrote: > > On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: > >> > >> On 3/9/2021 4:08 PM, Ed Czeck wrote: > >>> In this commit we generalize the movement of user-specified > >>> meta data between mbufs and FPGA AXIS tuser fields using > >>> user-defined hook functions. > >>> > >>> - Previous use of PMD dynfields are removed > >>> - Hook function added to ark_user_ext > >>> - Add hook function calls in Rx and Tx paths > >>> - Update guide with example of hook function use > >>> - Add release notes > >>> > >>> Signed-off-by: Ed Czeck > >>> --- > >>> v3: > >>> - split function rename to separate commit > >>> > >>> v4: > >>> - reorder patches renaming before adding > >> > >> <...> > >> > >>> diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map > >>> index 954bea679..4a76d1d52 100644 > >>> --- a/drivers/net/ark/version.map > >>> +++ b/drivers/net/ark/version.map > >>> @@ -1,10 +1,3 @@ > >>> DPDK_21 { > >>> local: *; > >>> }; > >>> - > >>> -EXPERIMENTAL { > >>> - global: > >>> - > >>> - rte_pmd_ark_tx_userdata_dynfield_offset; > >>> - rte_pmd_ark_rx_userdata_dynfield_offset; > >>> -}; > >>> > >> > >> Since there is no more public APIs by driver, I think it should stop installing > >> the header, and remove it from 'meson.build' file, and remove the header from > >> API documentation, 'doc/api/doxy-api-index.md'. > >> > >> I can see the header needs to be used by the extension developer, but that is > >> still kind of PMD, the public headers are installed for the application developers. > >> > >> Still there is a desire to install the required headers for PMD developers, as > >> far as I know Bruce is working on it, cc'ed. This header can be installed as > >> part of that effort. > >> > >> Thanks, > >> ferruh > > > > The function prototypes in the header are required by the extension > > developer, hence > > they need to be accessible in an installed file. Placing them in > > rte_pmd-ark.h seems > > like the existing solution. If there is a better location or solution > > for publishing these > > definitions, I have not found it yet. Please advise if I should change > > this in some way. > > > > I slightly remember we had same discussion before. > > Installed public headers are for application usage, but for ark PMD the header > is for the PMD extension development. Currently there is no similar usage or > requirement. The extension is part of the application as it executes in the same space and has access to the same data as the application. The function definitions are required as a sanity check for the application, without them (or with a stale version) we lose that ability. The access to this header file should be part of DPDK's exported interface, without it there is not a standard include location for this file. > > 'rte_pmd-ark.h' seems installed last release because of the public object it had > for dynamic mbuf, which should be accessed by application. Now since those > objects are gone and the content of the header is changed, it is not for > applications anymore, hence I think it shouldn't be installed. > > As far as I can see the PMD extensions are very much related to the FPGA > implementation, so the header is not for everyone to use to develop new code, I > expect whoever needs the 'rte_pmd-ark.h' should have the source code already, > instead of using the header from installed system path. The PMD extensions are the bridge between DPDK and the FPGA details; they are not for everyone. The same argument can be made for the other 12 net drivers which provide PMD public methods. We are attempting to have a standard way to access these prototypes for the installed version of DPDK. > > I think overall it is good to add doxygen comments and dpdk prefix to the > extension symbols, but still they shouldn't be part of the API documentation. > Please consider my arguments and offer an alternative suggestion on how we can provide these prototypes to our users. Thanks, Ed.