From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ed.czeck@atomicrules.com>
Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com
 [209.85.220.175]) by dpdk.org (Postfix) with ESMTP id 4437D47CE
 for <dev@dpdk.org>; Tue, 28 Mar 2017 23:59:22 +0200 (CEST)
Received: by mail-qk0-f175.google.com with SMTP id f11so77957386qkb.0
 for <dev@dpdk.org>; Tue, 28 Mar 2017 14:59:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=atomicrules-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=WAcAZ+jLqVlETYqUdWYIJlyg/ORrnkDRdYHa9Wdlqjw=;
 b=ObXVGgU8Kz1+LGEX6+cRz0Cy6SiQoT6CK+oDxK1a31IASsZBqoIYkKc1CXHcIGlv1p
 tsfq9Ubd18j2UWrwXz4+WeI5pSAKV6xEoeHQx/rrVdrTXMVEsy5GD8LUDoEZfJ17UrZI
 mTBoUZnV3pLL2KUuu5tjO03CcGYXMMRHwuEMJc07xI35HKy5P3/1PJe5RmEKekHCNZuQ
 4A2MGFOO9MDqB85peSqBBMtaK1enCBEueGp0vAc9zh8EUfpu6jrZxECO5g+Oi4BgGDnH
 yHUOfgaukyzDu9xxGaOn+Xh7j+I4Slhu6EKL+WFy5o9W9Uc+4uMsAUIegFdT6BrLnBm1
 ekwQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=WAcAZ+jLqVlETYqUdWYIJlyg/ORrnkDRdYHa9Wdlqjw=;
 b=hPnBNacQNhfzhT5O0U/5pZqJKjcW0SP6o/7u3kTDj3atO7Od3lWZYwck7h4fF0CTO4
 NFoFLZW0LoZr9Rcvm2E/KOLmBUcS553qC/BzrAM1W6P1buGDeEzOFTp99xSFKabNKY97
 XLQc6mWmVblSwbLwJii9cOOoBI2q/5yEGKNECYyOhKRZZKB7WolisSh2O/nyVQMJUxGq
 QQgDq4KGLAguzDrnLkWQmGqLyiFx+pjx8drUS6fYDh2Wo/3gACSt0q5U/7E5onu5CxdP
 yvdr+v2V2K6QJLx6PpgqKXoDrCOZ03gqGetEUaK+D7S59N8BZfV3konSlcW8CKCt50g1
 1Hyw==
X-Gm-Message-State: AFeK/H0fH7ONCIyMfwTrYxaCpEXuEpHaqIWVHcZ42udLcjoLZ7JJqb/C2GpAxo9PGq+e1988+Ct8tYJzgiTE6w==
X-Received: by 10.55.53.136 with SMTP id c130mr8339692qka.107.1490738361545;
 Tue, 28 Mar 2017 14:59:21 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.200.1.131 with HTTP; Tue, 28 Mar 2017 14:59:01 -0700 (PDT)
In-Reply-To: <6ae0faec-be5e-9054-0cc0-fb5300bb2f75@intel.com>
References: <41265c4fa76265df0144d5d480e4553888df2ee8.1490309515.git.ed.czeck@atomicrules.com>
 <8a5f46f851c7be85e09e50d7c94b7709edaf881e.1490309515.git.ed.czeck@atomicrules.com>
 <6ae0faec-be5e-9054-0cc0-fb5300bb2f75@intel.com>
From: Ed Czeck <ed.czeck@atomicrules.com>
Date: Tue, 28 Mar 2017 17:59:01 -0400
Message-ID: <CALZ3Gugr_+GO7WnNQCNjzA8hOz5ohmVQFFChqvQF_4vDb8j=dg@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, John Miller <john.miller@atomicrules.com>, 
 Shepard Siegel <shepard.siegel@atomicrules.com>, 
 Stephen Hemminger <stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v5 6/7] net/ark: Packet RX support initial
	version
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Mar 2017 21:59:22 -0000

On Tue, Mar 28, 2017 at 10:36 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
>
> On 3/23/2017 11:01 PM, Ed Czeck wrote:
> > * Core RX packet moving functions
> >
> > Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
>
> <...>
>
> > +/* TODO  pick a better function name */
>
> Is it possible to do now :) Thanks.
>
Done.

>
>
> > +
> > +/* Only used in debug */
> > +static void
> > +dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi)
> > +{
>
> There is already a rte_pktmbuf_dump(), does it works for you?

The  rte_pktmbuf_dump() function dumps data based on the data_off field. My
use here is to examine data in the headroom of an mbuf.    A comment was
added before this function to explain the difference.


>
> <...>
>
> > +/* Forward declarations */
> > +struct rte_mbuf;
> > +struct rte_mempool;
> > +struct rte_eth_dev;
> > +struct rte_eth_stats;
> > +struct rte_eth_rxconf;
>
> Same comment with Tx patch, these structs can be removed by including
> proper dpdk headers.

Done

Thanks
Ed.