From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61EB4A0567; Wed, 10 Mar 2021 16:11:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51B1722A2E4; Wed, 10 Mar 2021 16:11:35 +0100 (CET) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id 434D14069F for ; Wed, 10 Mar 2021 16:11:34 +0100 (CET) Received: by mail-lf1-f44.google.com with SMTP id n16so34066275lfb.4 for ; Wed, 10 Mar 2021 07:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jlw03S1t5QlgEzuPXEqtAceHr38tbh/1TGwzHJJSq5k=; b=AfAtiSmf2SzE7ir1gkAycE41osAGfWfxHeIOlMhMXQKIjLwKwvRCU1Zbu00zTlvT2a jFqzHLJYepQUEfFYYmb/pTDFDf/xzkClF9cJoH4KpwkwqVunoXjSbbWmhmI5Ts17Ze0x SZwX+HyTDFvUVfFGeKShS2AMqQsa6nKu29ZfHt/FB+PcMOpNg9BPnH3t7U9dUK/Y107Q 5M3eV7h+nHDzqfLHfLMokcziUf4ZC/pCX4FOFIPtD1k0hITpJzpLp7i11sARV/TAtOrF gtBKC3jRhE3Wi7jmOhKxpx6OCSlTddbNezZi2TAU6PzHypQpWihjmcL7R58UnniehABj K00g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jlw03S1t5QlgEzuPXEqtAceHr38tbh/1TGwzHJJSq5k=; b=roFoch/qur/VN2v8AjOoeYaojrfpUsMF4rk8o2vOuKP7kTv6M3npGX2a/8Wv2tQtFK 4fHbeKsu6ZDDNy47Xdov5sZrkdaqA+KZPDJk40F89lNp/s89FV+4a8WuHuG7D2p/popX feXCmqWNNqEIubf8HX4mojKibl/zhNCva4jUv2esPoyKUVvWOEMvWEOi5OCB6ciPNv1A 8YKUjoIji5Dkqz/RC2rOcDEFO1VQMIQtgzkOCjZacV/VF5oP1pxZleJLC78YaTBCCw6L E6r5+0XMGDsGB6BKxDPb/UEfr2kXVkkDZwyPNaXJFmg9dgFdJp3gZ10QPvTej6qVZs6/ Nk1w== X-Gm-Message-State: AOAM53101UtK82wck8c7CjhnxAiQO5+Gg3B50HV556YnTeccfZC3Iq1A TOSNzvh90CkD2c1kSBenTqiniJzf0jOLBeqbfAPLrQ== X-Google-Smtp-Source: ABdhPJy/YPzFr4mcv7lgOBxX5IJ1Is9Z+0NBv1mbofLY/+QJTlOzArvi/oZ1tVYgZH5OwbL2kB1M9QzhPoktb8cmpmY= X-Received: by 2002:ac2:51a4:: with SMTP id f4mr2222219lfk.411.1615389093899; Wed, 10 Mar 2021 07:11:33 -0800 (PST) MIME-Version: 1.0 References: <20210304165637.24658-1-ed.czeck@atomicrules.com> <20210309160818.3553-1-ed.czeck@atomicrules.com> <20210309160818.3553-4-ed.czeck@atomicrules.com> <415aa498-d3bd-ca76-77d1-c98816a6f34c@intel.com> In-Reply-To: <415aa498-d3bd-ca76-77d1-c98816a6f34c@intel.com> From: Ed Czeck Date: Wed, 10 Mar 2021 10:11:23 -0500 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Shepard Siegel , John Miller Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 4/6] net/ark: cleanup ark dynamic extension interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 9, 2021 at 12:50 PM Ferruh Yigit wrote: > > On 3/9/2021 4:08 PM, Ed Czeck wrote: > > - Rename extension functions with rte_pmd_ark prefix > > - Move extension prototype to rte_pmd_ark.h > > - Update local function documentation > > > > Signed-off-by: Ed Czeck > > --- > > v3: > > - split function rename from previous commit > > v4: > > - reorder patches renaming before adding > > <...> > > > diff --git a/drivers/net/ark/rte_pmd_ark.h b/drivers/net/ark/rte_pmd_ark.h > > index 6f26d66b1..0f24a347d 100644 > > --- a/drivers/net/ark/rte_pmd_ark.h > > +++ b/drivers/net/ark/rte_pmd_ark.h > > @@ -1,18 +1,24 @@ > > /* SPDX-License-Identifier: BSD-3-Clause > > - * Copyright (c) 2020 Atomic Rules LLC > > + * Copyright (c) 2020-2021 Atomic Rules LLC > > */ > > > > #ifndef RTE_PMD_ARK_H > > #define RTE_PMD_ARK_H > > > > +#include > > +#include > > + > > +#include > > +struct rte_eth_dev; > > +struct rte_mbuf; > > +struct rte_ether_addr; > > +struct rte_eth_stats; > > + > > Is the declaring structures instead of including header preferred intentionally? > > I guess both works, and it may not differ for the PMD at all, but for the > extension developer that is including this header, it may need to include > required headers again, this header including all required headers and be a self > contained may help extension code, up to you. My experience/style has been to use a declaration rather than a full include to avoid include bloat and speed up compiles. If the extension developer needs the declaration in the header, they can include it as needed. > > Plus just a detail but I guess mbuf struct is redundant for this patch, it can > be added in next patch where mbufs header removed and hooks added. Agreed. Would you like another patch? Thanks Ed.