From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) by dpdk.org (Postfix) with ESMTP id 8EC962BF5 for ; Tue, 11 Apr 2017 17:26:47 +0200 (CEST) Received: by mail-qk0-f175.google.com with SMTP id d131so399640qkc.3 for ; Tue, 11 Apr 2017 08:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WV8Aa94Zdj79Pei+2g1cd+rHr8Ln/k5gfu/uyr8Okeo=; b=X33Ze5EGF5OXbrk0Y/4JLYomY3tHSrBkIhEWu4YcVEVo4tDW8qro1tg5O2JhLm3SZC hi6kUA1LL4Kb0yjL2KaOTXKxjr4wy0bgeVRzvnZ2gZb6EOdURMmfiyw7usAxYpwDkxo+ syUBKOwrCzelw5IiR+h8C/vQ05cZBWyTvxnxpt8dCAqvAGa6lThzeQADVgJMX2+BMDYW 0OU0o/UmTVcWW58wliv7JCAl5X2eqT6CUtZV8IxNztn/Bnwa+aCSEcbyakj3+7ywjNC5 N7l+Ns2rfdUBE4y/VsJ16TVcgkJpfkq3Lb8urX2ZnkJ+/j7/IJRD3eun9JHRsW3v9dVf Qodw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WV8Aa94Zdj79Pei+2g1cd+rHr8Ln/k5gfu/uyr8Okeo=; b=iTOw84DWdSqBGrLkc0xcOHHCn0oVAabiuyjcCXw1G2+oElkhRfQkhNkhfPbf2baT1l kg57nXvtTfzQcKX+gP0GCSFkBDjB/eZQqi0+cQ97+i6UTvM2ct3DMtLOZfzeBFfapvyw 4BpQTsnN1dxfzwW+QDsnjLLM3r2KY3TKlRUANg0YByXDVLDYuEwKj3mcMWBHndDHub6y OJ7MyNzrAU0yZ5Ju6FQ6uKj0juJT+8gAhdCddPbpC3s8Q3SxH9In0vnCh5Xbe6nir72s Fxp5+yQFfriWMHBe0FRl6uW+LoKfC8X3uuWRAf6eZZ75rc4a0xa1rYrZj9SMyU4ziuPB QbUg== X-Gm-Message-State: AN3rC/7UT+oTzNro8cDgoKimptUaHhmIc8dUy8fvEAO4xrHnU4tCxPYPTnzqMqRKsdKexpG+2tBlO7LEqWOeWA== X-Received: by 10.55.159.135 with SMTP id i129mr11081892qke.79.1491924406666; Tue, 11 Apr 2017 08:26:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.1.131 with HTTP; Tue, 11 Apr 2017 08:26:26 -0700 (PDT) In-Reply-To: <5bb8278f-a3b1-01bc-6161-33c73e9731a4@intel.com> References: <1491827199-4853-1-git-send-email-ed.czeck@atomicrules.com> <1491827199-4853-2-git-send-email-ed.czeck@atomicrules.com> <5bb8278f-a3b1-01bc-6161-33c73e9731a4@intel.com> From: Ed Czeck Date: Tue, 11 Apr 2017 11:26:26 -0400 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, John Miller , Shepard Siegel Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] net/ark: report hardware status during PMD init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 15:26:48 -0000 On Mon, Apr 10, 2017 at 11:01 AM, Ferruh Yigit wrote: > On 4/10/2017 1:26 PM, Ed Czeck wrote: > > Expose additional fpga status registers and report > > conditions during PMD init > > > > > + if (ark->sysctrl.t32[3] != 0) { > > + if (ark_rqp_lasped(ark->rqpacing)) > > + PMD_DRV_LOG(INFO, "Arkville Evaluation System - " > > Is this should be "info" level or debug, is end user interested if timer > expired or not? > > These messages are intended for the user. After internal discussion we promoted them to warning and error. > > + "Timer has Expired\n"); > > + else > > + PMD_DRV_LOG(INFO, "Arkville Evaluation System - " > > btw, what is the logic in pmd, when to use PMD_DRV_LOG and when to use > PMD_DEBUG_LOG? The PMD_DRV_LOG macro is a local wrapper on RTE_LOG, while the PMD_DEBUG_LOG macro is a compile-time conditional macro to the same RTE_LOG. The DEBUG_LOG macro is conditionalize on the configuration RTE_LIBRTE_ARK_DEBUG_TRACE. > > + "Timer is Running\n"); > > + } > > + > > > > Extra line. > Removed. Thank you