From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by dpdk.org (Postfix) with ESMTP id 6B0CB14E8 for ; Thu, 23 Mar 2017 22:44:34 +0100 (CET) Received: by mail-qt0-f195.google.com with SMTP id r45so31283978qte.0 for ; Thu, 23 Mar 2017 14:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2f5cR9E6rpDA1JVPKBICrVjVv9mSfFNZb2Ehg625XCc=; b=qGHsJZqPImVEhUeLI/29Up9tM4AkXc+OOFttrcx7EK1d2ZQGCGdUV1gWOW1NOgtt6A CC41+psbf9WfcR44OjFt1K6a7ztIdOqOliV8zNOgkA15hhDZX7SR9+5RX+HYKZFrQOBK i45djZub9BagR//uSUypIzsrX7C8rmNpmXb+ik7bAME1qv7cz2J4xOebO7ERTHuu6cn2 8E6PNuaASG1nz+WCgUyGqvbwqzI4VUu34Wv8hH/rwrLdaAkGdaVlOAgAuASNiwGqjBqN anXmZX7sHjbXREAFke455z2BVXmj09wL9NIvK6XhpE2TM4HengosDNEbZ2n6MlJeIlRk 2DAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2f5cR9E6rpDA1JVPKBICrVjVv9mSfFNZb2Ehg625XCc=; b=Txu+uoH8HEVZp71/2Z+F/nr11i4d3nuPb8GV3jOzmLE3k31wtwL9IpwW3uJc6HOkHM xPstkbgfuge1tPZIMPOl+TAUZ37UZVDbRn3ZigI/MrahBngYsOHE4ApOKEfzJSZ24CZI ih3kMonDKOVeaUhX4nI5mTXiCLYtQTM5YVDPEBSNIK5tRSHzKj17KwmvV0stN0HzBE9C oLbmvUVQLVt6oFIz/FwlSmzyKZ0go8vhUED7Xf4roOdUk5EiDL/jiW6c3Zdmz/S7EKWp tmJ1JFJPGAY22Up3YQjcjw95Y2XXQ4G+kVS1ILUPtiu3+dg3ZiccfyAbAGLmX+LC1wbc 8mgQ== X-Gm-Message-State: AFeK/H0W6TtEqfNLUTzXJCSDk7lm0JwS7/+BQwBcPZqrmfh1bSGqy/rs4/h///drau/xazPDE24l01yOP2owNA== X-Received: by 10.237.62.98 with SMTP id m31mr4884053qtf.71.1490305473289; Thu, 23 Mar 2017 14:44:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.1.131 with HTTP; Thu, 23 Mar 2017 14:44:12 -0700 (PDT) In-Reply-To: <4480ae16-df81-c30e-ef5c-995081fa9338@intel.com> References: <1490231015-31748-1-git-send-email-ed.czeck@atomicrules.com> <1490231015-31748-5-git-send-email-ed.czeck@atomicrules.com> <4480ae16-df81-c30e-ef5c-995081fa9338@intel.com> From: Ed Czeck Date: Thu, 23 Mar 2017 17:44:12 -0400 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 5/7] net/ark: Packet TX support initial version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 21:44:34 -0000 On Thu, Mar 23, 2017 at 8:14 AM, Ferruh Yigit wrote: > > On 3/23/2017 1:03 AM, Ed Czeck wrote: > > Is this function to get dev->data->port_id ? > > "struct ark_adapter" is private date per eth_dev, it is possible to keep > port_id per ark, no need to keep whole array on each ark, if I am now > missing anything ... Code changed to grab port from private data > > Why not using RTE_LIBRTE_ARK_PAD_TX directly, but creating another macro? This macro is either defined as 1 or nothing. We are changing from these states to 1 or 0. Is there a preferred style or example that we should study? > > Is it possible to handle RTE_LIBRTE_ARK_DEBUG_TX in log.h file to create > a ..LOG_TX macro and use it, instead of dealing here with new macros? We are reviewing the use of debug and macro internally. Is there a preferred style or example that we should study? > > +/* Forward declarations */ > > +struct rte_mbuf; > > +struct rte_eth_dev; > > +struct rte_eth_stats; > > +struct rte_eth_txconf; > > Why not include relevant headers, instead of these struct declarations. The use of bare declaration is all that is needed, since the header only uses pointers to these structs, and the full include is not needed. Full header included were added.