From: Ed Czeck <ed.czeck@atomicrules.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Shepard Siegel <shepard.siegel@atomicrules.com>,
John Miller <john.miller@atomicrules.com>
Subject: Re: [dpdk-dev] [PATCH 3/8] net/ark: remove use of seqn for debug
Date: Wed, 28 Oct 2020 08:19:43 -0400 [thread overview]
Message-ID: <CALZ3GuiBhg7nVzfEDCz_GyMEPtkAtNe8=wtm+hWyVXUzRESW=Q@mail.gmail.com> (raw)
In-Reply-To: <20201027221343.28551-4-david.marchand@redhat.com>
Thank you
Acked-by: Ed Czeck <ed.czeck@atomicrules.com>
On Tue, Oct 27, 2020 at 6:13 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> The seqn mbuf field is deprecated.
> It is currently hacked for debug purpose, it could be changed to a
> dynamic field but I see little value in the debug info it offers.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/ark/ark_ethdev_rx.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c
> index c5788498b3..cc0881b77c 100644
> --- a/drivers/net/ark/ark_ethdev_rx.c
> +++ b/drivers/net/ark/ark_ethdev_rx.c
> @@ -302,8 +302,6 @@ eth_ark_recv_pkts(void *rx_queue,
> mbuf->pkt_len = 63;
> meta->pkt_len = 63;
> }
> - /* seqn is only set under debug */
> - mbuf->seqn = cons_index;
> }
>
> if (unlikely(meta->pkt_len > ARK_RX_MAX_NOCHAIN))
> @@ -360,8 +358,6 @@ eth_ark_rx_jumbo(struct ark_rx_queue *queue,
> mbuf_prev = mbuf;
> mbuf->data_len = data_len;
> mbuf->data_off = 0;
> - if (ARK_DEBUG_CORE)
> - mbuf->seqn = cons_index; /* for debug only */
>
> cons_index += 1;
> }
> @@ -667,8 +663,8 @@ dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi)
> {
> uint16_t i, j;
>
> - ARK_PMD_LOG(DEBUG, " MBUF: %p len %d, off: %d, seq: %" PRIU32 "\n",
> - mbuf, mbuf->pkt_len, mbuf->data_off, mbuf->seqn);
> + ARK_PMD_LOG(DEBUG, " MBUF: %p len %d, off: %d\n",
> + mbuf, mbuf->pkt_len, mbuf->data_off);
> for (i = lo; i < hi; i += 16) {
> uint8_t *dp = RTE_PTR_ADD(mbuf->buf_addr, i);
>
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-10-28 12:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 22:13 [dpdk-dev] [PATCH 0/8] remove mbuf seqn David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 1/8] event/dpaa2: remove dead code David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 2/8] crypto/scheduler: remove unused internal seqn David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 3/8] net/ark: remove use of seqn for debug David Marchand
2020-10-28 12:19 ` Ed Czeck [this message]
2020-10-27 22:13 ` [dpdk-dev] [PATCH 4/8] reorder: switch sequence number to dynamic mbuf field David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 5/8] dpaa: switch sequence number to dynamic field David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 6/8] fslmc: " David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 7/8] event: " David Marchand
2020-10-27 22:18 ` David Marchand
2020-10-28 7:27 ` Jerin Jacob
2020-10-28 8:55 ` David Marchand
2020-10-28 9:09 ` Jerin Jacob
2020-10-27 22:13 ` [dpdk-dev] [PATCH 8/8] mbuf: remove seqn field David Marchand
2020-10-28 10:27 ` Andrew Rybchenko
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 0/9] remove mbuf seqn David Marchand
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 1/9] event/dpaa2: remove dead code David Marchand
2020-10-31 18:28 ` Nipun Gupta
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 2/9] crypto/scheduler: remove unused internal seqn David Marchand
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 3/9] net/ark: remove use of seqn for debug David Marchand
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 4/9] reorder: switch sequence number to dynamic mbuf field David Marchand
2020-10-28 12:54 ` Andrew Rybchenko
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 5/9] dpaa: " David Marchand
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 6/9] fslmc: " David Marchand
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 7/9] eventdev: " David Marchand
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 8/9] app/eventdev: " David Marchand
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 9/9] mbuf: remove seqn field David Marchand
2020-10-31 21:09 ` Thomas Monjalon
2020-10-31 21:11 ` [dpdk-dev] [PATCH v2 0/9] remove mbuf seqn Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALZ3GuiBhg7nVzfEDCz_GyMEPtkAtNe8=wtm+hWyVXUzRESW=Q@mail.gmail.com' \
--to=ed.czeck@atomicrules.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.miller@atomicrules.com \
--cc=shepard.siegel@atomicrules.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).