From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13693A04DD; Wed, 28 Oct 2020 13:19:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76DCCCA0C; Wed, 28 Oct 2020 13:19:56 +0100 (CET) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id D1EFBC9FC for ; Wed, 28 Oct 2020 13:19:55 +0100 (CET) Received: by mail-lj1-f193.google.com with SMTP id y16so6031414ljk.1 for ; Wed, 28 Oct 2020 05:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A3W/IvLeItMlozoAOFdQkz9dZkRljTKfZcvZ2qqN8pI=; b=qt/yT69s544zfrsUxcByY1YjlZCDzDQndKQRdO8zJZSwImTiN4oG6Hv+ChfqAJzFbx KjY1hVqgUN3K0kOZexpiJVe0bxq/LZHJqGTFmK4RiYlkAvDXELBcbTgQnOg8LaHecLpi lLiJ3xIQ7tSurCg1SsLrYb2Det0Dj74dBi/NwG3EdAErI+yuBPVyi/2/Eh5ZLZLVVH16 b+fuHiHTBG9ql8HpVg2vCHwmo2Tmrc+yLC/x+9Vb29GTBAgMSvCAsqQq0y0HSRCkLi6b rJD4nW78BcVerhIhu8DmaIN/OYLBSMN6xxOYmEx4xf4nzP3Bz5G9ncpcYj/zl/dT4AzA d94A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A3W/IvLeItMlozoAOFdQkz9dZkRljTKfZcvZ2qqN8pI=; b=Wxsx3qIlLMcdo4snhT6SJMp6oLgvze9nk6P8UXJ4AvJkF6m2ZHyleW6WaElzBMTDju J6Q7qTQS7enhoEl89DYX9i2Y2L7WBEWk6S7A97ncMhy6NWxMLIPvuHCt3A7goWUgcn4V CoWAZHAjn1eWeam3ZSGs/1yg6eaBIt/ShsX2czw8syxx8vCrUMmKJlSaFYWCTzJXqMY6 HLKZ4W0hL15MSThWNMFZp5PD/fYKrS+mznn4JX5THEUKEy4lIt39IZm6TuX4Q6miIIrF CKjTxt3z5B1jvXT52b6zQau0r8Rmk9H+vEU5XIL/lNcsNlE9szPdscBU/8OGJAr6XY+m dz5A== X-Gm-Message-State: AOAM533zHUkNXBrpA+ET/rreLCb/OpdwOaFFV33Dud9P5r0+JmJNIi5W DZihKkNKYWw8jznF0qNxDrIqiowPmHKUiLeHO6+PXA== X-Google-Smtp-Source: ABdhPJwZiJF5u1Jw3r/aKntmOvedyNMi4un7K6PeexYv6uvsFPt4q6LSnSV1+CAl0GqMS+30j67/xie11Qd28UKFX0A= X-Received: by 2002:a2e:b531:: with SMTP id z17mr3330794ljm.28.1603887594317; Wed, 28 Oct 2020 05:19:54 -0700 (PDT) MIME-Version: 1.0 References: <20201027221343.28551-1-david.marchand@redhat.com> <20201027221343.28551-4-david.marchand@redhat.com> In-Reply-To: <20201027221343.28551-4-david.marchand@redhat.com> From: Ed Czeck Date: Wed, 28 Oct 2020 08:19:43 -0400 Message-ID: To: David Marchand Cc: dev@dpdk.org, Shepard Siegel , John Miller Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/8] net/ark: remove use of seqn for debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thank you Acked-by: Ed Czeck On Tue, Oct 27, 2020 at 6:13 PM David Marchand wrote: > > The seqn mbuf field is deprecated. > It is currently hacked for debug purpose, it could be changed to a > dynamic field but I see little value in the debug info it offers. > > Signed-off-by: David Marchand > --- > drivers/net/ark/ark_ethdev_rx.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c > index c5788498b3..cc0881b77c 100644 > --- a/drivers/net/ark/ark_ethdev_rx.c > +++ b/drivers/net/ark/ark_ethdev_rx.c > @@ -302,8 +302,6 @@ eth_ark_recv_pkts(void *rx_queue, > mbuf->pkt_len = 63; > meta->pkt_len = 63; > } > - /* seqn is only set under debug */ > - mbuf->seqn = cons_index; > } > > if (unlikely(meta->pkt_len > ARK_RX_MAX_NOCHAIN)) > @@ -360,8 +358,6 @@ eth_ark_rx_jumbo(struct ark_rx_queue *queue, > mbuf_prev = mbuf; > mbuf->data_len = data_len; > mbuf->data_off = 0; > - if (ARK_DEBUG_CORE) > - mbuf->seqn = cons_index; /* for debug only */ > > cons_index += 1; > } > @@ -667,8 +663,8 @@ dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi) > { > uint16_t i, j; > > - ARK_PMD_LOG(DEBUG, " MBUF: %p len %d, off: %d, seq: %" PRIU32 "\n", > - mbuf, mbuf->pkt_len, mbuf->data_off, mbuf->seqn); > + ARK_PMD_LOG(DEBUG, " MBUF: %p len %d, off: %d\n", > + mbuf, mbuf->pkt_len, mbuf->data_off); > for (i = lo; i < hi; i += 16) { > uint8_t *dp = RTE_PTR_ADD(mbuf->buf_addr, i); > > -- > 2.23.0 >