From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13133A09E5; Mon, 7 Dec 2020 17:36:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E6A6E07; Mon, 7 Dec 2020 17:36:14 +0100 (CET) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id 41D5CCF3 for ; Mon, 7 Dec 2020 17:36:12 +0100 (CET) Received: by mail-lf1-f68.google.com with SMTP id u19so19005808lfr.7 for ; Mon, 07 Dec 2020 08:36:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=99oww0GZtgxNf/BaalMjQl7Bm/alK71Go3ScIIm9hp8=; b=GihBerl5wLx4D804uVXR43Lsm2jXTlCBlqJpjMt/l+4FT2mOydYbhmYCiY4ERE3YzC CyFTY4kt3AAaidJvV2QmyZTWoaNGrP1BsANdG4e8I/szNYa9qwqSeXRlijF1kgQ/XlKj t4Ey02zJCJwS/6QEav+ipRIHgJVAwP25nfLjG2NLzCs2MrLPz3bKTVKBP8NlxHjrig32 tMI0fEaver+NrXISgodn13VO3svkZr406flSzL4mZl8Ok32rTtbwk7DkxJ1w6ykTZdS2 zQbO7HALXgfKVSStfkK0zWiZw2oeMYZosdZMvf53Q1D8OFCZU6EPlMLhlKWgzNY1FRlc cLpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=99oww0GZtgxNf/BaalMjQl7Bm/alK71Go3ScIIm9hp8=; b=pg6rzbsq4uZxFJXeUFrmB9asTDNEjj0gf/I7XBxc2lCC9CTJ1sgyP8+kSAGge9rKdQ Ttn6Q7L8S1VGUSVOwXMSFpManYQdv94ZBG68UtgiL9fVoy3Z8npFWmZGoalFGYK9O9+4 4Ge4PqT8NjdIwptNyDT//urElpPOeyJ5C95R6wJ7B07tFoLiqhXUk48vzLH43Augl+W4 0KCSVisNxGdkejPunF9o8N7Jy07hSXuzD26xeOEVr3IHla0NTixt2z8NaNKUyGBzRUGH GBhpwAuoZO1oDDm7tnrU9SuiXrng53ZTIrIUB0eSoXqI9/BM9N7FS9EGVUsYe0H0Jmcb BNtw== X-Gm-Message-State: AOAM531RLy8SFA4kjzShW3QgG43zOZ8zsG5krFScbW/9qYDIhvZn1IrG xFqgp+U/jyPLaKOiVJXA1P3Aie4lgIOQKw5gr2Dsfw== X-Google-Smtp-Source: ABdhPJwFv7gfdxcf9acqSCqgZd6tmfxppQSGQ6Bf4CBKeqs0IrvR8M20gvRSNK/931Hn8uHpH6XpTuBbL2s2MQxYIrs= X-Received: by 2002:a05:6512:5d6:: with SMTP id o22mr9284855lfo.574.1607358971693; Mon, 07 Dec 2020 08:36:11 -0800 (PST) MIME-Version: 1.0 References: <20201204202745.24675-1-ed.czeck@atomicrules.com> <20201204143120.5c488d36@hermes.local> <2820958.vaCdlQsBOK@thomas> In-Reply-To: <2820958.vaCdlQsBOK@thomas> From: Ed Czeck Date: Mon, 7 Dec 2020 11:35:57 -0500 Message-ID: To: Thomas Monjalon Cc: Stephen Hemminger , dev@dpdk.org, Ferruh Yigit , Shepard Siegel , John Miller , Olivier MATZ Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ark: export ark timestamp dynfield offset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Dec 6, 2020 at 10:53 AM Thomas Monjalon wrote: > > 04/12/2020 23:31, Stephen Hemminger: > > On Fri, 4 Dec 2020 15:27:45 -0500 > > Ed Czeck wrote: > > > > > Access to mbuf dynfields in application code requires variable > > > export through header and dynamic library. > > > > > > Fixes: a926951a606f ("net/ark: switch Rx timestamp to dynamic mbuf field") > > > Cc: thomas@monjalon.net > > > > > > Signed-off-by: Ed Czeck > > > > Not happy with having offsets exposed from driver. > > > > Expopsing weird offsets for their special fields > > is worse than the old model. > > > > Why not use standardized field name and have the application lookup that? > > There is an API already for that. > > Yes lookup should be used. > > So we lookup and may a copy of that offset in application code -- no changes to PMD are then required. Got it, thanks for your comments.