From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 214D5A04B6; Mon, 24 Aug 2020 23:40:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB96C1C07B; Mon, 24 Aug 2020 23:40:33 +0200 (CEST) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 6FF011C00D for ; Mon, 24 Aug 2020 23:40:32 +0200 (CEST) Received: by mail-lj1-f195.google.com with SMTP id v9so11419561ljk.6 for ; Mon, 24 Aug 2020 14:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=smpg612UGiWj++V/16p2zU5J1swmmV5mKTDrp+yHfrU=; b=Ynh3awqlSKOBLMVLTsJkSeS5fO/9LplvXNJb8+zDENdtFdzQkbzV0vrZQZxXcyVMXS YbtrhT+mIMUibXdnK1IWqSlnBwO8T1ZeXDG6PIRsQLdSCIl9aKQgXOP6n97h0cKS6Q6I LBerKQajuo40V32Lo33R/FBL6uRG0oo+yF462aEig0tpx3LdtrrhtjHCNuAgFwcBZKFV JhlAMFgzvGIgfJfBLrkVSV+Yi/ot0IY8CJtp/QGnh43ctwDlyRv2nmPQMMKr4zREG9N8 pTyDMuTxyDtHTcyVPk72nghT5rnhrd2w2JUZlb/zFswyAdnkP+nzDWvOk8tBBTD1sjn/ GTgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=smpg612UGiWj++V/16p2zU5J1swmmV5mKTDrp+yHfrU=; b=XIKPwkY3vS49vwiHvXeyGdg4gw0o+Ds/AixPXHGPSYgXo6kdIu37BB8Za+mWQqtf3I nUKVQZu75CYY19lQZEG6WXKFC34zk0Eolb4M3Wn7KYxvu1r3cANluH2JiPgG4JVEY9M8 z5HTSzvETaY/U/jfAR+sadkkxGLGeSi0BAJyJbpHaOWqJGEom4jN5rXDt1aZcBPrcIK2 BWW747oTc3v0E3uV+cIqsP3le9ZTyEiBx+uSXQ1diTWQ3nfGObRc79GVnJGyi4ghac5B gMfL1AEdmar/KSlVeiGVufoneC43ViQ8CDNLvVI5Ov97F4Rn8+7pdWDTmSCn0FA18Hl1 aKDg== X-Gm-Message-State: AOAM532MNsDQmiI9O3WPSN0qtxtA3lp0DdK3CSJGleI+7joty9nddZR2 llQWOZt4MntCh+x5HwhDi7O0v5KcVtR314Tlhp56OA== X-Google-Smtp-Source: ABdhPJy6Ue/tySfJ1QAXLMP66PYttoC7qoqy5Q0JfbjNY07Z98DEUTdoD2cswSVNn+KamsOo/jG2H/p+Wlo8PVOkJ8Q= X-Received: by 2002:a2e:9811:: with SMTP id a17mr3082233ljj.21.1598305231816; Mon, 24 Aug 2020 14:40:31 -0700 (PDT) MIME-Version: 1.0 References: <20200819153539.32698-1-ed.czeck@atomicrules.com> <20200824133641.19450-1-ed.czeck@atomicrules.com> <20200824144045.GA547@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: Ed Czeck Date: Mon, 24 Aug 2020 17:40:20 -0400 Message-ID: To: Ferruh Yigit Cc: Bruce Richardson , dev@dpdk.org, Shepard Siegel , John Miller Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 24, 2020 at 11:09 AM Ferruh Yigit wrote: > > On 8/24/2020 3:40 PM, Bruce Richardson wrote: > > On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote: > >> On 8/24/2020 2:36 PM, Ed Czeck wrote: > >>> Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG, > >>> PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG. > >>> Review and adjust log levels and messages as needed. > >>> > >>> Signed-off-by: Ed Czeck > >>> --- > >>> doc/guides/nics/ark.rst | 13 ------ > >>> drivers/net/ark/ark_ddm.c | 12 ++--- > >>> drivers/net/ark/ark_ethdev.c | 77 +++++++++++++++------------------ > >>> drivers/net/ark/ark_ethdev_rx.c | 46 ++++++++++---------- > >>> drivers/net/ark/ark_ethdev_tx.c | 10 ++--- > >>> drivers/net/ark/ark_logs.h | 63 +++------------------------ > >>> drivers/net/ark/ark_mpu.c | 32 ++++---------- > >>> drivers/net/ark/ark_pktchkr.c | 36 +++++++-------- > >>> drivers/net/ark/ark_pktdir.c | 2 +- > >>> drivers/net/ark/ark_pktgen.c | 22 +++++----- > >>> drivers/net/ark/ark_rqp.c | 4 +- > >>> drivers/net/ark/ark_udm.c | 18 ++++---- > >>> 12 files changed, 125 insertions(+), 210 deletions(-) > >>> > >>> diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst > >>> index 06e8c3374..c3ffcbbc2 100644 > >>> --- a/doc/guides/nics/ark.rst > >>> +++ b/doc/guides/nics/ark.rst > >>> @@ -132,19 +132,6 @@ Configuration Information > >>> * **CONFIG_RTE_LIBRTE_ARK_PAD_TX** (default y): When enabled TX > >>> packets are padded to 60 bytes to support downstream MACS. > >>> > >>> - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_RX** (default n): Enables or disables debug > >>> - logging and internal checking of RX ingress logic within the ARK PMD driver. > >>> - > >>> - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TX** (default n): Enables or disables debug > >>> - logging and internal checking of TX egress logic within the ARK PMD driver. > >>> - > >>> - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS** (default n): Enables or disables debug > >>> - logging of detailed packet and performance statistics gathered in > >>> - the PMD and FPGA. > >>> - > >>> - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE** (default n): Enables or disables debug > >>> - logging of detailed PMD events and status. > >>> - > >> > >> Can you please remove these config option from 'config/common_base'? > >> > > Given that the file is scheduled for deletion fairly soon, not sure if that > > is worthwhile doing. > > > > Since there is possible new version already because of comment in 2/2, I think > better to update 'config/common_base' for the sake of completeness. > > But if there won't be a new version, this can be skipped pragmatically. I will avoid the update of config/common_base as changes there will cause merge conflict.