Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD

[Ed Czeck <ed.czeck@atomicrules.com>]

On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 3/9/2021 4:08 PM, Ed Czeck wrote:
> > In this commit we generalize the movement of user-specified
> > meta data between mbufs and FPGA AXIS tuser fields using
> > user-defined hook functions.
> >
> > - Previous use of PMD dynfields are removed
> > - Hook function added to ark_user_ext
> > - Add hook function calls in Rx and Tx paths
> > - Update guide with example of hook function use
> > - Add release notes
> >
> > Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
> > ---
> > v3:
> > - split function rename to separate commit
> >
> > v4:
> > - reorder patches renaming before adding
>
> <...>
>
> > diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map
> > index 954bea679..4a76d1d52 100644
> > --- a/drivers/net/ark/version.map
> > +++ b/drivers/net/ark/version.map
> > @@ -1,10 +1,3 @@
> >   DPDK_21 {
> >       local: *;
> >   };
> > -
> > -EXPERIMENTAL {
> > -     global:
> > -
> > -     rte_pmd_ark_tx_userdata_dynfield_offset;
> > -     rte_pmd_ark_rx_userdata_dynfield_offset;
> > -};
> >
>
> Since there is no more public APIs by driver, I think it should stop installing
> the header, and remove it from 'meson.build' file, and remove the header from
> API documentation, 'doc/api/doxy-api-index.md'.
>
> I can see the header needs to be used by the extension developer, but that is
> still kind of PMD, the public headers are installed for the application developers.
>
> Still there is a desire to install the required headers for PMD developers, as
> far as I know Bruce is working on it, cc'ed. This header can be installed as
> part of that effort.
>
> Thanks,
> ferruh

The function prototypes in the header are required by the extension
developer, hence
they need to be accessible in an installed file. Placing them in
rte_pmd-ark.h seems
like the existing solution. If there is a better location or solution
for publishing these
definitions, I have not found it yet. Please advise if I should change
this in some way.

Ed.