From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50E56A0567; Wed, 10 Mar 2021 16:02:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B853940F35; Wed, 10 Mar 2021 16:02:53 +0100 (CET) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id 63F504069F for ; Wed, 10 Mar 2021 16:02:52 +0100 (CET) Received: by mail-lf1-f50.google.com with SMTP id 18so33956324lff.6 for ; Wed, 10 Mar 2021 07:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R1TQz5+Qs55/E0Quz17Z/1RdKt5B5gbTo6ADd7WmIhA=; b=V2ZZzPyYhUD4or3MFxqDniBaP4nqnu869CzkgNoYuzycZ45BHL5jfqtWd783aPZ834 ysq2kkIwA2LIiztukl6NjI5e59uFRD7KdbOkBJGJIMUl+NSjsy3CdHxG4sm/hL9Rgis5 zeng76PLwfnGU+RmF3BM5jtjTpDl7TO6Gwkqc9KFuKnpr8dHOrm5IYLeDOTWOuCwN3hZ LX9sqfz9OvCaVISOT+8GCKwEoFrhHXDRLlbh8HEGK+9gHv2VtQaVT4W6TtpjGgns/fPb 1X8mtQoIjuu32AKYX/0iamWJBg92lwVjSiBkMmtGM9byXNaTb+imPq9Izfj0Vg1w+w2Q tqMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R1TQz5+Qs55/E0Quz17Z/1RdKt5B5gbTo6ADd7WmIhA=; b=B1qdslZZhzqwRx9lJMjUZGV8geVy/1E6ThUzmOst7kClxgdn4JvIxnfGfZhsUzgWyE PRSoMSOKHPrB2UBSacxS1OSg41fHTyTomYCCjg5SBGUxQmeM5ScqLG79RP5LrhQhscHR CZDokdz8m+skTjJjpV3qiB/9vpIdEgdBbX2lv/IL60x07vlug9FAqwqn1xMSD+BHFVCo fjAAWZlLbhhz+VFmH43HozzDq9CulQaF/fc6ZG/9fehpCxhYhC5Zil9L3zzNjLu9VVjA OQYHi4vEAlqVTsAfRjy4S9mpsTCW9ZhgadGEt2suQMz4nP9MgvDDWkmHuHojdhafGn7Y 5sKw== X-Gm-Message-State: AOAM532llQlhQ6h15iBSLuF0jo8BT9CYesLC3X9ipaNlZQx0+3hxiZzt QrQMs0e6S5pBWm0WnXAjDjSZCwwKm3hA/wDmyUhA3w== X-Google-Smtp-Source: ABdhPJxqFmQXKDAgkLG+A1mq6KDoYSj4hLqbtO/jzu82ZhFIxl9f81+Prwy+sEiOY8M+58g1CBUj0leqlW0FpNHSPu8= X-Received: by 2002:ac2:51a4:: with SMTP id f4mr2191925lfk.411.1615388570333; Wed, 10 Mar 2021 07:02:50 -0800 (PST) MIME-Version: 1.0 References: <20210304165637.24658-1-ed.czeck@atomicrules.com> <20210309160818.3553-1-ed.czeck@atomicrules.com> <20210309160818.3553-5-ed.czeck@atomicrules.com> <3f558b98-66d1-ce63-9ee0-90364cd51146@intel.com> In-Reply-To: <3f558b98-66d1-ce63-9ee0-90364cd51146@intel.com> From: Ed Czeck Date: Wed, 10 Mar 2021 10:02:39 -0500 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Shepard Siegel , John Miller , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 5/6] net/ark: generalize meta data between FPGA and PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 9, 2021 at 12:36 PM Ferruh Yigit wrote: > > On 3/9/2021 4:08 PM, Ed Czeck wrote: > > In this commit we generalize the movement of user-specified > > meta data between mbufs and FPGA AXIS tuser fields using > > user-defined hook functions. > > > > - Previous use of PMD dynfields are removed > > - Hook function added to ark_user_ext > > - Add hook function calls in Rx and Tx paths > > - Update guide with example of hook function use > > - Add release notes > > > > Signed-off-by: Ed Czeck > > --- > > v3: > > - split function rename to separate commit > > > > v4: > > - reorder patches renaming before adding > > <...> > > > diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map > > index 954bea679..4a76d1d52 100644 > > --- a/drivers/net/ark/version.map > > +++ b/drivers/net/ark/version.map > > @@ -1,10 +1,3 @@ > > DPDK_21 { > > local: *; > > }; > > - > > -EXPERIMENTAL { > > - global: > > - > > - rte_pmd_ark_tx_userdata_dynfield_offset; > > - rte_pmd_ark_rx_userdata_dynfield_offset; > > -}; > > > > Since there is no more public APIs by driver, I think it should stop installing > the header, and remove it from 'meson.build' file, and remove the header from > API documentation, 'doc/api/doxy-api-index.md'. > > I can see the header needs to be used by the extension developer, but that is > still kind of PMD, the public headers are installed for the application developers. > > Still there is a desire to install the required headers for PMD developers, as > far as I know Bruce is working on it, cc'ed. This header can be installed as > part of that effort. > > Thanks, > ferruh The function prototypes in the header are required by the extension developer, hence they need to be accessible in an installed file. Placing them in rte_pmd-ark.h seems like the existing solution. If there is a better location or solution for publishing these definitions, I have not found it yet. Please advise if I should change this in some way. Ed.