DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ed Czeck <ed.czeck@atomicrules.com>
To: Chenbo Xia <chenbo.xia@intel.com>
Cc: dev@dpdk.org, Shepard Siegel <shepard.siegel@atomicrules.com>,
	 John Miller <john.miller@atomicrules.com>,
	ajit.khaparde@broadcom.com,  somnath.kotur@broadcom.com,
	qiming.yang@intel.com, qi.z.zhang@intel.com,  rmody@marvell.com,
	shshaikh@marvell.com, sbhosle@broadcom.com,
	 kishore.padmanabha@broadcom.com, michael.baucom@broadcom.com,
	 venkatkumar.duvvuru@broadcom.com, xiaoyun.li@intel.com,
	 Ferruh Yigit <ferruh.yigit@intel.com>,
	jingjing.wu@intel.com, irusskikh@marvell.com,
	 wenzhuo.lu@intel.com, beilei.xing@intel.com,
	bernard.iremonger@intel.com,  nikhil.rao@intel.com,
	konstantin.ananyev@intel.com,  jerin.jacob@caviumnetworks.com,
	marko.kovacevic@intel.com, orika@nvidia.com,  "Richardson,
	Bruce" <bruce.richardson@intel.com>,
	radu.nicolau@intel.com, akhil.goyal@nxp.com,
	 tomasz.kantecki@intel.com, skori@marvell.com,
	pbhagavatula@marvell.com,
	 John McNamara <john.mcnamara@intel.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] net: fix variable size of ethdev port id
Date: Tue, 29 Sep 2020 14:51:07 -0400
Message-ID: <CALZ3GujAzNS442zO0i3tydbQcDqTeOWnoEmyXyzc7eFFXhpzjw@mail.gmail.com> (raw)
In-Reply-To: <20200925053702.80367-1-chenbo.xia@intel.com>

On Fri, Sep 25, 2020 at 1:41 AM Chenbo Xia <chenbo.xia@intel.com> wrote:
>
> The ethdev port id should be 16 bits now. This patch changes the
> variable size of port id in some net drivers from 8 bits to 16
> bits.
>
> Fixes: cf18d4def295 ("net/ark: provide API for hardware modules UDM and DDM")
> Fixes: 09b23f8b9df6 ("net/bnxt: fix port stop process and cleanup resources")
> Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy")
> Fixes: 50370662b727 ("net/ice: support device and queue ops")
> Fixes: a50d7cbbdad7 ("net/qede: support registers dump")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
>  drivers/net/ark/ark_udm.h               | 2 +-
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.c      | 2 +-
>  drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 6 +++---
>  drivers/net/ice/ice_rxtx.h              | 4 ++--
>  drivers/net/qede/base/bcm_osal.h        | 2 +-
>  drivers/net/qede/qede_regs.c            | 2 +-
>  6 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ark/ark_udm.h b/drivers/net/ark/ark_udm.h
> index 5846c825b..32eb82faa 100644
> --- a/drivers/net/ark/ark_udm.h
> +++ b/drivers/net/ark/ark_udm.h
> @@ -19,7 +19,7 @@
>  struct ark_rx_meta {
>         uint64_t timestamp;
>         uint64_t user_data;
> -       uint8_t port;
> +       uint16_t port;
>         uint8_t dst_queue;
>         uint16_t pkt_len;
>  };

NACK - this struct correlates with an identical structure in the
hardware module.  The C-level cannot be changed without a hardware
update.  For the net/ark driver we will be content with 8-bit port
ids.
Ed.

  parent reply	other threads:[~2020-09-29 18:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 17:41 [dpdk-dev] [PATCH] net/bnxt: fix variable size of " Chenbo Xia
2020-08-04 16:22 ` Stephen Hemminger
2020-08-05 20:18 ` Thomas Monjalon
2020-08-06  2:03   ` Xia, Chenbo
2020-08-06  7:57     ` Thomas Monjalon
2020-09-03  6:49 ` Xiao, QimaiX
2020-09-25  5:37 ` [dpdk-dev] [PATCH v2 1/3] net: fix variable size of ethdev " Chenbo Xia
2020-09-25  5:37   ` [dpdk-dev] [PATCH v2 2/3] app: " Chenbo Xia
2020-09-25  5:37   ` [dpdk-dev] [PATCH v2 3/3] doc: " Chenbo Xia
2020-09-29 18:51   ` Ed Czeck [this message]
2020-09-30  4:23   ` [dpdk-dev] [PATCH v3 1/3] net: " Chenbo Xia
2020-09-30  4:23     ` [dpdk-dev] [PATCH v3 2/3] app: " Chenbo Xia
2020-09-30  4:23     ` [dpdk-dev] [PATCH v3 3/3] doc: " Chenbo Xia
2020-09-30 13:40     ` [dpdk-dev] [PATCH v3 1/3] net: " Ajit Khaparde
2020-09-30 17:13     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALZ3GujAzNS442zO0i3tydbQcDqTeOWnoEmyXyzc7eFFXhpzjw@mail.gmail.com \
    --to=ed.czeck@atomicrules.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=akhil.goyal@nxp.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=irusskikh@marvell.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=john.miller@atomicrules.com \
    --cc=kishore.padmanabha@broadcom.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=michael.baucom@broadcom.com \
    --cc=nikhil.rao@intel.com \
    --cc=orika@nvidia.com \
    --cc=pbhagavatula@marvell.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=radu.nicolau@intel.com \
    --cc=rmody@marvell.com \
    --cc=sbhosle@broadcom.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=shshaikh@marvell.com \
    --cc=skori@marvell.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=stable@dpdk.org \
    --cc=tomasz.kantecki@intel.com \
    --cc=venkatkumar.duvvuru@broadcom.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git